ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()
PATCH v2 1/1 ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()
Changes in v2:
- Removed duplicate call to usb_put_urb() on submission failure.
- Removed extra blank line after the function.
The smatch tool reported a potential null pointer dereference in tascam_midi_in_urb_complete(). The 'tascam' variable, derived from 'urb->context', was checked for nullity in one place, but dereferenced without a check in several other places.
This patch fixes the issue by adding a null check at the beginning of the function. If 'tascam' is null, the function now safely exits. This prevents any potential crashes from null pointer dereferences.
It also fixes a latent bug where 'usb_put_urb()' could be called twice for the same URB on submission failure, which would lead to a use-after-free error.
--- sound/usb/usx2y/us144mkii_midi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
sound/usb/usx2y/us144mkii_midi.c +6 -2
@@ -41,6 +41,9 @@ void tascam_midi_in_urb_complete(struct urb *urb)struct tascam_card *tascam = urb->context;int ret; +if (!tascam) + goto out; +if (urb->status) {if (urb->status != -ENOENT && urb->status != -ECONNRESET && urb->status != -ESHUTDOWN && urb->status != -EPROTO ) {
@@ -51,7 +54,7 @@ void tascam_midi_in_urb_complete(struct urb *urb) goto out; } -if (tascam &&atomic_read (&tascam->midi_in_active) && +if (atomic_read (&tascam->midi_in_active) && urb->actual_length >0 ) {kfifo_in_spinlocked (&tascam->midi_in_fifo, urb->transfer_buffer, urb->actual_length, &tascam->midi_in_lock);
@@ -65,8 +68,9 @@ void tascam_midi_in_urb_complete(struct urb *urb)dev_err (tascam->card->dev,"Failed to resubmit MIDI IN URB: error %d\n" , ret);usb_unanchor_urb (urb); -usb_put_urb (urb); + goto out; } + out:usb_put_urb (urb); }
Signature · 1 line
2.50.1
Quoted 14 lines · Šerif Rami
Changes in v2:
- Removed duplicate call tousb_put_urb()on submission failure.
- Removed extra blank line after the function.The smatch tool reported a potential null pointer dereference in
tascam_midi_in_urb_complete(). The 'tascam' variable, derived from 'urb->context', was checked for nullity in one place, but dereferenced without a check in several other places.This patch fixes the issue by adding a null check at the beginning of the function. If 'tascam' is null, the function now safely exits. This prevents any potential crashes from null pointer dereferences.
Quoted 7 lines
It also fixes a latent bug where '
usb_put_urb()' could be called twice for the same URB on submission failure, which would lead to a use-after-free error.Reported-by Dan Carpenter <[email protected]>Signed-off-by Šerif Rami <[email protected]>
Applied now. Thanks.
Takashi
Awesome. Thanks!
regards,
dan carpenter