Skip to contentSkip to conversation

tools/intel_vbt_decode: convert copyright signs from latin1 to utf8

PATCH In review Jani Nikula 2 participants 3 messages Aug 20, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools/intel_vbt_decode: convert copyright signs from latin1 to utf8

Various tools trip over with latin1 characters in the source, as nowadays everything pretty much expects utf8.

For example, [1] fails to apply in both Patchwork and b4, because somewhere along the way, the latin1 copyright sign has in fact been automagically converted to utf8, and the source still has latin1.

Instead of debugging legacy encodings and conversions, just convert the remaining latin1 files to utf8 using iconv.

[1] https://lore.kernel.org/all/7090e70d712c94aed53f52c49a8155eb4c6b966c.1755175663.git.jani.nikula@intel.com/

Cc Kamil Konieczny <[email protected]>

---

v2: Rebase, intel_bios.h no longer exists.

I'll be trying 'git send-email --8bit-encoding=iso-8859-1' on this one. Fingers crossed.

---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/intel_vbt_decode.c +1 -1
index 6882ae1d2f63..a4e76b7559d2 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2006 Intel Corporation
+ * Copyright © 2006 Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
Signature · 1 line
2.47.2
Reviewed-by on v2 1/1
#1 lore raw

Hi Jani,

Quoted 7 lines · Jani Nikula

Various tools trip over with latin1 characters in the source, as nowadays everything pretty much expects utf8.

For example, [1] fails to apply in both Patchwork and b4, because somewhere along the way, the latin1 copyright sign has in fact been automagically converted to utf8, and the source still has latin1.

Quoted 7 lines

Instead of debugging legacy encodings and conversions, just convert the remaining latin1 files to utf8 using iconv.

[1] https://lore.kernel.org/all/7090e70d712c94aed53f52c49a8155eb4c6b966c.1755175663.git.jani.nikula@intel.com/

Cc Kamil Konieczny <[email protected]>

Thank you for a fix, I will merge it soon with small change in subject, s/sings/sign/ as this is only one file and one char.

Regards,
Kamil

Quoted 25 lines

---

v2: Rebase, intel_bios.h no longer exists.

I'll be trying 'git send-email --8bit-encoding=iso-8859-1' on this one. Fingers crossed.

---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/intel_vbt_decode.c +1 -1
index 6882ae1d2f63..a4e76b7559d2 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2006 Intel Corporation
+ * Copyright © 2006 Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
Signature · 1 line
2.47.2
#2 lore raw
Quoted 14 lines · Kamil Konieczny

Hi Jani,

Quoted 12 lines · Jani Nikula

Various tools trip over with latin1 characters in the source, as nowadays everything pretty much expects utf8.

For example, [1] fails to apply in both Patchwork and b4, because somewhere along the way, the latin1 copyright sign has in fact been automagically converted to utf8, and the source still has latin1.

Instead of debugging legacy encodings and conversions, just convert the remaining latin1 files to utf8 using iconv.

[1] https://lore.kernel.org/all/7090e70d712c94aed53f52c49a8155eb4c6b966c.1755175663.git.jani.nikula@intel.com/

Quoted 7 lines
Quoted 2 lines
Cc Kamil Konieczny <[email protected]>

Thank you for a fix, I will merge it soon with small change in subject, s/sings/sign/ as this is only one file and one char.

Thanks!

BR,
Jani.

Quoted 29 lines

Regards,
Kamil

Quoted 25 lines

---

v2: Rebase, intel_bios.h no longer exists.

I'll be trying 'git send-email --8bit-encoding=iso-8859-1' on this one. Fingers crossed.

---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/intel_vbt_decode.c +1 -1
index 6882ae1d2f63..a4e76b7559d2 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2006 Intel Corporation
+ * Copyright © 2006 Intel Corporation
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
Signature · 1 line
2.47.2
Signature · 1 line
Jani Nikula, Intel