Documentation/wmi: Fix Typo Error in doc
Subsystems (4)
PATCH 1/1 Documentation/wmi: Fix Typo Error in doc
Fix to correct spelling of "Hardware"
--- Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +1 -1
@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data); [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data); [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); - [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); }; [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]
Signature · 1 line
2.43.0
Derek J. Clark
maintainerQuoted 2 lines · Alperen Aksu
Fix to correct spelling of "Hardware"
Hi Alperen,
While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.
- Derek
Quoted 10 lines
Signed-off-by Alperen Aksu <[email protected]>---
Documentation/wmi/devices/lenovo-wmi-gamezone.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0
-0
Documentation/wmi/devices/lenovo-wmi-gamezone.rst data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: · line 132
Quoted 8 lines
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +1
-1@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data); [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data); [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); - [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); }; [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]
- Derek
Ilpo Järvinen
maintainerQuoted 6 lines · Derek J. Clark
Quoted 2 lines · Alperen Aksu
Fix to correct spelling of "Hardware"
Hi Alperen,
While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.
Yes, I'm not keen on accepting patches like this.
These are hardly something user reads as documentation anyway.
Quoted 23 lines
- Derek
Quoted 10 lines
Signed-off-by Alperen Aksu <[email protected]>---
Documentation/wmi/devices/lenovo-wmi-gamezone.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0
-0Documentation/wmi/devices/lenovo-wmi-gamezone.rst data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: · line 132
Quoted 8 lines
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +1
-1@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data); [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data); [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); - [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); }; [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]- Derek
Signature · 1 line
i.
Armin Wolf
maintainerAm 15.09.25 um 12:13 schrieb Ilpo Järvinen:
Quoted 10 lines · Derek J. Clark
Quoted 6 lines · Alperen Aksu
Quoted 2 lines
Fix to correct spelling of "Hardware"
Hi Alperen,
While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.
Yes, I'm not keen on accepting patches like this.
These are hardly something user reads as documentation anyway.
I agree with Derek, this part of the documentation contains text extracted from the underlying interface description of the device. While it is true that most WMI MOF descriptions contain spelling mistakes, correcting them just for the documentation serves no purpose.
So thank you for you effort, but the spelling fix is misplaced here.
Thanks,
Armin Wolf
Quoted 22 lines
Quoted 22 lines
- Derek
Quoted 10 lines
Signed-off-by Alperen Aksu <[email protected]>---
Documentation/wmi/devices/lenovo-wmi-gamezone.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Documentation/wmi/devices/lenovo-wmi-gamezone.rst +0
-0Documentation/wmi/devices/lenovo-wmi-gamezone.rst data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: · line 132
Quoted 8 lines
Documentation/wmi/devices/lenovo-wmi-gamezone.rst +1
-1@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data); [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data); [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); - [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); }; [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]- Derek