Skip to contentSkip to conversation

of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

PATCH In review Rob Herring (Arm) 3 participants 3 messages Aug 20, 2025 – Aug 21, 2025 Device tree

lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"') failed to set IORESOURCE_MEM flag on the resources. The result is functions such as devm_ioremap_resource_wc() will fail. Add the missing flag.

Fixes f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by Iuliana Prodan <[email protected]>
Reported-by Daniel Baluta <[email protected]>
Signed-off-by Rob Herring (Arm) <[email protected]>
---
 drivers/of/of_reserved_mem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/of_reserved_mem.c +1 -0
index 77016c0cc296..d3b7c4ae429c 100644
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
 		return -EINVAL;
 
 	resource_set_range(res, rmem->base, rmem->size);
+	res->flags = IORESOURCE_MEM;
 	res->name = rmem->name;
 	return 0;
 }
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring (Arm)

Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"') failed to set IORESOURCE_MEM flag on the resources. The result is functions such as devm_ioremap_resource_wc() will fail. Add the missing flag.

Fixes f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by Iuliana Prodan <[email protected]>
Reported-by Daniel Baluta <[email protected]>
Signed-off-by Rob Herring (Arm) <[email protected]>
Reviewed-by Saravana Kannan <[email protected]>

-Saravana

Quoted 19 lines
---
 drivers/of/of_reserved_mem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/of/of_reserved_mem.c +1 -1
index 77016c0cc296..d3b7c4ae429c 100644
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
                return -EINVAL;
 
        resource_set_range(res, rmem->base, rmem->size);
+       res->flags = IORESOURCE_MEM;
        res->name = rmem->name;
        return 0;
 }
--

2.50.1

Tested-by Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 9 lines · Rob Herring (Arm)

Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"') failed to set IORESOURCE_MEM flag on the resources. The result is functions such as devm_ioremap_resource_wc() will fail. Add the missing flag.

Fixes f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by Iuliana Prodan <[email protected]>
Reported-by Daniel Baluta <[email protected]>
Signed-off-by Rob Herring (Arm) <[email protected]>
Tested-by Iuliana Prodan <[email protected]>
Reviewed-by Iuliana Prodan <[email protected]>

Thanks,
Iulia

Quoted 16 lines
---
  drivers/of/of_reserved_mem.c | 1 +
  1 file changed, 1 insertion(+)
drivers/of/of_reserved_mem.c +1 -0
index 77016c0cc296..d3b7c4ae429c 100644
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
  		return -EINVAL;
 
  	resource_set_range(res, rmem->base, rmem->size);
+	res->flags = IORESOURCE_MEM;
  	res->name = rmem->name;
  	return 0;
  }