Skip to contentSkip to conversation

tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()

PATCH In review Thorsten Blum 3 participants 6 messages Aug 20, 2025 – Oct 7, 2025 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()

strcpy() is deprecated; use memcpy() instead.

---
 kernel/trace/trace_probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_probe.c +1 -1
index 5cbdc423afeb..d3ba5869d32c 100644
@@ -214,7 +214,7 @@ void __trace_probe_log_err(int offset, int err_type)
 	p = command;
 	for (i = 0; i < trace_probe_log.argc; i++) {
 		len = strlen(trace_probe_log.argv[i]);
-		strcpy(p, trace_probe_log.argv[i]);
+		memcpy(p, trace_probe_log.argv[i], len);
 		p[len] = ' ';
 		p += len + 1;
 	}
Signature · 1 line
2.50.1
#1 lore raw
Quoted 4 lines · On Wed, 20 Aug 2025 23:47:18 +0200 Thorsten Blum <[email protected]>…

strcpy() is deprecated; use memcpy() instead.

OK, looks good to me.

Thanks,

Quoted 20 lines
---
 kernel/trace/trace_probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_probe.c +1 -1
index 5cbdc423afeb..d3ba5869d32c 100644
@@ -214,7 +214,7 @@ void __trace_probe_log_err(int offset, int err_type)
 	p = command;
 	for (i = 0; i < trace_probe_log.argc; i++) {
 		len = strlen(trace_probe_log.argv[i]);
-		strcpy(p, trace_probe_log.argv[i]);
+		memcpy(p, trace_probe_log.argv[i], len);
 		p[len] = ' ';
 		p += len + 1;
 	}
Signature · 1 line
2.50.1
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
#3 lore raw
Quoted 6 lines · On Mon, 8 Sep 2025 12:13:23 +0200 Thorsten Blum <[email protected]> wrote:

Hi Masami,

Quoted 3 lines · Masami Hiramatsu (Google)

On Wed, 20 Aug 2025 23:47:18 +0200
Thorsten Blum <[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

strcpy() is deprecated; use memcpy() instead.

OK, looks good to me.

Did you forget to add a Reviewed-by: tag and/or to add it to your tree?

Thanks for ping me. No problem, I will add my Signed-by when picking this to probes/for-next.
Since I will be responsible for applying this patch and sending it to Linus, this includes the "Reviewed-by" as well.

Thank you,

Quoted 4 lines

Thanks,
Thorsten

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
maintainer
#4 lore raw
Quoted 14 lines · On Tue, 9 Sep 2025 08:53:08 +0900 Masami Hiramatsu (Google)…
Quoted 11 lines · On Mon, 8 Sep 2025 12:13:23 +0200 Thorsten Blum <[email protected]> wrote:

Hi Masami,

Quoted 8 lines · Masami Hiramatsu (Google)
Quoted 4 lines · On Wed, 20 Aug 2025 23:47:18 +0200 Thorsten Blum <[email protected]>…

strcpy() is deprecated; use memcpy() instead.

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

OK, looks good to me.

Did you forget to add a Reviewed-by: tag and/or to add it to your tree?

Thanks for ping me. No problem, I will add my Signed-by when picking this to probes/for-next.
Since I will be responsible for applying this patch and sending it to Linus, this includes the "Reviewed-by" as well.

Was this ever sent to Linus?

-- Steve

#5 lore raw
Quoted 21 lines · On Tue, 7 Oct 2025 19:14:15 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 18 lines · On Tue, 9 Sep 2025 08:53:08 +0900 Masami Hiramatsu (Google)…
Quoted 14 lines · On Mon, 8 Sep 2025 12:13:23 +0200 Thorsten Blum <[email protected]> wrote:

Hi Masami,

Quoted 9 lines · Masami Hiramatsu (Google)
Quoted 4 lines · On Wed, 20 Aug 2025 23:47:18 +0200 Thorsten Blum <[email protected]>…

strcpy() is deprecated; use memcpy() instead.

OK, looks good to me.

Did you forget to add a Reviewed-by: tag and/or to add it to your tree?

Quoted 7 lines
Quoted 5 lines

Thanks for ping me. No problem, I will add my Signed-by when picking this to probes/for-next.
Since I will be responsible for applying this patch and sending it to Linus, this includes the "Reviewed-by" as well.

Was this ever sent to Linus?

Yeah, but rejected with other patches in probes/for-next. I thought it was a part of cleanup, or should I sent it urgently? Then I can move this to probes/fixes.

Thank you,

Quoted 2 lines

-- Steve

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>