spi: rb4xx: add COMPILE_TEST support
PATCH 1/1 spi: rb4xx: add COMPILE_TEST support
Copy macros from ath79 SPI driver to allow compilation on all platforms and remove ath79 specific header.
--- drivers/spi/Kconfig | 2 +- drivers/spi/spi-rb4xx.c | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-)
drivers/spi/Kconfig +1 -1
@@ -916,7 +916,7 @@ config SPI_ROCKCHIP_SFC config SPI_RB4XX tristate "Mikrotik RB4XX SPI master" - depends on SPI_MASTER && ATH79 + depends on SPI_MASTER && ATH79 || COMPILE_TEST help SPI controller driver for the Mikrotik RB4xx series boards.
drivers/spi/spi-rb4xx.c +14 -5
@@ -16,7 +16,16 @@#include <linux/spi/spi.h> #include <linux/of.h> -#include <asm/mach-ath79/ar71xx_regs.h> +#define AR71XX_SPI_REG_FS 0x00/* Function Select */ +#define AR71XX_SPI_REG_CTRL 0x04/* SPI Control */ +#define AR71XX_SPI_REG_IOC 0x08/* SPI I/O Control */ +#define AR71XX_SPI_REG_RDS 0x0c/* Read Data Shift */ + +#define AR71XX_SPI_FS_GPIO BIT(0)/* Enable GPIO mode */ + +#define AR71XX_SPI_IOC_DO BIT(0)/* Data Out pin */ +#define AR71XX_SPI_IOC_CLK BIT(8)/* CLK pin */ +#define AR71XX_SPI_IOC_CS (n) BIT(16 + (n))struct rb4xx_spi {void __iomem *base;
@@ -63,7 +72,7 @@ static inline void do_spi_clk_two(struct rb4xx_spi *rbspi, u32 spi_ioc,if (value &BIT (1 )) regval |=AR71XX_SPI_IOC_DO ;if (value &BIT (0 )) - regval |=AR71XX_SPI_IOC_CS2 ; + regval |=AR71XX_SPI_IOC_CS (2 );rb4xx_write (rbspi,AR71XX_SPI_REG_IOC , regval);rb4xx_write (rbspi,AR71XX_SPI_REG_IOC , regval |AR71XX_SPI_IOC_CLK );
@@ -89,7 +98,7 @@ static void rb4xx_set_cs(struct spi_device *spi, bool enable)*/ if (enable)rb4xx_write (rbspi,AR71XX_SPI_REG_IOC , -AR71XX_SPI_IOC_CS0 |AR71XX_SPI_IOC_CS1 ); +AR71XX_SPI_IOC_CS (0 ) |AR71XX_SPI_IOC_CS (1 )); } static int rb4xx_transfer_one(struct spi_controller *host,
@@ -109,10 +118,10 @@ static int rb4xx_transfer_one(struct spi_controller *host,*/ if (spi_get_chipselect (spi,0 ) ==2 )/* MMC */ - spi_ioc =AR71XX_SPI_IOC_CS0 ; + spi_ioc =AR71XX_SPI_IOC_CS (0 );else /* Boot flash and CPLD */ - spi_ioc =AR71XX_SPI_IOC_CS1 ; + spi_ioc =AR71XX_SPI_IOC_CS (1 ); tx_buf = t->tx_buf; rx_buf = t->rx_buf;
Signature · 1 line
2.50.1
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Rosen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on linus/master v6.17-rc3 next-20250826] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/spi-rb4xx-add-COMPILE_TEST-support/20250821-113701 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next patch link: https://lore.kernel.org/r/20250821033534.638157-1-rosenp%40gmail.com patch subject: [PATCH] spi: rb4xx: add COMPILE_TEST support config: m68k-randconfig-r073-20250827 (https://download.01.org/0day-ci/archive/20250827/[email protected]/config) compiler: m68k-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250827/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/spi/spi-rb4xx.c:200:34: warning: 'rb4xx_spi_dt_match' defined but not used [-Wunused-const-variable=]
200 | static const struct of_device_id rb4xx_spi_dt_match[] = {
| ^~~~~~~~~~~~~~~~~~vim +/rb4xx_spi_dt_match +200 drivers/spi/spi-rb4xx.c
05aec357871f89 Bert Vermeulen 2015-04-15 199
9a436c62fbb4c5 Christopher Hill 2020-05-21 @200 static const struct of_device_id rb4xx_spi_dt_match[] = {
9a436c62fbb4c5 Christopher Hill 2020-05-21 201 { .compatible = "mikrotik,rb4xx-spi" },
9a436c62fbb4c5 Christopher Hill 2020-05-21 202 { },
9a436c62fbb4c5 Christopher Hill 2020-05-21 203 };
9a436c62fbb4c5 Christopher Hill 2020-05-21 204 MODULE_DEVICE_TABLE(of, rb4xx_spi_dt_match);9a436c62fbb4c5 Christopher Hill 2020-05-21 205
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki