Two-pass MMU interval notifiers
Subsystems (6)
Thomas Hellström
maintainercover Two-pass MMU interval notifiers
GPU use-cases for mmu_interval_notifiers with hmm often involve starting a gpu operation and then waiting for it to complete. These operations are typically context preemption or TLB flushing.
With single-pass notifiers per GPU this doesn't scale in multi-gpu scenarios. In those scenarios we'd want to first start preemption- or TLB flushing on all GPUs and as a second pass wait for them to complete.
One can do this on per-driver basis multiplexing per-driver notifiers but that would mean sharing the notifier "user" lock across all GPUs and that doesn't scale well either, so adding support for two-pass in the core appears like the right choice.
So this series does that, with pach 1 implementing the core support and also describes the choices made.
The rest of the patches implements a POC with drm_gpusvm, but this will also come in handy for things like userptr where waiting for bind completion, starting of preemption and waiting for preemption completion can pe pipelined across GPUs.
Matthew Brost (5):
drm/gpusvm, drm/xe: Update GPU SVM / Xe to twopass MMU notifier drm/gpusvm: Add drm_gpusvm_in_notifier_* helpers
drm/xe: Skip waiting on unarmed fences in
xe_gt_tlb_invalidation_fence_wait
drm/xe: Add fences argument to xe_vm_range_tilemask_tlb_invalidation drm/xe: Implement two pass MMU notifiers for SVM
Thomas Hellström (1):
mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
drivers/gpu/drm/drm_gpusvm.c | 18 +++-- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h | 3 +- drivers/gpu/drm/xe/xe_svm.c | 83 +++++++++++++++++---- drivers/gpu/drm/xe/xe_vm.c | 26 ++++--- drivers/gpu/drm/xe/xe_vm.h | 6 +- include/drm/drm_gpusvm.h | 33 ++++++-- include/linux/mmu_notifier.h | 42 +++++++++++ mm/mmu_notifier.c | 63 +++++++++++++--- 8 files changed, 224 insertions(+), 50 deletions(-)
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 1/6 mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
GPU use-cases for mmu_interval_notifiers with hmm often involve starting a gpu operation and then waiting for it to complete. These operations are typically context preemption or TLB flushing.
With single-pass notifiers per GPU this doesn't scale in multi-gpu scenarios. In those scenarios we'd want to first start preemption- or TLB flushing on all GPUs and as a second pass wait for them to complete.
One can do this on per-driver basis multiplexing per-driver notifiers but that would mean sharing the notifier "user" lock across all GPUs and that doesn't scale well either, so adding support for multi-pass in the core appears to be the right choice.
Implement two-pass capability in the mmu_interval_notifier. Use a linked list for the final passes to minimize the impact for use-cases that don't need the multi-pass functionality by avoiding a second interval tree walk, and to be able to easily pass data between the two passes.
v1:
- Restrict to two passes (Jason Gunthorpe)
- Improve on documentation (Jason Gunthorpe)
- Improve on function naming (Alistair Popple)
--- include/linux/mmu_notifier.h | 42 ++++++++++++++++++++++++ mm/mmu_notifier.c | 63 ++++++++++++++++++++++++++++++------ 2 files changed, 96 insertions(+), 9 deletions(-)
include/linux/mmu_notifier.h +42 -0
@@ -233,16 +233,58 @@ struct mmu_notifier {unsigned int users; }; +/** +* struct mmu_interval_notifier_finish - mmu_interval_notifier two-pass abstraction +* @link: List link for the notifiers pending pass list +* +* Allocate, typically using GFP_NOWAIT in the interval notifier's first pass. +* If allocation fails (which is not unlikely under memory pressure), fall back +* to single-pass operation. Note that with a large number of notifiers +* implementing two passes, allocation with GFP_NOWAIT will become increasingly +* likely to fail, so consider implementing a small pool instead of using +* kmalloc() allocations. +* +* If the implementation needs to pass data between the two passes, +* the recommended way is to embed strct mmu_interval_notifier_finish into a larger +* structure that also contains the data needed to be shared. Keep in mind that +* a notifier callback can be invoked in parallel, and each invocation needs its +* own struct mmu_interval_notifier_finish. +*/ +struct mmu_interval_notifier_finish { +struct list_head link; +/** +* @finish: Driver callback for the finish pass. +* @final: Pointer to the mmu_interval_notifier_finish structure. +* @range: The mmu_notifier_range. +* @cur_seq: The current sequence set by the first pass. +* +* Note that there is no error reporting for additional passes. +*/ +void (*finish)(struct mmu_interval_notifier_finish *final, +const struct mmu_notifier_range *range, +unsigned long cur_seq); +}; +/** * struct mmu_interval_notifier_ops * @invalidate: Upon return the caller must stop using any SPTEs within this * range. This function can sleep. Return false only if sleeping * was required but mmu_notifier_range_blockable(range) is false. +* @invalidate_start: Similar to @invalidate, but intended for two-pass notifier +* callbacks where the callto @invalidate_start is the first +* pass and any struct mmu_interval_notifier_finish pointer +* returned in the @fini parameter describes the final pass. +* If @fini is %NULL on return, then no final pass will be +* called. */ struct mmu_interval_notifier_ops {bool (*invalidate)(struct mmu_interval_notifier *interval_sub,const struct mmu_notifier_range *range,unsigned long cur_seq); +bool (*invalidate_start)(struct mmu_interval_notifier *interval_sub, +const struct mmu_notifier_range *range, +unsigned long cur_seq, +struct mmu_interval_notifier_finish **final); };struct mmu_interval_notifier {
mm/mmu_notifier.c +54 -9
107 lines not on this page · raw message
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 2/6 drm/gpusvm, drm/xe: Update GPU SVM / Xe to twopass MMU notifier
In reply to Thomas HellströmFrom: Matthew Brost <[email protected]>
Update GPU SVM and Xe to use two-pass MMU notifiers, enabling pipelined TLB invalidations across VMs or multiple devices.
The driver-side (Xe) implementation is not yet implemented.
v1:
- Update function naming and comments.
--- drivers/gpu/drm/drm_gpusvm.c | 18 +++++++++++------- drivers/gpu/drm/xe/xe_svm.c | 9 +++++---- include/drm/drm_gpusvm.h | 11 +++++++---- 3 files changed, 23 insertions(+), 15 deletions(-)
drivers/gpu/drm/drm_gpusvm.c +11 -7
@@ -374,10 +374,13 @@ notifier_iter_first(struct rb_root_cached *root, unsigned long start, (notifier__) = (next__), (next__) = __drm_gpusvm_notifier_next(notifier__))/** -* drm_gpusvm_notifier_invalidate() - Invalidate a GPU SVM notifier. +* drm_gpusvm_notifier_invalidate_start() - Invalidate a GPU SVM notifier, +* fist pass. +* * @mni: Pointer to the mmu_interval_notifier structure. * @mmu_range: Pointer to the mmu_notifier_range structure. * @cur_seq: Current sequence number. +* @final: First pass of MMU notifier * * This function serves as a generic MMU notifier for GPU SVM. It sets the MMU * notifier sequence number and calls the driver invalidate vfunc under
@@ -386,9 +389,10 @@ notifier_iter_first(struct rb_root_cached *root, unsigned long start,* Return: true if the operation succeeds, false otherwise. */ static bool -drm_gpusvm_notifier_invalidate (struct mmu_interval_notifier *mni, -const struct mmu_notifier_range *mmu_range, -unsigned long cur_seq) +drm_gpusvm_notifier_invalidate_start (struct mmu_interval_notifier *mni, +const struct mmu_notifier_range *mmu_range, +unsigned long cur_seq, +struct mmu_interval_notifier_finish **final) {struct drm_gpusvm_notifier *notifier =container_of (mni,typeof (*notifier), notifier);
@@ -399,7 +403,7 @@ drm_gpusvm_notifier_invalidate(struct mmu_interval_notifier *mni,down_write (&gpusvm->notifier_lock);mmu_interval_set_seq (mni, cur_seq); - gpusvm->ops->invalidate (gpusvm, notifier, mmu_range); + gpusvm->ops->invalidate_start (gpusvm, notifier, mmu_range, final);up_write (&gpusvm->notifier_lock);return true;
@@ -409,7 +413,7 @@ drm_gpusvm_notifier_invalidate(struct mmu_interval_notifier *mni,* drm_gpusvm_notifier_ops - MMU interval notifier operations for GPU SVM */ static const struct mmu_interval_notifier_ops drm_gpusvm_notifier_ops = { - .invalidate = drm_gpusvm_notifier_invalidate, + .invalidate_start = drm_gpusvm_notifier_invalidate_start, };/**
@@ -440,7 +444,7 @@ int drm_gpusvm_init(struct drm_gpusvm *gpusvm,const struct drm_gpusvm_ops *ops, const unsigned long *chunk_sizes, int num_chunks) { - if (!ops->invalidate || !num_chunks) + if (!ops->invalidate_start || !num_chunks) return -EINVAL; gpusvm->name = name;
drivers/gpu/drm/xe/xe_svm.c +5 -4
@@ -171,9 +171,10 @@ xe_svm_range_notifier_event_end(struct xe_vm *vm, struct drm_gpusvm_range *r, mmu_range); } -static void xe_svm_invalidate (struct drm_gpusvm *gpusvm, -struct drm_gpusvm_notifier *notifier, -const struct mmu_notifier_range *mmu_range) +static void xe_svm_invalidate_start (struct drm_gpusvm *gpusvm, +struct drm_gpusvm_notifier *notifier, +const struct mmu_notifier_range *mmu_range, +struct mmu_interval_notifier_finish **final) {struct xe_vm *vm =gpusvm_to_vm (gpusvm);struct xe_device *xe = vm->xe;
@@ -553,7 +554,7 @@ static const struct drm_pagemap_devmem_ops dpagemap_devmem_ops = {static const struct drm_gpusvm_ops gpusvm_ops = { .range_alloc = xe_svm_range_alloc, .range_free = xe_svm_range_free, - .invalidate = xe_svm_invalidate, + .invalidate_start = xe_svm_invalidate_start, };static const unsigned long fault_chunk_sizes[] = {
include/drm/drm_gpusvm.h +7 -4
@@ -63,17 +63,20 @@ struct drm_gpusvm_ops {void (*range_free)(struct drm_gpusvm_range *range);/** -* @invalidate: Invalidate GPU SVM notifier (required) +* @invalidate_start: Invalidate first pass GPU SVM notifier (required) * @gpusvm: Pointer to the GPU SVM * @notifier: Pointer to the GPU SVM notifier * @mmu_range: Pointer to the mmu_notifier_range structure +* @final: Final pass of MMU notifier, optionally populated by the driver side +* if a final pass of MMU notifier is desired * * Invalidate the GPU page tables. It can safely walk the notifier range * RB tree/list in this function. Called while holding the notifier lock. */ -void (*invalidate)(struct drm_gpusvm *gpusvm, -struct drm_gpusvm_notifier *notifier, -const struct mmu_notifier_range *mmu_range); +void (*invalidate_start)(struct drm_gpusvm *gpusvm, +struct drm_gpusvm_notifier *notifier, +const struct mmu_notifier_range *mmu_range, +struct mmu_interval_notifier_finish **final); };/**
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 3/6 drm/gpusvm: Add drm_gpusvm_in_notifier_* helpers
In reply to Thomas HellströmFrom: Matthew Brost <[email protected]>
Abstract drm_gpusvm_in_notifier_lock/unlock with helpers. Intended usage is a client side 2nd pass of a MMU notifier.
--- include/drm/drm_gpusvm.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)
include/drm/drm_gpusvm.h +20 -2
@@ -313,7 +313,7 @@ void drm_gpusvm_range_set_unmapped(struct drm_gpusvm_range *range,#endif /** -* drm_gpusvm_notifier_lock() - Lock GPU SVM notifier +* drm_gpusvm_notifier_lock() - Lock GPU SVM notifier, client side * @gpusvm__: Pointer to the GPU SVM structure. * * Abstract client usage GPU SVM notifier lock, take lock
@@ -322,7 +322,7 @@ void drm_gpusvm_range_set_unmapped(struct drm_gpusvm_range *range,down_read (&(gpusvm__)->notifier_lock)/** -* drm_gpusvm_notifier_unlock() - Unlock GPU SVM notifier +* drm_gpusvm_notifier_unlock() - Unlock GPU SVM notifier, client side * @gpusvm__: Pointer to the GPU SVM structure. * * Abstract client usage GPU SVM notifier lock, drop lock
@@ -330,6 +330,24 @@ void drm_gpusvm_range_set_unmapped(struct drm_gpusvm_range *range,#define drm_gpusvm_notifier_unlock (gpusvm__) \ up_read(&(gpusvm__)->notifier_lock) +/** +* drm_gpusvm_in_notifier_lock() - Lock GPU SVM notifier, in notifier +* @gpusvm__: Pointer to the GPU SVM structure. +* +* Abstract in notifier (2nd pass) usage GPU SVM notifier lock, take lock +*/ +#define drm_gpusvm_in_notifier_lock (gpusvm__) \ + down_write(&(gpusvm__)->notifier_lock) + +/** +* drm_gpusvm_in_notifier_unlock() - Unlock GPU SVM notifier, in notifier +* @gpusvm__: Pointer to the GPU SVM structure. +* +* Abstract in notifier (2nd pass) GPU SVM notifier lock, drop lock +*/ +#define drm_gpusvm_in_notifier_unlock (gpusvm__) \ + up_write(&(gpusvm__)->notifier_lock) +/** * drm_gpusvm_range_start() - GPU SVM range start address * @range: Pointer to the GPU SVM range
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 4/6 drm/xe: Skip waiting on unarmed fences in xe_gt_tlb_invalidation_fence_wait
In reply to Thomas HellströmFrom: Matthew Brost <[email protected]>
Avoids unnecessary waits when the TLB invalidation fence has not been armed, simplifying caller logic in cases where the fence status is uncertain.
--- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h +2 -1
@@ -34,7 +34,8 @@ void xe_gt_tlb_invalidation_fence_signal(struct xe_gt_tlb_invalidation_fence *festatic inline void xe_gt_tlb_invalidation_fence_wait (struct xe_gt_tlb_invalidation_fence *fence) { -dma_fence_wait (&fence->base, false); +if (fence->seqno) +dma_fence_wait (&fence->base, false); }#endif /* _XE_GT_TLB_INVALIDATION_ */
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 5/6 drm/xe: Add fences argument to xe_vm_range_tilemask_tlb_invalidation
In reply to Thomas HellströmFrom: Matthew Brost <[email protected]>
Introduce a fences argument to xe_vm_range_tilemask_tlb_invalidation, allowing callers to provide fences and defer waiting to a later point.
--- drivers/gpu/drm/xe/xe_svm.c | 3 ++- drivers/gpu/drm/xe/xe_vm.c | 26 +++++++++++++++++--------- drivers/gpu/drm/xe/xe_vm.h | 6 ++++-- 3 files changed, 23 insertions(+), 12 deletions(-)
drivers/gpu/drm/xe/xe_svm.c +2 -1
@@ -226,7 +226,8 @@ static void xe_svm_invalidate_start(struct drm_gpusvm *gpusvm,xe_device_wmb (xe); - err =xe_vm_range_tilemask_tlb_invalidation (vm, adj_start, adj_end, tile_mask); + err =xe_vm_range_tilemask_tlb_invalidation (vm,NULL , adj_start, + adj_end, tile_mask);WARN_ON_ONCE (err); range_notifier_event_end:
drivers/gpu/drm/xe/xe_vm.c +17 -9
@@ -3871,6 +3871,7 @@ void xe_vm_unlock(struct xe_vm *vm)* xe_vm_range_tilemask_tlb_invalidation - Issue a TLB invalidation on this tilemask for an * address range * @vm: The VM +* @fences: Caller provided fences, caller owns waiting if non-NULL * @start: start address * @end: end address * @tile_mask: mask for which gt's issue tlb invalidation
@@ -3879,10 +3880,12 @@ void xe_vm_unlock(struct xe_vm *vm)* * Returns 0 for success, negative error code otherwise. */ -int xe_vm_range_tilemask_tlb_invalidation (struct xe_vm *vm,u64 start, -u64 end,u8 tile_mask) +int xe_vm_range_tilemask_tlb_invalidation (struct xe_vm *vm, +struct xe_gt_tlb_invalidation_fence *fences, +u64 start,u64 end,u8 tile_mask) {struct xe_gt_tlb_invalidation_fence fence[XE_MAX_TILES_PER_DEVICE *XE_MAX_GT_PER_TILE ]; +struct xe_gt_tlb_invalidation_fence *__fence = fences ?: fence;struct xe_tile *tile;u32 fence_id =0 ;u8 id;
@@ -3894,37 +3897,41 @@ int xe_vm_range_tilemask_tlb_invalidation(struct xe_vm *vm, u64 start,for_each_tile (tile, vm->xe, id) {if (tile_mask &BIT (id)) {xe_gt_tlb_invalidation_fence_init (tile->primary_gt, - &fence[fence_id], true); + __fence, true); err =xe_gt_tlb_invalidation_range (tile->primary_gt, - &fence[fence_id], + __fence, start, end, vm->usm.asid);if (err) goto wait; ++fence_id; + ++__fence;if (!tile->media_gt)continue ;xe_gt_tlb_invalidation_fence_init (tile->media_gt, - &fence[fence_id], true); + __fence, true); err =xe_gt_tlb_invalidation_range (tile->media_gt, - &fence[fence_id], + __fence, start, end, vm->usm.asid);if (err) goto wait; ++fence_id; + ++__fence; } } wait: -for (id =0 ; id < fence_id; ++id) -xe_gt_tlb_invalidation_fence_wait (&fence[id]); +if (!fences) { +for (id =0 ; id < fence_id; ++id) +xe_gt_tlb_invalidation_fence_wait (&fence[id]); + }return err; }
@@ -3983,7 +3990,8 @@ int xe_vm_invalidate_vma(struct xe_vma *vma)xe_device_wmb (xe); - ret =xe_vm_range_tilemask_tlb_invalidation (xe_vma_vm (vma),xe_vma_start (vma), + ret =xe_vm_range_tilemask_tlb_invalidation (xe_vma_vm (vma),NULL , +xe_vma_start (vma),xe_vma_end (vma), tile_mask);/* WRITE_ONCE pairs with READ_ONCE in xe_vm_has_valid_gpu_mapping() */
drivers/gpu/drm/xe/xe_vm.h +4 -2
@@ -22,6 +22,7 @@ struct dma_fence;struct xe_exec_queue ;struct xe_file ; +struct xe_gt_tlb_invalidation_fence ;struct xe_sync_entry ;struct xe_svm_range ;struct drm_exec ;
@@ -228,8 +229,9 @@ struct dma_fence *xe_vm_range_rebind(struct xe_vm *vm,struct dma_fence *xe_vm_range_unbind (struct xe_vm *vm,struct xe_svm_range *range); -int xe_vm_range_tilemask_tlb_invalidation (struct xe_vm *vm,u64 start, -u64 end,u8 tile_mask); +int xe_vm_range_tilemask_tlb_invalidation (struct xe_vm *vm, +struct xe_gt_tlb_invalidation_fence *fences, +u64 start,u64 end,u8 tile_mask);int xe_vm_invalidate_vma (struct xe_vma *vma);
Signature · 1 line
2.50.1
Thomas Hellström
maintainerPATCH 6/6 drm/xe: Implement two pass MMU notifiers for SVM
In reply to Thomas HellströmFrom: Matthew Brost <[email protected]>
Implement two-pass MMU notifiers for SVM, enabling multiple VMs or devices with GPU mappings to pipeline costly TLB invalidations by issuing them in the first pass and waiting for completion in the second.
v1:
- Adjust naming.
--- drivers/gpu/drm/xe/xe_svm.c | 73 +++++++++++++++++++++++++++++++------ 1 file changed, 61 insertions(+), 12 deletions(-)
drivers/gpu/drm/xe/xe_svm.c +61 -12
@@ -144,15 +144,8 @@ xe_svm_range_notifier_event_begin(struct xe_vm *vm, struct drm_gpusvm_range *r,* invalidations spanning multiple ranges. */ for_each_tile (tile, xe, id) -if (xe_pt_zap_ptes_range (tile, vm, range)) { +if (xe_pt_zap_ptes_range (tile, vm, range)) tile_mask |=BIT (id); -/* -* WRITE_ONCE pairs with READ_ONCE in -* xe_vm_has_valid_gpu_mapping() -*/ -WRITE_ONCE (range->tile_invalidated, - range->tile_invalidated |BIT (id)); - }return tile_mask; }
@@ -161,16 +154,59 @@ static void xe_svm_range_notifier_event_end(struct xe_vm *vm, struct drm_gpusvm_range *r, const struct mmu_notifier_range *mmu_range) { + struct xe_svm_range *range = to_xe_range(r);struct drm_gpusvm_ctx ctx = { .in_notifier = true, };xe_svm_assert_in_notifier (vm); +/* +* WRITE_ONCE pairs with READ_ONCE in xe_vm_has_valid_gpu_mapping() +*/ +WRITE_ONCE (range->tile_invalidated, range->tile_present); +drm_gpusvm_range_unmap_pages (&vm->svm.gpusvm, r, &ctx);if (!xe_vm_is_closed (vm) && mmu_range->event ==MMU_NOTIFY_UNMAP )xe_svm_garbage_collector_add_range (vm,to_xe_range (r), mmu_range); } +struct xe_svm_invalidate_finish { +struct drm_gpusvm *gpusvm; +struct drm_gpusvm_notifier *notifier; +#define XE_SVM_INVALIDATE_FENCE_COUNT \ + (XE_MAX_TILES_PER_DEVICE * XE_MAX_GT_PER_TILE) +struct xe_gt_tlb_invalidation_fence fences[XE_SVM_INVALIDATE_FENCE_COUNT ]; +struct mmu_interval_notifier_finish f; +}; + +static void +xe_svm_invalidate_finish (struct mmu_interval_notifier_finish *final, +const struct mmu_notifier_range *mmu_range, +unsigned long cur_seq) +{ +struct xe_svm_invalidate_finish *xe_final =container_of (final,typeof (*xe_final), f); +struct drm_gpusvm *gpusvm = xe_final->gpusvm; +struct drm_gpusvm_notifier *notifier = xe_final->notifier; +struct drm_gpusvm_range *r =NULL ; +struct xe_vm *vm =gpusvm_to_vm (gpusvm); +u64 adj_start = mmu_range->start, adj_end = mmu_range->end; +int id; + +/* Adjust invalidation to notifier boundaries */ + adj_start =max (drm_gpusvm_notifier_start (notifier), adj_start); + adj_end =min (drm_gpusvm_notifier_end (notifier), adj_end); + +for (id =0 ; id <XE_SVM_INVALIDATE_FENCE_COUNT ; ++id) +xe_gt_tlb_invalidation_fence_wait (&xe_final->fences[id]); + +drm_gpusvm_in_notifier_lock (gpusvm); +drm_gpusvm_for_each_range (r, notifier, adj_start, adj_end) +xe_svm_range_notifier_event_end (vm, r, mmu_range); +drm_gpusvm_in_notifier_unlock (gpusvm); + +kfree (xe_final); +} + static void xe_svm_invalidate_start(struct drm_gpusvm *gpusvm, struct drm_gpusvm_notifier *notifier, const struct mmu_notifier_range *mmu_range,
@@ -179,6 +215,8 @@ static void xe_svm_invalidate_start(struct drm_gpusvm *gpusvm,struct xe_vm *vm =gpusvm_to_vm (gpusvm);struct xe_device *xe = vm->xe;struct drm_gpusvm_range *r, *first; +struct xe_svm_invalidate_finish *xe_final =NULL ; +struct xe_gt_tlb_invalidation_fence *fences =NULL ;u64 adj_start = mmu_range->start, adj_end = mmu_range->end;u8 tile_mask =0 ;long err;
@@ -226,14 +264,25 @@ static void xe_svm_invalidate_start(struct drm_gpusvm *gpusvm,xe_device_wmb (xe); - err =xe_vm_range_tilemask_tlb_invalidation (vm,NULL , adj_start, + xe_final =kzalloc (sizeof (*xe_final),GFP_NOWAIT ); +if (xe_final) { + xe_final->gpusvm = gpusvm; + xe_final->notifier = notifier; + xe_final->f.finish = xe_svm_invalidate_finish; + fences = xe_final->fences; + *final = &xe_final->f; + } + + err =xe_vm_range_tilemask_tlb_invalidation (vm, fences, adj_start, adj_end, tile_mask);WARN_ON_ONCE (err); range_notifier_event_end: - r = first; -drm_gpusvm_for_each_range (r, notifier, adj_start, adj_end) -xe_svm_range_notifier_event_end (vm, r, mmu_range); +if (!xe_final) { + r = first; +drm_gpusvm_for_each_range (r, notifier, adj_start, adj_end) +xe_svm_range_notifier_event_end (vm, r, mmu_range); + } } static int __xe_svm_garbage_collector(struct xe_vm *vm,
Signature · 1 line
2.50.1
Thomas Hellström
maintainerRe: [PATCH 1/6] mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
In reply to Thomas HellströmHi,
@Jason, @Alistair, Gentle ping, could you have a look and R-B, Ack if OK?
Thanks,
Thomas
Quoted 275 lines · Thomas Hellström
GPU use-cases for
mmu_interval_notifierswith hmm often involve starting a gpu operation and then waiting for it to complete. These operations are typically context preemption or TLB flushing.With single-pass notifiers per GPU this doesn't scale in multi-gpu scenarios. In those scenarios we'd want to first start preemption- or TLB flushing on all GPUs and as a second pass wait for them to complete.
One can do this on per-driver basis multiplexing per-driver notifiers but that would mean sharing the notifier "user" lock across all GPUs and that doesn't scale well either, so adding support for multi-pass in the core appears to be the right choice.
Implement two-pass capability in the
mmu_interval_notifier. Use a linked list for the final passes to minimize the impact for use-cases that don't need the multi-pass functionality by avoiding a second interval tree walk, and to be able to easily pass data between the two passes.v1:
- Restrict to two passes (Jason Gunthorpe)
- Improve on documentation (Jason Gunthorpe)
- Improve on function naming (Alistair Popple)Cc Jason Gunthorpe <[email protected]>Cc Andrew Morton <[email protected]>Cc Simona Vetter <[email protected]>Cc Dave Airlie <[email protected]>Cc Alistair Popple <[email protected]>Cc <[email protected]>Cc <[email protected]>Cc <[email protected]>Signed-off-by Thomas Hellström <[email protected]>---
include/linux/mmu_notifier.h | 42 ++++++++++++++++++++++++ mm/mmu_notifier.c | 63 ++++++++++++++++++++++++++++++---- --2 files changed, 96 insertions(+), 9 deletions(-)include/linux/mmu_notifier.h +0
-0@@ -233,16 +233,58 @@ struct mmu_notifier { unsigned int users; };
+/**
+ * structmmu_interval_notifier_finish-mmu_interval_notifiertwo- pass abstraction
+ * @link: List link for the notifiers pending pass list
+ *
+ * Allocate, typically usingGFP_NOWAITin the interval notifier's first pass.
+ * If allocation fails (which is not unlikely under memory pressure), fall back
+ * to single-pass operation. Note that with a large number of notifiers
+ * implementing two passes, allocation withGFP_NOWAITwill become increasingly
+ * likely to fail, so consider implementing a small pool instead of using
+ *kmalloc()allocations.
+ *
+ * If the implementation needs to pass data between the two passes,
+ * the recommended way is to embed strctmmu_interval_notifier_finishinto a larger
+ * structure that also contains the data needed to be shared. Keep in mind that
+ * a notifier callback can be invoked in parallel, and each invocation needs its
+ * own structmmu_interval_notifier_finish.
+ */include/linux/mmu_notifier.h +5
-0+struct mmu_interval_notifier_finish { +struct list_head link; +/** +* @finish: Driver callback for the finish pass. +* @final: Pointer to the mmu_interval_notifier_finish structure.
include/linux/mmu_notifier.h +4
-0+* @range: The mmu_notifier_range. +* @cur_seq: The current sequence set by the first pass. +* +* Note that there is no error reporting for additional passes.
include/linux/mmu_notifier.h +6
-0+*/ +void (*finish)(struct mmu_interval_notifier_finish *final, + const struct mmu_notifier_range *range, + unsigned long cur_seq); +}; +/**
* structmmu_interval_notifier_ops
* @invalidate: Upon return the caller must stop using any SPTEs within this
* range. This function can sleep. Return false only if sleeping
* was required butmmu_notifier_range_blockable(range)is false.
+ * @invalidate_start: Similar to @invalidate, but intended for two- pass notifier
+ * callbacks where the callto @invalidate_start is the first
+ * pass and any structmmu_interval_notifier_finishpointer
+ * returned in the @fini parameter describes the final pass.
+ * If @fini is %NULL on return, then no final pass will be
+ * called.
*/
structmmu_interval_notifier_ops{
bool (*invalidate)(structmmu_interval_notifier*interval_sub,
const structmmu_notifier_range*range, unsigned longcur_seq);include/linux/mmu_notifier.h +1
-0+ bool (*invalidate_start)(struct mmu_interval_notifier
*interval_sub,include/linux/mmu_notifier.h +1
-0+ const struct mmu_notifier_range*range,
include/linux/mmu_notifier.h +2
-0+unsigned long cur_seq, + struct mmu_interval_notifier_finish**final);
};
structmmu_interval_notifier{mm/mmu_notifier.c +0
-0@@ -260,6 +260,18 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub) } EXPORT_SYMBOL_GPL(mmu_interval_read_begin);mm/mmu_notifier.c +2
-0+static void mn_itree_final_pass (struct list_head *final_passes, + const struct mmu_notifier_range*range,
mm/mmu_notifier.c +10
-0+ unsigned long cur_seq) +{ +struct mmu_interval_notifier_finish *f, *next; + +list_for_each_entry_safe (f, next, final_passes, link) { +list_del (&f->link); + f->finish (f, range, cur_seq); + } +} +static void mn_itree_release(struct
mmu_notifier_subscriptions*subscriptions,
structmm_struct*mm)
{mm/mmu_notifier.c +1
-0@@ -271,6 +283,7 @@ static void mn_itree_release(structmmu_notifier_subscriptions *subscriptions, .end = ULONG_MAX, }; struct mmu_interval_notifier *interval_sub; +LIST_HEAD (final_passes); unsigned long cur_seq; bool ret;mm/mmu_notifier.c +5
-2@@ -278,11 +291,25 @@ static void mn_itree_release(structmmu_notifier_subscriptions *subscriptions, mn_itree_inv_start_range(subscriptions, &range, &cur_seq); interval_sub; interval_sub = mn_itree_inv_next(interval_sub, &range)) { - ret = interval_sub->ops->invalidate (interval_sub, &range, - cur_seq); + if (interval_sub->ops->invalidate_start) { +struct mmu_interval_notifier_finish *final =NULL ; + + ret = interval_sub->ops- >invalidate_start(interval_sub, +&range,
mm/mmu_notifier.c +1
-0+
cur_seq,mm/mmu_notifier.c +1
-0+&final);
mm/mmu_notifier.c +2
-0+if (ret && final) + list_add_tail(&final->link,
&final_passes);mm/mmu_notifier.c +3
-0+ + }else { + ret = interval_sub->ops-Quoted 1 line
invalidate(interval_sub,
mm/mmu_notifier.c +2
-0+ &range, +
cur_seq);mm/mmu_notifier.c +1
-0+ }
WARN_ON(!ret);
}mm/mmu_notifier.c +1
-0+mn_itree_final_pass (&final_passes, &range, cur_seq);
mn_itree_inv_end(subscriptions);
}mm/mmu_notifier.c +0
-0@@ -430,7 +457,9 @@ static int mn_itree_invalidate(struct mmu_notifier_subscriptions *subscriptions,const struct
mmu_notifier_range*range)
{
structmmu_interval_notifier*interval_sub;mm/mmu_notifier.c +1
-0+LIST_HEAD (final_passes);unsigned long
cur_seq;mm/mmu_notifier.c +1
-0+int err =0 ;
for (interval_sub=mn_itree_inv_start_range(subscriptions, range, &cur_seq);mm/mmu_notifier.c +0
-0@@ -438,23 +467,39 @@ static int mn_itree_invalidate(structmmu_notifier_subscriptions *subscriptions, interval_sub = mn_itree_inv_next(interval_sub, range)) { bool ret;mm/mmu_notifier.c +0
-1- ret = interval_sub->ops->invalidate(interval_sub,range,
mm/mmu_notifier.c +2
-1- cur_seq); +if (interval_sub->ops->invalidate_start) { + struct mmu_interval_notifier_finish *final =NULL;
mm/mmu_notifier.c +2
-0+ + ret = interval_sub->ops-Quoted 1 line
invalidate_start(interval_sub,
mm/mmu_notifier.c +1
-0+range,
mm/mmu_notifier.c +1
-0+
cur_seq,mm/mmu_notifier.c +1
-0+&final);
mm/mmu_notifier.c +2
-0+if (ret && final) + list_add_tail(&final->link,
&final_passes);mm/mmu_notifier.c +3
-0+ + }else { + ret = interval_sub->ops-Quoted 1 line
invalidate(interval_sub,
mm/mmu_notifier.c +2
-0+ range, +
cur_seq);mm/mmu_notifier.c +1
-0+ }if (!ret) {
if
(WARN_ON(mmu_notifier_range_blockable(range)))
continue;mm/mmu_notifier.c +2
-1- goto out_would_block; + err = -EAGAIN ; +break ;}
}mm/mmu_notifier.c +0
-1-return 0 ;mm/mmu_notifier.c +2
-1-out_would_block: +mn_itree_final_pass (&final_passes, range, cur_seq); +/*
* On-EAGAINthe non-blocking caller is not allowed to call
*invalidate_range_end()
*/mm/mmu_notifier.c +4
-2-mn_itree_inv_end (subscriptions); -return -EAGAIN ; +if (err) +mn_itree_inv_end (subscriptions); + +return err;}
static int mn_hlist_invalidate_range_start(
Re: [PATCH 1/6] mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
In reply to Thomas Hellströminclude/linux/mmu_notifier.h struct mmu_notifier { · line 265
Quoted 13 lines · Thomas Hellström
include/linux/mmu_notifier.h +13
-0+struct mmu_interval_notifier_finish { +struct list_head link; +/** +* @finish: Driver callback for the finish pass. +* @final: Pointer to the mmu_interval_notifier_finish structure. +* @range: The mmu_notifier_range. +* @cur_seq: The current sequence set by the first pass. +* +* Note that there is no error reporting for additional passes. +*/ +void (*finish)(struct mmu_interval_notifier_finish *final, +const struct mmu_notifier_range *range, +unsigned long cur_seq);
I would rather this be in mmu_interval_notifier_ops, though I guess I see why it was done like this, I don't think it is a great idea for DRM to wrapper the notifier library with yet another library :\
Regardless
Jason
Thomas Hellström
maintainerRe: [PATCH 1/6] mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
Hi, Jason
Quoted 15 lines · Jason Gunthorpe
include/linux/mmu_notifier.h struct mmu_notifier { · line 265
Quoted 13 lines · Thomas Hellström
include/linux/mmu_notifier.h +13
-0+struct mmu_interval_notifier_finish { +struct list_head link; +/** +* @finish: Driver callback for the finish pass. +* @final: Pointer to the mmu_interval_notifier_finish structure. +* @range: The mmu_notifier_range. +* @cur_seq: The current sequence set by the first pass. +* +* Note that there is no error reporting for additional passes. +*/ +void (*finish)(struct mmu_interval_notifier_finish *final, +const struct mmu_notifier_range *range, +unsigned long cur_seq);I would rather this be in
mmu_interval_notifier_ops
Thanks for reviewing.
We could have the struct mmu_interval_notifier_finish have a pointer to mmu_interval_notifier_ops or even tommu_interval_notifier. Now that you mention it IIRC Linus has pointed out that he strongly prefer function pointers in const ops wherever possible. Would like to keep the linked list, though, as we've discussed before, for passing of state and to avoid a second interval tree traversal.
Thanks,
Thomas
Quoted 9 lines
though I guess I
see why it was done like this, I don't think it is a great idea for DRM to wrapper the notifier library with yet another library :\Regardless
Reviewed-by Jason Gunthorpe <[email protected]>Jason