tiff: Security fix for CVE-2024-13978, CVE-2025-8176, CVE-2025-8177
PATCH 1/1 tiff: Security fix for CVE-2024-13978, CVE-2025-8176, CVE-2025-8177
From: Siddharth Doshi <[email protected]>
Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/7be20ccaab97455f192de0ac561ceda7cd9e12d1, https://gitlab.com/libtiff/libtiff/-/commit/2ebfffb0e8836bfb1cd7d85c059cd285c59761a4, https://gitlab.com/libtiff/libtiff/-/commit/3994cf3b3bc6b54c32f240ca5a412cffa11633fa, https://gitlab.com/libtiff/libtiff/-/commit/ce46f002eca4148497363f80fab33f9396bcbeda, https://gitlab.com/libtiff/libtiff/-/commit/ecc4ddbf1f0fed7957d1e20361e37f01907898e0, https://gitlab.com/libtiff/libtiff/-/commit/75d8eca6f106c01aadf76b8500a7d062b12f2d82, https://gitlab.com/libtiff/libtiff/-/commit/e8c9d6c616b19438695fd829e58ae4fde5bfbc22]
CVE's Fixed:
CVE-2024-13978 libtiff: LibTIFF Null Pointer Dereference CVE-2025-8176 libtiff: LibTIFF Use-After-Free Vulnerability CVE-2025-8177 libtiff: LibTIFF Buffer Overflow
--- .../libtiff/tiff/CVE-2024-13978_1.patch | 77 +++++++++++++++++++ .../libtiff/tiff/CVE-2024-13978_2.patch | 45 +++++++++++ .../libtiff/tiff/CVE-2025-8176_1.patch | 61 +++++++++++++++ .../libtiff/tiff/CVE-2025-8176_2.patch | 31 ++++++++ .../libtiff/tiff/CVE-2025-8176_3.patch | 28 +++++++ .../libtiff/tiff/CVE-2025-8177_1.patch | 36 +++++++++ .../libtiff/tiff/CVE-2025-8177_2.patch | 29 +++++++ meta/recipes-multimedia/libtiff/tiff_4.7.0.bb | 10 ++- 8 files changed, 316 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2024-13978_1.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2024-13978_2.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_1.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_2.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_3.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2025-8177_1.patch create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2025-8177_2.patch
meta/recipes-multimedia/libtiff/tiff/CVE-2024-13978_1.patch new file +77 -0
@@ -0,0 +1,77 @@ +From 6dd7006103f9612fbd22e9c7c1b93d16691370a4 Mon Sep 17 00:00:00 2001 +From: Lee Howard <[email protected]> +Date: Fri, 27 Sep 2024 11:21:57 -0700 +Subject: [PATCH 1/7] Fix issue #649 in fax2ps caused by regression in commit + https://gitlab.com/libtiff/libtiff/-/commit/28c38d648b64a66c3218778c4745225fe3e3a06d + where TIFFTAG_FAXFILLFUNC is being used rather than an output buffer. + +CVE: CVE-2024-13978 +Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/7be20ccaab97455f192de0ac561ceda7cd9e12d1] +Signed-off-by: Siddharth Doshi <[email protected]> +--- + libtiff/tif_read.c | 21 ++++++++++++++++----- + 1 file changed, 16 insertions(+), 5 deletions(-) + +diff --git a/libtiff/tif_read.c b/libtiff/tif_read.c +index 7efab59..964f119 100644 +--- a/libtiff/tif_read.c ++++ b/libtiff/tif_read.c +@@ -466,7 +466,9 @@ int TIFFReadScanline(TIFF *tif, void *buf, uint32_t row, uint16_t sample) + } + else + { +- memset(buf, 0, (size_t)tif->tif_scanlinesize); ++ /* See TIFFReadEncodedStrip comment regarding TIFFTAG_FAXFILLFUNC. */ ++ if (buf) ++ memset(buf, 0, (size_t)tif->tif_scanlinesize); + } + return (e > 0 ? 1 : -1); + } +@@ -554,7 +556,10 @@ tmsize_t TIFFReadEncodedStrip(TIFF *tif, uint32_t strip, void *buf, + stripsize = size; + if (!TIFFFillStrip(tif, strip)) + { +- memset(buf, 0, (size_t)stripsize); ++ /* The output buf may be NULL, in particular if TIFFTAG_FAXFILLFUNC ++ is being used. Thus, memset must be conditional on buf not NULL. */ ++ if (buf) ++ memset(buf, 0, (size_t)stripsize); + return ((tmsize_t)(-1)); + } + if ((*tif->tif_decodestrip)(tif, buf, stripsize, plane) <= 0) +@@ -976,7 +981,9 @@ tmsize_t TIFFReadEncodedTile(TIFF *tif, uint32_t tile, void *buf, tmsize_t size) + size = tilesize; + if (!TIFFFillTile(tif, tile)) + { +- memset(buf, 0, (size_t)size); ++ /* See TIFFReadEncodedStrip comment regarding TIFFTAG_FAXFILLFUNC. */ ++ if (buf) ++ memset(buf, 0, (size_t)size); + return ((tmsize_t)(-1)); + } + else if ((*tif->tif_decodetile)(tif, (uint8_t *)buf, size, +@@ -1569,7 +1576,9 @@ int TIFFReadFromUserBuffer(TIFF *tif, uint32_t strile, void *inbuf, + if (!TIFFStartTile(tif, strile)) + { + ret = 0; +- memset(outbuf, 0, (size_t)outsize); ++ /* See related TIFFReadEncodedStrip comment. */ ++ if (outbuf) ++ memset(outbuf, 0, (size_t)outsize); + } + else if (!(*tif->tif_decodetile)( + tif, (uint8_t *)outbuf, outsize, +@@ -1596,7 +1605,9 @@ int TIFFReadFromUserBuffer(TIFF *tif, uint32_t strile, void *inbuf, + if (!TIFFStartStrip(tif, strile)) + { + ret = 0; +- memset(outbuf, 0, (size_t)outsize); ++ /* See related TIFFReadEncodedStrip comment. */ ++ if (outbuf) ++ memset(outbuf, 0, (size_t)outsize); + } + else if (!(*tif->tif_decodestrip)( + tif, (uint8_t *)outbuf, outsize, +-- +2.47.3 +
meta/recipes-multimedia/libtiff/tiff/CVE-2024-13978_2.patch new file +45 -0
45 lines not on this page · raw message
meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_1.patch new file +61 -0
61 lines not on this page · raw message
meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_2.patch new file +31 -0
@@ -0,0 +1,31 @@ +From c090daf37e7f2ad09ec7e9cfabd1c5fde3dee6eb Mon Sep 17 00:00:00 2001 +From: Lee Howard <[email protected]> +Date: Sat, 24 May 2025 21:25:16 -0700 +Subject: [PATCH 4/7] Fix tiffmedian bug #707 + +CVE: CVE-2025-8176 +Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/ce46f002eca4148497363f80fab33f9396bcbeda] +Signed-off-by: Siddharth Doshi <[email protected]> +--- + tools/tiffmedian.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/tools/tiffmedian.c b/tools/tiffmedian.c +index f6cf26c..8c9978b 100644 +--- a/tools/tiffmedian.c ++++ b/tools/tiffmedian.c +@@ -414,7 +414,10 @@ static void get_histogram(TIFF *in, Colorbox *box) + for (i = 0; i < imagelength; i++) + { + if (TIFFReadScanline(in, inputline, i, 0) <= 0) +- break; ++ { ++ fprintf(stderr, "Error reading scanline\n"); ++ exit(EXIT_FAILURE); ++ } + inptr = inputline; + for (j = imagewidth; j-- > 0;) + { +-- +2.47.3 +
meta/recipes-multimedia/libtiff/tiff/CVE-2025-8176_3.patch new file +28 -0
@@ -0,0 +1,28 @@ +From bd645550275963797343e8e91a9a8fee318428e0 Mon Sep 17 00:00:00 2001 +From: Lee Howard <[email protected]> +Date: Sat, 24 May 2025 21:38:09 -0700 +Subject: [PATCH 5/7] conflict resolution + +CVE: CVE-2025-8176 +Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/ecc4ddbf1f0fed7957d1e20361e37f01907898e0] +Signed-off-by: Siddharth Doshi <[email protected]> +--- + tools/tiffmedian.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/tiffmedian.c b/tools/tiffmedian.c +index 8c9978b..47e0524 100644 +--- a/tools/tiffmedian.c ++++ b/tools/tiffmedian.c +@@ -920,7 +920,7 @@ static void quant_fsdither(TIFF *in, TIFF *out) + outline = (unsigned char *)_TIFFmalloc(TIFFScanlineSize(out)); + + GetInputLine(in, 0, goto bad); /* get first line */ +- for (i = 0; i <= imagelength; ++i) ++ for (i = 0; i < imagelength; ++i) + { + SWAP(short *, thisline, nextline); + lastline = (i >= imax); +-- +2.47.3 +
meta/recipes-multimedia/libtiff/tiff/CVE-2025-8177_1.patch new file +36 -0
@@ -0,0 +1,36 @@ +From 01bf5ba7f4a27c5e28ce467a66b13e066556e545 Mon Sep 17 00:00:00 2001 +From: Lee Howard <[email protected]> +Date: Thu, 19 Jun 2025 11:51:33 -0700 +Subject: [PATCH 6/7] Fix for thumbnail issue #715 + +CVE: CVE-2025-8177 +Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/75d8eca6f106c01aadf76b8500a7d062b12f2d82] +Signed-off-by: Siddharth Doshi <[email protected]> +--- + tools/thumbnail.c | 10 +++++++++- + 1 file changed, 9 insertions(+), 1 deletion(-) + +diff --git a/tools/thumbnail.c b/tools/thumbnail.c +index b4cb114..432d172 100644 +--- a/tools/thumbnail.c ++++ b/tools/thumbnail.c +@@ -620,7 +620,15 @@ static void setrow(uint8_t *row, uint32_t nrows, const uint8_t *rows[]) + } + acc += bits[*src & mask1]; + } +- *row++ = cmap[(255 * acc) / area]; ++ if (255 * acc / area < 256) ++ { ++ *row++ = cmap[(255 * acc) / area]; ++ } ++ else ++ { ++ fprintf(stderr, "acc=%d, area=%d\n", acc, area); ++ row++; ++ } + } + } + +-- +2.47.3 +
meta/recipes-multimedia/libtiff/tiff/CVE-2025-8177_2.patch new file +29 -0
@@ -0,0 +1,29 @@ +From c3ad38afb9986b9ddcd7d95367ded152488260cd Mon Sep 17 00:00:00 2001 +From: Lee Howard <[email protected]> +Date: Mon, 23 Jun 2025 10:09:07 -0700 +Subject: [PATCH 7/7] set a default value - assumes cmap[0] was not, itself, + uninitialized + +CVE: CVE-2025-8177 +Upstream-Status: Backport from [https://gitlab.com/libtiff/libtiff/-/commit/e8c9d6c616b19438695fd829e58ae4fde5bfbc22] +Signed-off-by: Siddharth Doshi <[email protected]> +--- + tools/thumbnail.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/thumbnail.c b/tools/thumbnail.c +index 432d172..110ea42 100644 +--- a/tools/thumbnail.c ++++ b/tools/thumbnail.c +@@ -627,7 +627,7 @@ static void setrow(uint8_t *row, uint32_t nrows, const uint8_t *rows[]) + else + { + fprintf(stderr, "acc=%d, area=%d\n", acc, area); +- row++; ++ *row++ = cmap[0]; + } + } + } +-- +2.47.3 +
meta/recipes-multimedia/libtiff/tiff_4.7.0.bb +9 -1
@@ -8,7 +8,15 @@ LIC_FILES_CHKSUM = "file://LICENSE.md;md5=a3e32d664d6db1386b4689c8121531c3" CVE_PRODUCT = "libtiff" -SRC_URI = "http://download.osgeo.org/libtiff/tiff-${PV}.tar.gz" +SRC_URI = "http://download.osgeo.org/libtiff/tiff-${PV}.tar.gz \ + file://CVE-2024-13978_1.patch \ + file://CVE-2024-13978_2.patch \ + file://CVE-2025-8176_1.patch \ + file://CVE-2025-8176_2.patch \ + file://CVE-2025-8176_3.patch \ + file://CVE-2025-8177_1.patch \ + file://CVE-2025-8177_2.patch \ + " SRC_URI[sha256sum] = "67160e3457365ab96c5b3286a0903aa6e78bdc44c4bc737d2e486bcecb6ba976"
Signature · 1 line
2.34.1