Skip to contentSkip to conversation

kselftest: mm: fix typos in test_vmalloc.sh

PATCH In review ally heev 3 participants 4 messages Aug 23, 2025 – Aug 25, 2025

Subsystems (3)
lore
Share & tools
lore

ally heev

author
#0 lore raw

PATCH 1/1 kselftest: mm: fix typos in test_vmalloc.sh

---
 tools/testing/selftests/mm/test_vmalloc.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/test_vmalloc.sh +3 -3
index d73b846736f1..d39096723fca 100755
@@ -47,14 +47,14 @@ check_test_requirements()
 	fi
 }
 
-run_perfformance_check()
+run_performance_check()
 {
 	echo "Run performance tests to evaluate how fast vmalloc allocation is."
 	echo "It runs all test cases on one single CPU with sequential order."
 
 	modprobe $DRIVER $PERF_PARAM > /dev/null 2>&1
 	echo "Done."
-	echo "Ccheck the kernel message buffer to see the summary."
+	echo "Check the kernel message buffer to see the summary."
 }
 
 run_stability_check()
@@ -160,7 +160,7 @@ function run_test()
 		usage
 	else
 		if [[ "$1" = "performance" ]]; then
-			run_perfformance_check
+			run_performance_check
 		elif [[ "$1" = "stress" ]]; then
 			run_stability_check
 		elif [[ "$1" = "smoke" ]]; then
Signature · 1 line
2.34.1
#1 lore raw
Quoted 39 lines · ally heev
---
 tools/testing/selftests/mm/test_vmalloc.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/test_vmalloc.sh +3 -3
index d73b846736f1..d39096723fca 100755
@@ -47,14 +47,14 @@ check_test_requirements()
 	fi
 }
 
-run_perfformance_check()
+run_performance_check()
 {
 	echo "Run performance tests to evaluate how fast vmalloc allocation is."
 	echo "It runs all test cases on one single CPU with sequential order."
 
 	modprobe $DRIVER $PERF_PARAM > /dev/null 2>&1
 	echo "Done."
-	echo "Ccheck the kernel message buffer to see the summary."
+	echo "Check the kernel message buffer to see the summary."
 }
 
 run_stability_check()
@@ -160,7 +160,7 @@ function run_test()
 		usage
 	else
 		if [[ "$1" = "performance" ]]; then
-			run_perfformance_check
+			run_performance_check
 		elif [[ "$1" = "stress" ]]; then
 			run_stability_check
 		elif [[ "$1" = "smoke" ]]; then
Signature · 1 line
2.34.1

./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 24 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Can you add a commit message?

Thank you!

--
Uladzislau Rezki

maintainer
#2 lore raw
Quoted 22 lines · On Sun, 24 Aug 2025 08:53:26 +0200 Uladzislau Rezki <[email protected]> wrote:
Quoted 14 lines

run_stability_check()

tools/testing/selftests/mm/test_vmalloc.sh +1 -1
@@ -160,7 +160,7 @@ function run_test()
 		usage
 	else
 		if [[ "$1" = "performance" ]]; then
-			run_perfformance_check
+			run_performance_check
 		elif [[ "$1" = "stress" ]]; then
 			run_stability_check
 		elif [[ "$1" = "smoke" ]]; then
Signature · 1 line
2.34.1

./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 24 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Quoted 6 lines

./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Can you add a commit message?

A changelog would be identical to the subject. checkpatch is being a bit excessive here.

Oh well, I'll add the obvious text.

author
#3 lore raw
Quoted 2 lines

A changelog would be identical to the subject. checkpatch is being a bit excessive here.

Yes. Hence omitted it

Quoted 36 lines · Andrew Morton
Quoted 22 lines · On Sun, 24 Aug 2025 08:53:26 +0200 Uladzislau Rezki <[email protected]> wrote:
Quoted 11 lines

run_stability_check()

tools/testing/selftests/mm/test_vmalloc.sh +1 -2
@@ -160,7 +160,7 @@ function run_test()
            usage
    else
            if [[ "$1" = "performance" ]]; then
-                   run_perfformance_check
+                   run_performance_check
            elif [[ "$1" = "stress" ]]; then
                    run_stability_check
            elif [[ "$1" = "smoke" ]]; then
--
Quoted 3 lines

2.34.1

./scripts/checkpatch.pl ./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 24 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Quoted 6 lines

./0001-kselftest-mm-fix-typos-in-test_vmalloc.sh.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Can you add a commit message?

A changelog would be identical to the subject. checkpatch is being a bit excessive here.

Oh well, I'll add the obvious text.