Skip to contentSkip to conversation

RDMA/mlx5: Fix page size bitmap calculation for KSM mode

PATCH Applied Edward Srouji 2 participants 2 messages Aug 24, 2025 – Sep 9, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/mlx5: Fix page size bitmap calculation for KSM mode

When using KSM (Key Scatter-gather Memory) access mode, the HW requires the IOVA to be aligned to the selected page size.
Without this alignment, the HW may not function correctly.

Currently, mlx5_umem_mkc_find_best_pgsz() does not filter out page sizes that would result in misaligned IOVAs for KSM mode. This can lead to selecting page sizes that are incompatible with the given IOVA.

Fix this by filtering the page size bitmap when in KSM mode, keeping only page sizes to which the IOVA is aligned to.

Fixes fcfb03597b7d ("RDMA/mlx5: Align mkc page size capability check to PRM")
---
 drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 ++++
 1 file changed, 4 insertions(+)
drivers/infiniband/hw/mlx5/mlx5_ib.h +4 -0
index 4fc2c0ca2af3..fbb9803785ba 100644
@@ -1805,6 +1805,10 @@ mlx5_umem_mkc_find_best_pgsz(struct mlx5_ib_dev *dev, struct ib_umem *umem,
 
 	bitmap = GENMASK_ULL(max_log_entity_size_cap, min_log_entity_size_cap);
 
+	/* In KSM mode HW requires IOVA and mkey's page size to be aligned */
+	if (access_mode == MLX5_MKC_ACCESS_MODE_KSM && iova)
+		bitmap &= GENMASK_ULL(__ffs64(iova), 0);
+
 	return ib_umem_find_best_pgsz(umem, bitmap, iova);
 }
 
Signature · 1 line
2.21.3
#1 lore raw
Quoted 9 lines · Edward Srouji

When using KSM (Key Scatter-gather Memory) access mode, the HW requires the IOVA to be aligned to the selected page size.
Without this alignment, the HW may not function correctly.

Currently, mlx5_umem_mkc_find_best_pgsz() does not filter out page sizes that would result in misaligned IOVAs for KSM mode. This can lead to selecting page sizes that are incompatible with the given IOVA.

[...]

Applied, thanks!

[1/1] RDMA/mlx5: Fix page size bitmap calculation for KSM mode

      https://git.kernel.org/rdma/rdma/c/f4d365433815fd

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>