Skip to contentSkip to conversation

arm: bootm-fip: remove redundant variable declaration

PATCH Applied Alexander Shiyan 2 participants 4 messages Aug 25, 2025 – Sep 12, 2025 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: bootm-fip: remove redundant variable declaration

Remove shadowed variable declaration inside the loop

---
 arch/arm/cpu/bootm-fip.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/cpu/bootm-fip.c +0 -1
index bd176f0645..a50b3f4431 100644
@@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
 		for_each_child_of_node_safe(fconf, tmp, image) {
 			u64 load_addr;
 			u32 id;
-			int ret;
 
 			ret = of_property_read_u32(image, "id", &id);
 			if (ret)
Signature · 1 line
2.38.2
#2 lore raw
In reply to Alexander Shiyan

ping

пн, 25 авг. 2025 г. в 15:12, Alexander Shiyan <[email protected]>:

Quoted 23 lines

Remove shadowed variable declaration inside the loop

---
 arch/arm/cpu/bootm-fip.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/cpu/bootm-fip.c +0 -2
index bd176f0645..a50b3f4431 100644
@@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
                for_each_child_of_node_safe(fconf, tmp, image) {
                        u64 load_addr;
                        u32 id;
-                       int ret;
 
                        ret = of_property_read_u32(image, "id", &id);
                        if (ret)
--

2.38.2

#3 lore raw
Quoted 1 line · Alexander Shiyan

ping

The patch already sits in master as 54e2f6bf92 ("arm: bootm-fip:
remove redundant variable declaration")

Sascha

Quoted 27 lines

пн, 25 авг. 2025 г. в 15:12, Alexander Shiyan <[email protected]>:

Quoted 23 lines

Remove shadowed variable declaration inside the loop

---
 arch/arm/cpu/bootm-fip.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/cpu/bootm-fip.c +0 -2
index bd176f0645..a50b3f4431 100644
@@ -91,7 +91,6 @@ static int parse_dtb_registry(struct fip_image_desc *fw_config_desc,
                for_each_child_of_node_safe(fconf, tmp, image) {
                        u64 load_addr;
                        u32 id;
-                       int ret;
 
                        ret = of_property_read_u32(image, "id", &id);
                        if (ret)
--

2.38.2

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |