spi-nor: add support for XM25QH01D
PATCH 1/1 spi-nor: add support for XM25QH01D
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual and quad read modes, and 4-byte opcodes. Datasheet link: https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
--- drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -603,6 +603,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH512C", 0x204020, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QU512C", 0x204120, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_XTX /* XTX Technology Limited */
Signature · 1 line
2.34.1
Hi all,
Gentle ping — any comments on this patch?
Thanks,
Ssunk
Quoted 16 lines · Ssunk
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual and quad read modes, and 4-byte opcodes. Datasheet link: https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
Signed-off-by Ssunk <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/spi/spi-nor-ids.c +0
-0
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 609
Quoted 7 lines
drivers/mtd/spi/spi-nor-ids.c +1
-0@@ -603,6 +603,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH512C", 0x204020, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QU512C", 0x204120, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_XTX /* XTX Technology Limited */
Keep the list sorted please.
+CC Tom, Tudor.
PATCH v2 1/1 spi-nor: add support for XM25QH01D
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual and quad read modes, and 4-byte opcodes. Datasheet link: https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
Changes in v2:
- Keep the list sorted of XMC
--- drivers/mtd/spi/spi-nor-ids.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/mtd/spi/spi-nor-ids.c +3 -2
@@ -595,13 +595,14 @@ const struct flash_info spi_nor_ids[] = {#endif #ifdef CONFIG_SPI_FLASH_XMC /* XMC (Wuhan Xinxin Semiconductor Manufacturing Corp.) */ + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, - { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH256C", 0x204019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, - { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH512C", 0x204020, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, + { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QU512C", 0x204120, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_XTX
Signature · 1 line
2.34.1
Quoted 23 lines · Ssunk
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual and quad read modes, and 4-byte opcodes. Datasheet link: https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
Changes in v2:
- Keep the list sorted of XMCSigned-off-by Ssunk <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/mtd/spi/spi-nor-ids.c +1
-0@@ -595,13 +595,14 @@ const struct flash_info spi_nor_ids[] = {#endif #ifdef CONFIG_SPI_FLASH_XMC /* XMC (Wuhan Xinxin Semiconductor Manufacturing Corp.) */ + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 606
Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +2
-2{ INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, - { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH256C", 0x204019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, - { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH512C", 0x204020, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, + { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QU512C", 0x204120, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
I'm sorry, my original suggestion was unclear.
If you want to sort the whole XMC part list, then please do 2-patch series, sort the list in patch 1/2 and then add the chip in 2/2 .
Hello Marek,
Quoted 4 lines
I'm sorry, my original suggestion was unclear.
If you want to sort the whole XMC part list, then please do 2-patch series, sort the list in patch 1/2 and then add the chip in 2/2 .
Thanks for the clarification!
Actually, I don’t intend to sort the whole XMC flash list — I only want to add the new XM25QH01D entry. Would it be acceptable if I just place it in the appropriate position without reordering the rest of the list?
Best regards,
Ssunk
Quoted 38 lines · Ssunk
Quoted 23 lines
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual and quad read modes, and 4-byte opcodes. Datasheet link: https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
Changes in v2:
- Keep the list sorted of XMCSigned-off-by Ssunk <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/mtd/spi/spi-nor-ids.c +1
-0@@ -595,13 +595,14 @@ const struct flash_info spi_nor_ids[] = {#endif #ifdef CONFIG_SPI_FLASH_XMC /* XMC (Wuhan Xinxin Semiconductor Manufacturing Corp.) */ + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 606
Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +2
-2{ INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, - { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH256C", 0x204019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, - { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH512C", 0x204020, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { INFO("XM25QU128C", 0x204118, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, + { INFO("XM25QU256C", 0x204119, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QU512C", 0x204120, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },I'm sorry, my original suggestion was unclear.
If you want to sort the whole XMC part list, then please do 2-patch series, sort the list in patch 1/2 and then add the chip in 2/2 .
Quoted 1 line · Ssunk
Hello Marek,
Hi,
Quoted 10 lines
Quoted 4 lines
I'm sorry, my original suggestion was unclear.
If you want to sort the whole XMC part list, then please do 2-patch series, sort the list in patch 1/2 and then add the chip in 2/2 .
Thanks for the clarification!
Actually, I don’t intend to sort the whole XMC flash list — I only want to add the new XM25QH01D entry. Would it be acceptable if I just place it in the appropriate position without reordering the rest of the list?
Sure, this is fine by me. But please also try to get input from the subsystem maintainers.
PATCH v3 1/1 spi-nor: add support for XM25QH01D
Hi Marek,
Thanks for the clarification.
As discussed, I am not reordering the XMC flash list. This v3 only adds the new XM25QH01D entry in the appropriate alphabetical position, without touching the rest of the list.
I welcome feedback from the SPI-NOR subsystem maintainers as well.
Thanks again for the guidance!
Regards,
Ssunk
---
[PATCH v3] spi-nor: add support for XM25QH01D
Add support for the XMC XM25QH01D SPI NOR flash.
This device has 1Gbit (128MB) capacity, with 64KB sectors and supports 4KB erase, dual/quad read, and 4-byte opcodes.
Datasheet:
https://www.xmcwh.com/uploads/958/XM25QH01D_Ver1.0.pdf
Changes in v3:
- Do NOT reorder the XMC flash list (per Marek’s feedback)
- Only add the XM25QH01D entry in the correct sorted position
Changes in v2:
- Attempted to reorder the list; reverted in v3
--- drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -595,6 +595,7 @@ const struct flash_info spi_nor_ids[] = {#endif #ifdef CONFIG_SPI_FLASH_XMC /* XMC (Wuhan Xinxin Semiconductor Manufacturing Corp.) */ + { INFO("XM25QH01D", 0x204021, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
Signature · 1 line
2.34.1
Hi Marek,
Just a gentle ping on this patch below. Please let me know if any further changes are needed.
Thanks,
Ssunk
Quoted 4 lines · Ssunk
Hi Marek,
Just a gentle ping on this patch below. Please let me know if any further changes are needed.
Adjusting the CC list slightly, this is really up to the SPI NOR maintainers.