Skip to contentSkip to conversation

vfio: selftests: Fix .gitignore for already tracked files

PATCH In review David Matlack 2 participants 2 messages Aug 28, 2025 – Aug 29, 2025

Subsystems (4)
lore
Share & tools
lore

David Matlack

author maintainer
#0 lore raw

PATCH 1/1 vfio: selftests: Fix .gitignore for already tracked files

Fix the rules in tools/testing/selftests/vfio/.gitignore to not ignore some already tracked files (.gitignore, Makefile, lib/libvfio.mk).

This change should be a no-op, since these files are already tracked by git and thus git will not ignore updates to them even though they match the ignore rules in the VFIO selftests .gitignore file.

However, they do generate warnings with W=1, as reported by the kernel test robot.

  $ KBUILD_EXTRA_WARN=1 scripts/misc-check
  tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/lib/libvfio.mk: warning: ignored by one of the .gitignore files

Fix this by explicitly un-ignoring the tracked files.

Fixes 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio")

---
Note, this is on top of the vfio/next branch so I'm not sure if the hash in the fixes tag is guaranteed to be stable. It might be simpler to squash this into commit 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio") before sending the pull request to Linus.

 tools/testing/selftests/vfio/.gitignore | 3 +++
 1 file changed, 3 insertions(+)
tools/testing/selftests/vfio/.gitignore +3 -0
index 6d9381d60172..7fadc19d3bca 100644
@@ -5,3 +5,6 @@
 !*.h
 !*.S
 !*.sh
+!*.mk
+!.gitignore
+!Makefile

base-commit: 9f3acb3d9a1872e2fa36af068ca2e93a8a864089

Signature · 1 line
2.51.0.338.gd7d06c2dae-goog
#1 lore raw
Quoted 21 lines · On Thu, 28 Aug 2025 18:58:14 +0000 David Matlack <[email protected]> wrote:

Fix the rules in tools/testing/selftests/vfio/.gitignore to not ignore some already tracked files (.gitignore, Makefile, lib/libvfio.mk).

This change should be a no-op, since these files are already tracked by git and thus git will not ignore updates to them even though they match the ignore rules in the VFIO selftests .gitignore file.

However, they do generate warnings with W=1, as reported by the kernel test robot.

  $ KBUILD_EXTRA_WARN=1 scripts/misc-check
  tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/lib/libvfio.mk: warning: ignored by one of the .gitignore files

Fix this by explicitly un-ignoring the tracked files.

Fixes 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio")
Quoted 8 lines

---
Note, this is on top of the vfio/next branch so I'm not sure if the hash in the fixes tag is guaranteed to be stable. It might be simpler to squash this into commit 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio") before sending the pull request to Linus.

 tools/testing/selftests/vfio/.gitignore | 3 +++
 1 file changed, 3 insertions(+)

Applied to vfio next branch for v6.18. Let's consider the commit hashes sufficiently stable for now. In the off chance that I need to back something out, I can fix them. I think it's useful for the log to have the fixes separate, as evidenced by being able to reference Sean's similar fix. Thanks,

Alex