drm/panthor: always set fence errors on CS_FAULT
Subsystems (3)
PATCH v2 1/1 drm/panthor: always set fence errors on CS_FAULT
It is unclear why fence errors were set only for CS_INHERIT_FAULT. Downstream driver also does not treat CS_INHERIT_FAULT specially. Remove the check.
Signed-off-by Chia-I Wu <[email protected]>
Reviewed-by Boris Brezillon <[email protected]>
---
v2: add rb from Boris
--- drivers/gpu/drm/panthor/panthor_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panthor/panthor_sched.c +1 -1
@@ -1412,7 +1412,7 @@ cs_slot_process_fault_event_locked(struct panthor_device *ptdev, fault = cs_iface->output->fault; info = cs_iface->output->fault_info; -if (queue &&CS_EXCEPTION_TYPE (fault) ==DRM_PANTHOR_EXCEPTION_CS_INHERIT_FAULT ) { +if (queue) {u64 cs_extract = queue->iface.output->extract;struct panthor_job *job;
Signature · 1 line
2.51.0.318.gd7df087d1a-goog
Quoted 6 lines · Chia-I Wu
It is unclear why fence errors were set only for
CS_INHERIT_FAULT. Downstream driver also does not treatCS_INHERIT_FAULTspecially. Remove the check.Signed-off-by Chia-I Wu <[email protected]>Reviewed-by Boris Brezillon <[email protected]>
Reviewed-by Steven Price <[email protected]>
I'll push this to drm-misc-next.
Thanks,
Steve
Quoted 19 lines
---
v2: add rb from Boris--- drivers/gpu/drm/panthor/panthor_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/panthor/panthor_sched.c +1
-1@@ -1412,7 +1412,7 @@ cs_slot_process_fault_event_locked(struct panthor_device *ptdev, fault = cs_iface->output->fault; info = cs_iface->output->fault_info; -if (queue &&CS_EXCEPTION_TYPE (fault) ==DRM_PANTHOR_EXCEPTION_CS_INHERIT_FAULT ) { +if (queue) {u64 cs_extract = queue->iface.output->extract;struct panthor_job *job;