Skip to contentSkip to conversation

drm/panthor: always set fence errors on CS_FAULT

PATCH In review Chia-I Wu 2 participants 2 messages Aug 28, 2025 – Sep 18, 2025

Subsystems (3)
lore
Share & tools
lore

Chia-I Wu

author
#0 lore raw

PATCH v2 1/1 drm/panthor: always set fence errors on CS_FAULT

It is unclear why fence errors were set only for CS_INHERIT_FAULT. Downstream driver also does not treat CS_INHERIT_FAULT specially. Remove the check.

---
v2: add rb from Boris

---
 drivers/gpu/drm/panthor/panthor_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panthor/panthor_sched.c +1 -1
index ba5dc3e443d9c..231f42c67f175 100644
@@ -1412,7 +1412,7 @@ cs_slot_process_fault_event_locked(struct panthor_device *ptdev,
 	fault = cs_iface->output->fault;
 	info = cs_iface->output->fault_info;
 
-	if (queue && CS_EXCEPTION_TYPE(fault) == DRM_PANTHOR_EXCEPTION_CS_INHERIT_FAULT) {
+	if (queue) {
 		u64 cs_extract = queue->iface.output->extract;
 		struct panthor_job *job;
 
Signature · 1 line
2.51.0.318.gd7df087d1a-goog
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Chia-I Wu

It is unclear why fence errors were set only for CS_INHERIT_FAULT. Downstream driver also does not treat CS_INHERIT_FAULT specially. Remove the check.

I'll push this to drm-misc-next.

Thanks,
Steve

Quoted 19 lines

---
v2: add rb from Boris

---
 drivers/gpu/drm/panthor/panthor_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panthor/panthor_sched.c +1 -1
index ba5dc3e443d9c..231f42c67f175 100644
@@ -1412,7 +1412,7 @@ cs_slot_process_fault_event_locked(struct panthor_device *ptdev,
 	fault = cs_iface->output->fault;
 	info = cs_iface->output->fault_info;
 
-	if (queue && CS_EXCEPTION_TYPE(fault) == DRM_PANTHOR_EXCEPTION_CS_INHERIT_FAULT) {
+	if (queue) {
 		u64 cs_extract = queue->iface.output->extract;
 		struct panthor_job *job;