tools/mm/slabinfo: fix access to null terminator in string boundary
Subsystems (2)
PATCH v4 1/1 tools/mm/slabinfo: fix access to null terminator in string boundary
The current code incorrectly accesses buffer[strlen(buffer)], which points to the null terminator ('\0') at the end of the string. This is technically out-of-bounds access since valid string content ends at index strlen(buffer)-1.
Fix by:
1. Declaring strlen() result variable at function scope
2. Adding bounds check (len > 0) to handle empty strings
3. Using buffer[len-1] to correctly access the last character before the null terminator
---
Changes in v2:
- Move variable declaration to function scope to avoid mixing declarations with statements (feedback from reviewer)
Changes in v3:
- Move changelog to comment section (feedback from reviewer)
- Remove unnecessary blank lines
Changes in v4:
- Remove changelog from comment section
--- tools/mm/slabinfo.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/mm/slabinfo.c +5 -2
@@ -155,6 +155,7 @@ static void usage(void)static unsigned long read_obj (const char *name) { +size_t len;FILE *f =fopen (name,"r" );if (!f) {
@@ -165,8 +166,10 @@ static unsigned long read_obj(const char *name)if (!fgets (buffer,sizeof (buffer), f)) buffer[0 ] =0 ;fclose (f); -if (buffer[strlen (buffer)] =='\n' ) - buffer[strlen (buffer)] =0 ; + len =strlen (buffer); + +if (len >0 && buffer[len -1 ] =='\n' ) + buffer[len -1 ] =0 ; }return strlen (buffer); }
Signature · 1 line
2.34.1
Quoted 5 lines · On Mon, 1 Sep 2025 10:19:55 +0530 Kaushlendra Kumar…
The current code incorrectly accesses buffer[strlen(buffer)], which points to the null terminator ('\0') at the end of the string. This is technically out-of-bounds access since valid string content ends at index strlen(buffer)-1.
Quoted 7 lines
Fix by:
1. Declaringstrlen()result variable at function scope
2. Adding bounds check (len > 0) to handle empty strings
3. Using buffer[len-1] to correctly access the last character before the null terminatorSigned-off-by Kaushlendra Kumar <[email protected]>
Thanks,
SJ
[...]