drm/amd/amdgpu: Fix a less than zero check on a uint32_t struct field
Subsystems (3)
PATCH 1/1 drm/amd/amdgpu: Fix a less than zero check on a uint32_t struct field
Currently the error check from the call to mes_v12_inv_tlb_convert_hub_id is always false because a uint32_t struct field hub_id is being used to to perform the less than zero error check. Fix this by using the int variable ret to perform the check.
--- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/mes_v12_0.c +4 -2
@@ -899,6 +899,7 @@ static int mes_v12_0_inv_tlbs_pasid(struct amdgpu_mes *mes, struct mes_inv_tlbs_pasid_input *input) {union MESAPI__INV_TLBS mes_inv_tlbs; +int ret;memset (&mes_inv_tlbs,0 ,sizeof (mes_inv_tlbs));
@@ -911,9 +912,10 @@ static int mes_v12_0_inv_tlbs_pasid(struct amdgpu_mes *mes, mes_inv_tlbs.invalidate_tlbs.inv_sel_id = input->pasid;/*convert amdgpu_mes_hub_id to mes expected hub_id */ - mes_inv_tlbs.invalidate_tlbs.hub_id =mes_v12_inv_tlb_convert_hub_id (input->hub_id); -if (mes_inv_tlbs.invalidate_tlbs.hub_id <0 ) + ret =mes_v12_inv_tlb_convert_hub_id (input->hub_id); +if (ret <0 )return -EINVAL ; + mes_inv_tlbs.invalidate_tlbs.hub_id = ret;return mes_v12_0_submit_pkt_and_poll_completion (mes,AMDGPU_MES_KIQ_PIPE , &mes_inv_tlbs,sizeof (mes_inv_tlbs), offsetof(union MESAPI__INV_TLBS , api_status));
Signature · 1 line
2.51.0
Are you editing your CC list? The get_maintainer.pl script gives me a longer list. The most important thing is that you've left off Shaoyun Liu from the Fixes tag. Added.
The kbuild-bot did report this bug on Friday so the AMD folks likely have a patch kicking around on their end, but just haven't sent it out publicly yet?
https://lore.kernel.org/all/[email protected]/
Anyway, the patch is fine.
regards,
dan carpenter
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 16 lines · Dan Carpenter
Are you editing your CC list? The get_maintainer.pl script gives me a longer list. The most important thing is that you've left off Shaoyun Liu from the Fixes tag. Added.
The kbuild-bot did report this bug on Friday so the AMD folks likely have a patch kicking around on their end, but just haven't sent it out publicly yet?
https://lore.kernel.org/all/[email protected]/Anyway, the patch is fine.
Reviewed-by Dan Carpenter <[email protected]>regards,
dan carpenter