Skip to contentSkip to conversation

mapple_tree: Fix build error (`make W=1`)

PATCH In review Andy Shevchenko 3 participants 6 messages Sep 4, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mapple_tree: Fix build error (`make W=1`)

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
---
 lib/maple_tree.c | 5 -----
 1 file changed, 5 deletions(-)
lib/maple_tree.c +0 -5
index fce329d6c1b2..ca8b3c2e0362 100644
@@ -176,11 +176,6 @@ static inline struct maple_node *mt_alloc_one(gfp_t gfp)
 	return kmem_cache_alloc(maple_node_cache, gfp);
 }
 
-static inline int mt_alloc_bulk(gfp_t gfp, size_t size, void **nodes)
-{
-	return kmem_cache_alloc_bulk(maple_node_cache, gfp, size, nodes);
-}
-
 static inline void mt_free_bulk(size_t size, void __rcu **nodes)
 {
 	kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes);
Signature · 1 line
2.50.1
#1 lore raw
Quoted 8 lines · Andy Shevchenko

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")

Thanks. This should be squashed into the patch listed in the fixes tag since it's not a stable commit yet.

Quoted 23 lines
---
 lib/maple_tree.c | 5 -----
 1 file changed, 5 deletions(-)
lib/maple_tree.c +0 -5
index fce329d6c1b2..ca8b3c2e0362 100644
@@ -176,11 +176,6 @@ static inline struct maple_node *mt_alloc_one(gfp_t gfp)
 	return kmem_cache_alloc(maple_node_cache, gfp);
 }
 
-static inline int mt_alloc_bulk(gfp_t gfp, size_t size, void **nodes)
-{
-	return kmem_cache_alloc_bulk(maple_node_cache, gfp, size, nodes);
-}
-
 static inline void mt_free_bulk(size_t size, void __rcu **nodes)
 {
 	kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes);
Signature · 1 line
2.50.1
#2 lore raw
Quoted 5 lines · Liam R. Howlett
Quoted 4 lines · Andy Shevchenko

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Quoted 7 lines
Quoted 4 lines

Fix this by removing unused code.

Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")

Thanks. This should be squashed into the patch listed in the fixes tag since it's not a stable commit yet.

I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Liam R. Howlett
Quoted 6 lines · Andy Shevchenko

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")

Thanks. This should be squashed into the patch listed in the fixes tag since it's not a stable commit yet.

I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

Sounds good. I've added Vlastimil to the email as it went through his branch.

Can you please Cc the SoB people next time?

Thanks,
Liam

#4 lore raw
Quoted 15 lines · Liam R. Howlett
Quoted 14 lines · Andy Shevchenko
Quoted 12 lines · Liam R. Howlett
Quoted 8 lines · Andy Shevchenko

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")

Thanks. This should be squashed into the patch listed in the fixes tag since it's not a stable commit yet.

Quoted 6 lines
Quoted 1 line

I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

Sounds good. I've added Vlastimil to the email as it went through his branch.

Can you please Cc the SoB people next time?

I will try to remember. I used get_maintainers.pl. If it's not enough, can we got this documented somehow? Or if it's already documented, can you point out to it?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
In reply to Liam R. Howlett
Quoted 12 lines · Liam R. Howlett
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Liam R. Howlett
Quoted 8 lines · Andy Shevchenko

clang complains about unused function:

lib/maple_tree.c:179:19: error: unused function 'mt_alloc_bulk' [-Werror,-Wunused-function]

Fix this by removing unused code.

Fixes a48d52b2d21b ("maple_tree: Convert forking to use the sheaf interface")
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Thanks. This should be squashed into the patch listed in the fixes tag since it's not a stable commit yet.

I fine with any solution, I just want this to be fixes rather sooner. So, please go ahead!

Sounds good. I've added Vlastimil to the email as it went through his branch.

Squashing into the tomorrow's linux-next release, thanks.

Quoted 4 lines

Can you please Cc the SoB people next time?

Thanks,
Liam