Skip to contentSkip to conversation

SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

PATCH In review Eric Biggers 3 participants 3 messages Sep 6, 2025 – Sep 8, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it. This unblocks the eventual removal of the selection of CRYPTO from NFSD_V4, which will no longer be needed by nfsd itself due to switching to the crypto library functions. But NFSD_V4 selects RPCSEC_GSS_KRB5, which still needs CRYPTO. It makes more sense for RPCSEC_GSS_KRB5 to select CRYPTO itself, like most other kconfig options that need CRYPTO do.

---
 net/sunrpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/sunrpc/Kconfig +2 -1
index 2d8b67dac7b5b..33aafdc8392e3 100644
@@ -16,13 +16,14 @@ config SUNRPC_SWAP
 	bool
 	depends on SUNRPC
 
 config RPCSEC_GSS_KRB5
 	tristate "Secure RPC: Kerberos V mechanism"
-	depends on SUNRPC && CRYPTO
+	depends on SUNRPC
 	default y
 	select SUNRPC_GSS
+	select CRYPTO
 	select CRYPTO_SKCIPHER
 	select CRYPTO_HASH
 	help
 	  Choose Y here to enable Secure RPC using the Kerberos version 5
 	  GSS-API mechanism (RFC 1964).

base-commit: 4a0de50a44bb11ea67bb3ca961844b55ac57cf05

Signature · 1 line
2.50.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines · Eric Biggers

Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it. This unblocks the eventual removal of the selection of CRYPTO from NFSD_V4, which will no longer be needed by nfsd itself due to switching to the crypto library functions. But NFSD_V4 selects RPCSEC_GSS_KRB5, which still needs CRYPTO. It makes more sense for RPCSEC_GSS_KRB5 to select CRYPTO itself, like most other kconfig options that need CRYPTO do.

---
 net/sunrpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/sunrpc/Kconfig +2 -1
index 2d8b67dac7b5b..33aafdc8392e3 100644
@@ -16,13 +16,14 @@ config SUNRPC_SWAP
 	bool
 	depends on SUNRPC
 
 config RPCSEC_GSS_KRB5
 	tristate "Secure RPC: Kerberos V mechanism"
-	depends on SUNRPC && CRYPTO
+	depends on SUNRPC
 	default y
 	select SUNRPC_GSS
+	select CRYPTO
 	select CRYPTO_SKCIPHER
 	select CRYPTO_HASH
 	help
 	  Choose Y here to enable Secure RPC using the Kerberos version 5
 	  GSS-API mechanism (RFC 1964).
Quoted 1 line

base-commit: 4a0de50a44bb11ea67bb3ca961844b55ac57cf05

maintainer
#2 lore raw
In reply to Eric Biggers

From: Chuck Lever <[email protected]>

Quoted 8 lines · Eric Biggers

Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it. This unblocks the eventual removal of the selection of CRYPTO from NFSD_V4, which will no longer be needed by nfsd itself due to switching to the crypto library functions. But NFSD_V4 selects RPCSEC_GSS_KRB5, which still needs CRYPTO. It makes more sense for RPCSEC_GSS_KRB5 to select CRYPTO itself, like most other kconfig options that need CRYPTO do.

[...]

Applied to nfsd-testing, thanks!

[1/1] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

      commit: b3560ad8e52b87cdbd858ec279429276695c1e48

--
Chuck Lever