mm/damon/core: reset age if nr_accesses changes between non-zero and zero
Subsystems (2)
SeongJae Park
maintainerRFC PATCH 1/1 mm/damon/core: reset age if nr_accesses changes between non-zero and zero
DAMON resets the age of a region if its nr_accesses value has significantly changed. Specifically, the threshold is calculated as 20% of largest nr_accesses of the current snapshot. This means that regions changing the nr_accesses from zero to small non-zero value or from a small non-zero value to zero will keep the age. Since many users treat zero nr_accesses regions special, this can be confusing. Kernel code including DAMOS' regions priority calculation and DAMON_STAT's idle time calculation also treat zero nr_accesses regions special. Make it unconfusing by resetting the age when the nr_accesses changes between zero and a non-zero value.
--- mm/damon/core.c | 3 +++ 1 file changed, 3 insertions(+)
mm/damon/core.c +3 -0
@@ -2261,6 +2261,9 @@ static void damon_merge_regions_of(struct damon_target *t, unsigned int thres,damon_for_each_region_safe (r, next, t) {if (abs (r->nr_accesses - r->last_nr_accesses) > thres) r->age =0 ; +else if ((!r->nr_accesses && r->last_nr_accesses) || + (r->nr_accesses && !r->last_nr_accesses)) + r->age =0 ;else r->age++;
base-commit: 580b0ae8069448252cfea72b75ba5b0857c128e0
Signature · 1 line
2.39.5