Skip to contentSkip to conversation

clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment

PATCH Applied Johan Hovold 3 participants 3 messages Sep 10, 2025 – Sep 12, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment

Drop an obsolete comment about keeping the PCIe GDSCs always-on, something which is no longer the case since commit db382dd55bcb ("clk:
qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").

---
 drivers/clk/qcom/gcc-sc8280xp.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/clk/qcom/gcc-sc8280xp.c +0 -4
index f27d0003f427..b683795475e3 100644
@@ -6775,10 +6775,6 @@ static struct gdsc pcie_1_tunnel_gdsc = {
 	.flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
-/*
- * The Qualcomm PCIe driver does not yet implement suspend so to keep the
- * PCIe power domains always-on for now.
- */
 static struct gdsc pcie_2a_gdsc = {
 	.gdscr = 0x9d004,
 	.collapse_ctrl = 0x52128,
Signature · 1 line
2.49.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Johan Hovold

Drop an obsolete comment about keeping the PCIe GDSCs always-on, something which is no longer the case since commit db382dd55bcb ("clk:
qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").

---

They're not quite off yet, but they're not perma-on either, so I suppose it makes sense:

Konrad

maintainer Applied
#2 lore raw
In reply to Johan Hovold
Quoted 5 lines · Johan Hovold

Drop an obsolete comment about keeping the PCIe GDSCs always-on, something which is no longer the case since commit db382dd55bcb ("clk:
qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").

Applied, thanks!

[1/1] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment

      commit: 4ca6a89f38718d6cd84304e6a26e7ddc90e03356

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>