PCI: tegra194: Fix duplicate pll disable
PATCH 1/1 PCI: tegra194: Fix duplicate pll disable
From: Nagarjuna Kristam <[email protected]>
During PERST# assertion tegra_pcie_bpmp_set_pll_state() is currently called twice.
pex_ep_event_pex_rst_assert() should do the opposite of pex_ep_event_pex_rst_deassert(), so it is obvious that the duplicate tegra_pcie_bpmp_set_pll_state() is a mistake, and that the duplicate tegra_pcie_bpmp_set_pll_state() call should instead be a call to tegra_pcie_bpmp_set_ctrl_state().
With this, the uninitialization sequence also matches that of tegra_pcie_unconfig_controller().
--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/pcie-tegra194.c +2 -2
@@ -1722,9 +1722,9 @@ static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie) ret); } - ret =tegra_pcie_bpmp_set_pll_state (pcie, false); + ret =tegra_pcie_bpmp_set_ctrl_state (pcie, false);if (ret) -dev_err (pcie->dev,"Failed to turn off UPHY: %d\n" , ret); +dev_err (pcie->dev,"Failed to disable controller: %d\n" , ret); pcie->ep_state =EP_STATE_DISABLED ;dev_dbg (pcie->dev,"Uninitialization of endpoint is completed\n" );
Signature · 1 line
2.51.0
Quoted 10 lines · Niklas Cassel
During PERST# assertion
tegra_pcie_bpmp_set_pll_state()is currently called twice.
pex_ep_event_pex_rst_assert()should do the opposite ofpex_ep_event_pex_rst_deassert(), so it is obvious that the duplicatetegra_pcie_bpmp_set_pll_state()is a mistake, and that the duplicatetegra_pcie_bpmp_set_pll_state()call should instead be a call totegra_pcie_bpmp_set_ctrl_state().[...]
Applied, thanks!
[1/1] PCI: tegra194: Fix duplicate pll disable
commit: 3fab9e8102f7f7c5099d69f8e00f478e8795f528
Note: I've added the Fixes tag a54e19073718, which added the duplicate tegra_pcie_bpmp_set_pll_state() call.
Best regards,
Signature · 1 line
Manivannan Sadhasivam <[email protected]>
Quoted 13 lines · Manivannan Sadhasivam
Quoted 10 lines · Niklas Cassel
During PERST# assertion
tegra_pcie_bpmp_set_pll_state()is currently called twice.
pex_ep_event_pex_rst_assert()should do the opposite ofpex_ep_event_pex_rst_deassert(), so it is obvious that the duplicatetegra_pcie_bpmp_set_pll_state()is a mistake, and that the duplicatetegra_pcie_bpmp_set_pll_state()call should instead be a call totegra_pcie_bpmp_set_ctrl_state().[...]
Quoted 7 lines
Applied, thanks!
[1/1] PCI: tegra194: Fix duplicate pll disable
commit: 3fab9e8102f7f7c5099d69f8e00f478e8795f528Note: I've added the Fixes tag
a54e19073718, which added the duplicatetegra_pcie_bpmp_set_pll_state()call.
Thank you Mani,
However, I don't see 3fab9e8102f7f7c5099d69f8e00f478e8795f528 on any branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/
Did you perhaps forget to push?
Kind regards,
Niklas
Manivannan Sadhasivam
maintainerQuoted 22 lines · Niklas Cassel
Quoted 13 lines · Manivannan Sadhasivam
Quoted 10 lines · Niklas Cassel
During PERST# assertion
tegra_pcie_bpmp_set_pll_state()is currently called twice.
pex_ep_event_pex_rst_assert()should do the opposite ofpex_ep_event_pex_rst_deassert(), so it is obvious that the duplicatetegra_pcie_bpmp_set_pll_state()is a mistake, and that the duplicatetegra_pcie_bpmp_set_pll_state()call should instead be a call totegra_pcie_bpmp_set_ctrl_state().[...]
Quoted 7 lines
Applied, thanks!
[1/1] PCI: tegra194: Fix duplicate pll disable
commit: 3fab9e8102f7f7c5099d69f8e00f478e8795f528Note: I've added the Fixes tag
a54e19073718, which added the duplicatetegra_pcie_bpmp_set_pll_state()call.
Quoted 7 lines
Thank you Mani,
However, I don't see
3fab9e8102f7f7c5099d69f8e00f478e8795f528on any branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/Did you perhaps forget to push?
Sorry, yes. Pushed now!
- Mani
Signature · 1 line
மணிவண்ணன் சதாசிவம்