Skip to contentSkip to conversation

arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible.

PATCH In review Tamura Dai 3 participants 6 messages Sep 12, 2025

Subsystems (4)
lore
Share & tools
lore

Tamura Dai

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible.

ref. edt-ft5x06.yaml

---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +1 -1
index 2cf7b5e1243c..a0b288d6162f 100644
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Tamura Dai

ref. edt-ft5x06.yaml

1. Please explain here what is the bug.

2. Subject: drop full stop, this is not a sentence.

3. Missing Fixes tag and cc-stable.

Quoted 2 lines

---

Best regards,
Krzysztof

author
#2 lore raw

PATCH 1/1 arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

Merge a hibernation regression fix and an fix related to energy model

The bug is a typo in the compatible string for the touchscreen node. According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml, the correct compatible is "focaltech,ft8719", but the device tree used "focaltech,fts8719".

Fixes 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +1 -1
index 2cf7b5e1243c..a0b288d6162f 100644
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
Signature · 1 line
2.34.1
author
#3 lore raw

PATCH v2 1/1 arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

In reply to Krzysztof Kozlowski

The bug is a typo in the compatible string for the touchscreen node. According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml, the correct compatible is "focaltech,ft8719", but the device tree used "focaltech,fts8719".

Fixes 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +1 -1
index 2cf7b5e1243c..a0b288d6162f 100644
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
Signature · 1 line
2.34.1
#4 lore raw

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

Hi Tamura,

Quoted 4 lines · Tamura Dai

The bug is a typo in the compatible string for the touchscreen node. According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml, the correct compatible is "focaltech,ft8719", but the device tree used "focaltech,fts8719".

+Joel

I don't think this patch is really correct, in the sdm845-mainline fork there's a different commit which has some more changes to make the touchscreen work:

https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70

Regards
Luca

Quoted 21 lines
Fixes 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +1 -1
index 2cf7b5e1243c..a0b288d6162f 100644
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
Reviewed-by on v2 1/1
#5 lore raw

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

In reply to Tamura Dai
Quoted 6 lines · Tamura Dai

The bug is a typo in the compatible string for the touchscreen node. According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml, the correct compatible is "focaltech,ft8719", but the device tree used "focaltech,fts8719".

Fixes 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)

Missing quotes.
[alias]

	sf = show --pretty='Fixes: %h (\"%s\")'

and then just git sf commit

Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.

Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

Quoted 2 lines

With quotes fixed:

Best regards,
Krzysztof