kasan: Fix warnings caused by use of arch_enter_lazy_mmu_mode()
Subsystems (3)
PATCH 1/1 kasan: Fix warnings caused by use of arch_enter_lazy_mmu_mode()
commit c519c3c0a113 ("mm/kasan: avoid lazy MMU mode hazards") introduced the use of arch_enter_lazy_mmu_mode(), which results in the compiler complaining about "statement has no effect", when __HAVE_ARCH_LAZY_MMU_MODE is not defined in include/linux/pgtable.h
The exact warning/error is:
In file included from ./include/linux/kasan.h:37,
from mm/kasan/shadow.c:14:
mm/kasan/shadow.c: In function ‘kasan_populate_vmalloc_pte’:
./include/linux/pgtable.h:247:41: error: statement with no effect [-Werror=unused-value]
247 | #define arch_enter_lazy_mmu_mode() (LAZY_MMU_DEFAULT)
| ^
mm/kasan/shadow.c:322:9: note: in expansion of macro ‘arch_enter_lazy_mmu_mode’
322 | arch_enter_lazy_mmu_mode();
| ^~~~~~~~~~~~~~~~~~~~~~~~Fix the issue by explicitly casting the use of the function to void, since the returned state is not forwarded/retained
--- mm/kasan/shadow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/kasan/shadow.c +2 -2
@@ -319,7 +319,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, }spin_unlock (&init_mm.page_table_lock); -arch_enter_lazy_mmu_mode (); + (void )arch_enter_lazy_mmu_mode ();return 0 ; }
@@ -494,7 +494,7 @@ static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr,if (likely (!none))__free_page (pfn_to_page (pte_pfn (pte))); -arch_enter_lazy_mmu_mode (); + (void )arch_enter_lazy_mmu_mode ();return 0 ; }
Signature · 1 line
2.50.1
Andrew Morton
maintainerQuoted 34 lines · On Sat, 13 Sep 2025 09:55:15 +1000 Balbir Singh <[email protected]> wrote:
commit
c519c3c0a113("mm/kasan: avoid lazy MMU mode hazards") introduced the use ofarch_enter_lazy_mmu_mode(), which results in the compiler complaining about "statement has no effect", when__HAVE_ARCH_LAZY_MMU_MODEis not defined ininclude/linux/pgtable.hThe exact warning/error is:
In file included from
./include/linux/kasan.h:37,from mm/kasan/shadow.c:14: mm/kasan/shadow.c: In function ‘kasan_populate_vmalloc_pte’: ./include/linux/pgtable.h:247:41: error: statement with no effect [-Werror=unused-value] 247 | #define arch_enter_lazy_mmu_mode() (LAZY_MMU_DEFAULT) | ^ mm/kasan/shadow.c:322:9: note: in expansion of macro ‘arch_enter_lazy_mmu_mode’ 322 | arch_enter_lazy_mmu_mode(); | ^~~~~~~~~~~~~~~~~~~~~~~~Fix the issue by explicitly casting the use of the function to void, since the returned state is not forwarded/retained
...
mm/kasan/shadow.c +1
-1@@ -319,7 +319,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, }spin_unlock (&init_mm.page_table_lock); -arch_enter_lazy_mmu_mode (); + (void )arch_enter_lazy_mmu_mode ();return 0 ; }
mm/kasan/shadow.c static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr, · line 499
Quoted 7 lines
mm/kasan/shadow.c +1
-1@@ -494,7 +494,7 @@ static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr,if (likely (!none))__free_page (pfn_to_page (pte_pfn (pte))); -arch_enter_lazy_mmu_mode (); + (void )arch_enter_lazy_mmu_mode ();return 0 ;
doh, I just figured out that my fix for your fix simply reverted your fix!
I'll promote my cleanup into a hotfix:
From: Andrew Morton <[email protected]>
Subject: include/linux/pgtable.h: convert arch_enter_lazy_mmu_mode() and friends to static inlines
Date: Sat Sep 13 05:03:39 PM PDT 2025
commit c519c3c0a113 ("mm/kasan: avoid lazy MMU mode hazards") introduced the use of arch_enter_lazy_mmu_mode(), which results in the compiler complaining about "statement has no effect", when __HAVE_ARCH_LAZY_MMU_MODE is not defined in include/linux/pgtable.h
The exact warning/error is:
In file included from ./include/linux/kasan.h:37,
from mm/kasan/shadow.c:14:
mm/kasan/shadow.c: In function kasan_populate_vmalloc_pte:
./include/linux/pgtable.h:247:41: error: statement with no effect [-Werror=unused-value]
247 | #define arch_enter_lazy_mmu_mode() (LAZY_MMU_DEFAULT)
| ^
mm/kasan/shadow.c:322:9: note: in expansion of macro arch_enter_lazy_mmu_mode> 322 | arch_enter_lazy_mmu_mode();
| ^~~~~~~~~~~~~~~~~~~~~~~~switching these "functions" to static inlines fixes this up.
---
include/linux/pgtable.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/linux/pgtable.h renamed from include/linux/pgtable.h~include-linux-pgtableh-convert-arch_enter_lazy_mmu_mode-and-friends-to-static-inlines +3 -3
@@ -232,9 +232,9 @@ static inline int pmd_dirty(pmd_t pmd)* and the mode cannot be used in interrupt context. */ #ifndef __HAVE_ARCH_ENTER_LAZY_MMU_MODE -#define arch_enter_lazy_mmu_mode () do {} while (0) -#define arch_leave_lazy_mmu_mode () do {} while (0) -#define arch_flush_lazy_mmu_mode () do {} while (0) +static inline void arch_enter_lazy_mmu_mode (void ) {} +static inline void arch_leave_lazy_mmu_mode (void ) {} +static inline void arch_flush_lazy_mmu_mode (void ) {}#endif #ifndef pte_batch_hint
_