mm-damon-sysfs-use-dynamically-allocated-repeat-mode-damon_call_control.patch removed from -mm tree
The quilt patch titled
Subject: mm/damon/sysfs: use dynamically allocated repeat mode damon_call_control
has been removed from the -mm tree. Its filename was
mm-damon-sysfs-use-dynamically-allocated-repeat-mode-damon_call_control.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/sysfs: use dynamically allocated repeat mode damon_call_control
Date: Mon, 8 Sep 2025 13:15:13 -0700
DAMON sysfs interface is using a single global repeat mode damon_call_control variable for refresh_ms handling, for all DAMON contexts. As a result, when there are more than one context, the single global damon_call_control is unexpectedly over-written (corrupted). Particularly the ->link field is overwritten by the multiple contexts and this can cause a user hangup, and/or a kernel crash. Fix it by using dynamically allocated damon_call_control object per DAMON context.
---
mm/damon/sysfs.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-)
mm/damon/sysfs.c renamed from mm/damon/sysfs.c~mm-damon-sysfs-use-dynamically-allocated-repeat-mode-damon_call_control +15 -8
@@ -1534,14 +1534,10 @@ static int damon_sysfs_repeat_call_fn(voreturn 0 ; } -static struct damon_call_control damon_sysfs_repeat_call_control = { - .fn = damon_sysfs_repeat_call_fn, - .repeat = true, -}; -static int damon_sysfs_turn_damon_on (struct damon_sysfs_kdamond *kdamond) {struct damon_ctx *ctx; +struct damon_call_control *repeat_call_control;int err;if (damon_sysfs_kdamond_running (kdamond))
@@ -1554,18 +1550,29 @@ static int damon_sysfs_turn_damon_on(strdamon_destroy_ctx (kdamond->damon_ctx); kdamond->damon_ctx =NULL ; + repeat_call_control =kmalloc (sizeof (*repeat_call_control), +GFP_KERNEL ); +if (!repeat_call_control) +return -ENOMEM ; + ctx =damon_sysfs_build_ctx (kdamond->contexts->contexts_arr[0 ]); -if (IS_ERR (ctx)) +if (IS_ERR (ctx)) { +kfree (repeat_call_control);return PTR_ERR (ctx); + } err =damon_start (&ctx,1 , false);if (err) { +kfree (repeat_call_control);damon_destroy_ctx (ctx);return err; } kdamond->damon_ctx = ctx; - damon_sysfs_repeat_call_control.data = kdamond; -damon_call (ctx, &damon_sysfs_repeat_call_control); + repeat_call_control->fn = damon_sysfs_repeat_call_fn; + repeat_call_control->data = kdamond; + repeat_call_control->repeat = true; + repeat_call_control->dealloc_on_cancel = true; +damon_call (ctx, repeat_call_control);return err; }
_
Patches currently in -mm which might be from [email protected] are
mm-zswap-store-page_size-compression-failed-page-as-is.patch mm-zswap-store-page_size-compression-failed-page-as-is-fix.patch mm-zswap-store-page_size-compression-failed-page-as-is-v5.patch mm-zswap-store-page_size-compression-failed-page-as-is-fix-2.patch mm-damon-core-add-damon_ctx-addr_unit.patch mm-damon-paddr-support-addr_unit-for-access-monitoring.patch mm-damon-paddr-support-addr_unit-for-damos_pageout.patch mm-damon-paddr-support-addr_unit-for-damos_lru_prio.patch mm-damon-paddr-support-addr_unit-for-migrate_hotcold.patch mm-damon-paddr-support-addr_unit-for-damos_stat.patch mm-damon-sysfs-implement-addr_unit-file-under-context-dir.patch docs-mm-damon-design-document-address-unit-parameter.patch docs-admin-guide-mm-damon-usage-document-addr_unit-file.patch docs-abi-damon-document-addr_unit-file.patch