Skip to contentSkip to conversation

platform/x86: asus-wmi: Re-add extra keys to ignore_key_wlan quirk

PATCH In review Antheas Kapenekakis 2 participants 2 messages Sep 16, 2025

Subsystems (2)
x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Antheas Kapenekakis

author
#0 lore raw

PATCH 1/1 platform/x86: asus-wmi: Re-add extra keys to ignore_key_wlan quirk

It turns out that the dual screen models use 0x5E for attaching and detaching the keyboard instead of 0x5F. So, re-add the codes by reverting commit cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk"). For our future reference, add a comment next to 0x5E indicating that it is used for that purpose.

Fixes cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk")
Reported-by Rahul Chandra <[email protected]>
Closes https://lore.kernel.org/all/10020-68c90c80-d-4ac6c580@106290038/ open here
Cc [email protected]
Signed-off-by Antheas Kapenekakis <[email protected]>
---
 drivers/platform/x86/asus-nb-wmi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +2 -0
index 3a488cf9ca06..6a62bc5b02fd 100644
@@ -673,6 +673,8 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
 		if (atkbd_reports_vol_keys)
 			*code = ASUS_WMI_KEY_IGNORE;
 		break;
+	case 0x5D: /* Wireless console Toggle */
+	case 0x5E: /* Wireless console Enable / Keyboard Attach, Detach */
 	case 0x5F: /* Wireless console Disable / Special Key */
 		if (quirks->key_wlan_event)
 			*code = quirks->key_wlan_event;

base-commit: 46a51f4f5edade43ba66b3c151f0e25ec8b69cb6

Signature · 1 line
2.51.0
maintainer
#1 lore raw
Quoted 11 lines · Antheas Kapenekakis

It turns out that the dual screen models use 0x5E for attaching and detaching the keyboard instead of 0x5F. So, re-add the codes by reverting commit cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk"). For our future reference, add a comment next to 0x5E indicating that it is used for that purpose.

Fixes cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk")
Reported-by Rahul Chandra <[email protected]>
Closes https://lore.kernel.org/all/10020-68c90c80-d-4ac6c580@106290038/ open here
Cc [email protected]
Signed-off-by Antheas Kapenekakis <[email protected]>

Thank you both, I've taken this to the review-ilpo-fixes branch.

And I'm sorry for the breakage (I was skeptical about removing those keys right from the start even if the original commit's changelog wasn't explaining these extra keys with the detail it should have to avoid us having to second guess).

If Rahul has actually tested the direct revert or this patch and wants to provide a Tested-by tag, I can still embed that into the commit until I push the pending changes to Linus.

Quoted 20 lines
---
 drivers/platform/x86/asus-nb-wmi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +2 -0
index 3a488cf9ca06..6a62bc5b02fd 100644
@@ -673,6 +673,8 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
 		if (atkbd_reports_vol_keys)
 			*code = ASUS_WMI_KEY_IGNORE;
 		break;
+	case 0x5D: /* Wireless console Toggle */
+	case 0x5E: /* Wireless console Enable / Keyboard Attach, Detach */
 	case 0x5F: /* Wireless console Disable / Special Key */
 		if (quirks->key_wlan_event)
 			*code = quirks->key_wlan_event;

base-commit: 46a51f4f5edade43ba66b3c151f0e25ec8b69cb6

Signature · 1 line
 i.