Skip to contentSkip to conversation

KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu

PATCH In review Thorsten Blum 2 participants 2 messages Sep 16, 2025 – Oct 1, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu

kvm_arch_vcpu_ioctl_set_fpu() always returns 0 and the local return variable 'ret' is not used anymore. Remove it.

---
 arch/s390/kvm/kvm-s390.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/s390/kvm/kvm-s390.c +1 -3
index bf6fa8b9ca73..f61cb8a5ea77 100644
@@ -4367,8 +4367,6 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
 
 int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
 {
-	int ret = 0;
-
 	vcpu_load(vcpu);
 
 	vcpu->run->s.regs.fpc = fpu->fpc;
@@ -4379,7 +4377,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
 		memcpy(vcpu->run->s.regs.fprs, &fpu->fprs, sizeof(fpu->fprs));
 
 	vcpu_put(vcpu);
-	return ret;
+	return 0;
 }
 
 int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
Signature · 1 line
2.51.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Thorsten Blum

kvm_arch_vcpu_ioctl_set_fpu() always returns 0 and the local return variable 'ret' is not used anymore. Remove it.

Thanks, picked

Quoted 26 lines
---
  arch/s390/kvm/kvm-s390.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
arch/s390/kvm/kvm-s390.c +1 -3
index bf6fa8b9ca73..f61cb8a5ea77 100644
@@ -4367,8 +4367,6 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
 
  int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
  {
-	int ret = 0;
-
  	vcpu_load(vcpu);
 
  	vcpu->run->s.regs.fpc = fpu->fpc;
@@ -4379,7 +4377,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
  		memcpy(vcpu->run->s.regs.fprs, &fpu->fprs, sizeof(fpu->fprs));
 
  	vcpu_put(vcpu);
-	return ret;
+	return 0;
  }
 
  int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)