Skip to contentSkip to conversation

fixup: alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output

PATCH In review Suren Baghdasaryan 4 participants 6 messages Sep 16, 2025 – Sep 19, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fixup: alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +8 -0
index 1776a06571c2..17668f82ff1c 100644
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not
+              accurate because of the failure to allocate storage required
+              to track some of the allocations made at this location.
+              Deltas in these counters are accurate, therefore counters
+              can be used to track allocation size and count changes.
+
 Example output.
 
 ::

base-commit: 199236646ffd82b5a5bcf2bca1579ea06cb0ae74

Signature · 1 line
2.51.0.384.g4c02a37b29-goog
#1 lore raw
Quoted 16 lines · Suren Baghdasaryan

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +0 -0
index 1776a06571c2..17668f82ff1c 100644

Documentation/filesystems/proc.rst If file version is 2.0 or higher then each line may contain additional · line 1019

Quoted 6 lines
Documentation/filesystems/proc.rst +3 -0
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not

s/values/value/ maybe? :)> + accurate because of the failure to allocate storage required

s/storage required/memory/

Quoted 10 lines
Documentation/filesystems/proc.rst +4 -0
+              to track some of the allocations made at this location.
+              Deltas in these counters are accurate, therefore counters
+              can be used to track allocation size and count changes.
+
 
 Example output.
 
 ::

base-commit: 199236646ffd82b5a5bcf2bca1579ea06cb0ae74

#2 lore raw
Quoted 23 lines · Usama Arif
Quoted 19 lines · Suren Baghdasaryan

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +0 -0
index 1776a06571c2..17668f82ff1c 100644
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
Quoted 5 lines

Documentation/filesystems/proc.rst If file version is 2.0 or higher then each line may contain additional · line 1019

Quoted 3 lines
Documentation/filesystems/proc.rst +3 -0
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not

s/values/value/ maybe? :)> + accurate because of the failure to allocate storage required

Maybe... English is not my first or second language, so I'm not really sure...

Quoted 2 lines

s/storage required/memory/

I'm fine with the proposed changes. Andrew, if you agree with them, could you please fold them in when you pick up this patch?

Quoted 12 lines
Quoted 11 lines
Documentation/filesystems/proc.rst +4 -0
+              to track some of the allocations made at this location.
+              Deltas in these counters are accurate, therefore counters
+              can be used to track allocation size and count changes.
+
 
 Example output.
 
 ::

base-commit: 199236646ffd82b5a5bcf2bca1579ea06cb0ae74

maintainer
#3 lore raw
In reply to Usama Arif
Quoted 22 lines · On Tue, 16 Sep 2025 21:50:51 +0100 Usama Arif <[email protected]> wrote:
Quoted 19 lines · Suren Baghdasaryan

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +0 -0
index 1776a06571c2..17668f82ff1c 100644
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
Quoted 5 lines

Documentation/filesystems/proc.rst If file version is 2.0 or higher then each line may contain additional · line 1019

Quoted 3 lines
Documentation/filesystems/proc.rst +3 -0
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not

s/values/value/ maybe? :)

That's OK as-is.

Quoted 3 lines

+ accurate because of the failure to allocate storage required

s/storage required/memory/

Sure.

From: Andrew Morton <[email protected]>
Subject: alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix
Date: Tue Sep 16 05:53:33 PM PDT 2025

simplification per Usama, reflow text

Cc David Rientjes <[email protected]>
Cc David Wang <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Kent Overstreet <[email protected]>
Cc Pasha Tatashin <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Shakeel Butt <[email protected]>
Cc Sourav Panda <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Usama Arif <[email protected]>
Cc Vlastimil Babka <[email protected]>

---

 Documentation/filesystems/proc.rst |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/filesystems/proc.rst renamed from Documentation/filesystems/proc.rst~alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix +5 -5
@@ -1016,11 +1016,11 @@ For example if the counters are not accu
 
 Supported markers in v2:
 accurate:no
-              Absolute values of the counters in this line are not
-              accurate because of the failure to allocate storage required
-              to track some of the allocations made at this location.
-              Deltas in these counters are accurate, therefore counters
-              can be used to track allocation size and count changes.
+              Absolute values of the counters in this line are not accurate
+              because of the failure to allocate memory to track some of the
+              allocations made at this location.  Deltas in these counters are
+              accurate, therefore counters can be used to track allocation size
+              and count changes.
 
 Example output.
 

_

#4 lore raw
Quoted 46 lines · Andrew Morton
Quoted 22 lines · On Tue, 16 Sep 2025 21:50:51 +0100 Usama Arif <[email protected]> wrote:
Quoted 19 lines · Suren Baghdasaryan

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +0 -0
index 1776a06571c2..17668f82ff1c 100644
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
Quoted 5 lines

Documentation/filesystems/proc.rst If file version is 2.0 or higher then each line may contain additional · line 1019

Quoted 3 lines
Documentation/filesystems/proc.rst +3 -0
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not

s/values/value/ maybe? :)

That's OK as-is.

Quoted 3 lines

+ accurate because of the failure to allocate storage required

s/storage required/memory/

Sure.

From: Andrew Morton <[email protected]>
Subject: alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix
Date: Tue Sep 16 05:53:33 PM PDT 2025

simplification per Usama, reflow text

Quoted 12 lines
Cc David Rientjes <[email protected]>
Cc David Wang <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Kent Overstreet <[email protected]>
Cc Pasha Tatashin <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Shakeel Butt <[email protected]>
Cc Sourav Panda <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Usama Arif <[email protected]>
Cc Vlastimil Babka <[email protected]>

Perfect, Thanks!

Quoted 26 lines

---

 Documentation/filesystems/proc.rst |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/filesystems/proc.rst renamed from Documentation/filesystems/proc.rst~alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix +5 -5
@@ -1016,11 +1016,11 @@ For example if the counters are not accu
 
 Supported markers in v2:
 accurate:no
-              Absolute values of the counters in this line are not
-              accurate because of the failure to allocate storage required
-              to track some of the allocations made at this location.
-              Deltas in these counters are accurate, therefore counters
-              can be used to track allocation size and count changes.
+              Absolute values of the counters in this line are not accurate
+              because of the failure to allocate memory to track some of the
+              allocations made at this location.  Deltas in these counters are
+              accurate, therefore counters can be used to track allocation size
+              and count changes.
 
 Example output.
 

_

reviewer
#5 lore raw
In reply to Andrew Morton

Andrew,

Quoted 65 lines · Andrew Morton
Quoted 22 lines · On Tue, 16 Sep 2025 21:50:51 +0100 Usama Arif <[email protected]> wrote:
Quoted 19 lines · Suren Baghdasaryan

Document new "accurate:no" marker.

Fixes 39d117e04d15 ("alloc_tag: mark inaccurate allocation counters in /proc/allocinfo output")

---
Based on mm-new

 Documentation/filesystems/proc.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/filesystems/proc.rst +0 -0
index 1776a06571c2..17668f82ff1c 100644
@@ -1014,6 +1014,14 @@ If file version is 2.0 or higher then each line may contain additional
 For example if the counters are not accurate, the line will be appended with
 "accurate:no" pair.
 
Quoted 5 lines

Documentation/filesystems/proc.rst If file version is 2.0 or higher then each line may contain additional · line 1019

Quoted 3 lines
Documentation/filesystems/proc.rst +3 -0
+Supported markers in v2:
+accurate:no
+              Absolute values of the counters in this line are not

s/values/value/ maybe? :)

That's OK as-is.

Quoted 3 lines

+ accurate because of the failure to allocate storage required

s/storage required/memory/

Sure.

From: Andrew Morton <[email protected]>
Subject: alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix
Date: Tue Sep 16 05:53:33 PM PDT 2025

simplification per Usama, reflow text

Cc David Rientjes <[email protected]>
Cc David Wang <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Kent Overstreet <[email protected]>
Cc Pasha Tatashin <[email protected]>
Cc Roman Gushchin <[email protected]>
Cc Shakeel Butt <[email protected]>
Cc Sourav Panda <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Usama Arif <[email protected]>
Cc Vlastimil Babka <[email protected]>

---

 Documentation/filesystems/proc.rst |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Documentation/filesystems/proc.rst For example if the counters are not accu · line 1018

Quoted 3 lines
Documentation/filesystems/proc.rst renamed from Documentation/filesystems/proc.rst~alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix +0 -0
@@ -1016,11 +1016,11 @@ For example if the counters are not accu
 
 Supported markers in v2:
 accurate:no

Please insert a blank line here to prevent a docs warning:

linux-next-20250918/Documentation/filesystems/proc.rst:998: ERROR: Unexpected indentation. [docutils]

Thanks.

Quoted 14 lines
Documentation/filesystems/proc.rst renamed from Documentation/filesystems/proc.rst~alloc_tag-mark-inaccurate-allocation-counters-in-proc-allocinfo-output-fix-fix +5 -5
-              Absolute values of the counters in this line are not
-              accurate because of the failure to allocate storage required
-              to track some of the allocations made at this location.
-              Deltas in these counters are accurate, therefore counters
-              can be used to track allocation size and count changes.
+              Absolute values of the counters in this line are not accurate
+              because of the failure to allocate memory to track some of the
+              allocations made at this location.  Deltas in these counters are
+              accurate, therefore counters can be used to track allocation size
+              and count changes.
 
 Example output.
 

_

Signature · 1 line
~Randy