Skip to contentSkip to conversation

dt-bindings: ata: apm,xgene-ahci: Add apm,xgene-ahci-v2 support

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Sep 19, 2025 – Sep 22, 2025

Subsystems (2)
Device tree bindings libata
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ata: apm,xgene-ahci: Add apm,xgene-ahci-v2 support

The "apm,xgene-ahci-v2" compatible has been in use for a long time, but was undocumented. It doesn't require clocks or phys.

Remove the "apm,xgene-ahci-pcie" compatible which isn't used anywhere while we're here.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../bindings/ata/apm,xgene-ahci.yaml          | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/ata/apm,xgene-ahci.yaml +14 -7
index 7dc942808656..dc631381f9e1 100644
@@ -9,14 +9,11 @@ title: APM X-Gene 6.0 Gb/s SATA host controller
 maintainers:
   - Rob Herring <[email protected]>
 
-allOf:
-  - $ref: ahci-common.yaml#
-
 properties:
   compatible:
     enum:
       - apm,xgene-ahci
-      - apm,xgene-ahci-pcie
+      - apm,xgene-ahci-v2
 
   reg:
     minItems: 4

@@ -35,12 +32,22 @@ properties:
 
 required:
   - compatible
-  - clocks
-  - phys
-  - phy-names
 
 unevaluatedProperties: false
 
+allOf:
+  - $ref: ahci-common.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: apm,xgene-ahci
+    then:
+      required:
+        - clocks
+        - phys
+        - phy-names
+
 examples:
   - |
     sata@1a400000 {
Signature · 1 line
2.51.0
maintainer Applied
#1 lore raw
Quoted 7 lines · Rob Herring (Arm)

The "apm,xgene-ahci-v2" compatible has been in use for a long time, but was undocumented. It doesn't require clocks or phys.

Remove the "apm,xgene-ahci-pcie" compatible which isn't used anywhere while we're here.

Signed-off-by Rob Herring (Arm) <[email protected]>

Applied to for-6.18. Thanks !

Signature · 2 lines
Damien Le Moal
Western Digital Research