Skip to contentSkip to conversation

mm/damon/sysfs: do not ignore callback's return value in damon_sysfs_damon_call()

PATCH Applied Akinobu Mita 1 participant 1 message Sep 20, 2025

Subsystems (3)
Stable branch Memory management DAMON
lore
Share & tools
lore

Akinobu Mita

author
#0 lore raw

PATCH v2 1/1 mm/damon/sysfs: do not ignore callback's return value in damon_sysfs_damon_call()

The callback return value is ignored in damon_sysfs_damon_call(), which means that it is not possible to detect invalid user input when writing commands such as 'commit' to /sys/kernel/mm/damon/admin/kdamonds/<K>/state. Fix it.

Signed-off-by Akinobu Mita <[email protected]>
Fixes f64539dcdb87 ("mm/damon/sysfs: use damon_call() for update_schemes_stats")
Cc <[email protected]> # v6.14.x
Reviewed-by SeongJae Park <[email protected]>
---
 mm/damon/sysfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
mm/damon/sysfs.c +3 -1
index fe4e73d0ebbb..3ffe3a77b5db 100644
@@ -1627,12 +1627,14 @@ static int damon_sysfs_damon_call(int (*fn)(void *data),
 		struct damon_sysfs_kdamond *kdamond)
 {
 	struct damon_call_control call_control = {};
+	int err;
 
 	if (!kdamond->damon_ctx)
 		return -EINVAL;
 	call_control.fn = fn;
 	call_control.data = kdamond;
-	return damon_call(kdamond->damon_ctx, &call_control);
+	err = damon_call(kdamond->damon_ctx, &call_control);
+	return err ? err : call_control.return_code;
 }
 
 struct damon_sysfs_schemes_walk_data {
Signature · 1 line
2.43.0