Skip to contentSkip to conversation

FAILED: patch "[PATCH] platform/x86: asus-wmi: Re-add extra keys to ignore_key_wlan" failed to apply to 6.12-stable tree

PATCH [email protected] 2 participants 5 messages Sep 21, 2025

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 225d1ee0f5ba3218d1814d36564fdb5f37b50474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025092126-upstream-favorite-2f89@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 225d1ee0f5ba3218d1814d36564fdb5f37b50474 Mon Sep 17 00:00:00 2001
From: Antheas Kapenekakis <[email protected]>
Date: Tue, 16 Sep 2025 09:28:18 +0200
Subject: [PATCH] platform/x86: asus-wmi: Re-add extra keys to ignore_key_wlan
quirk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It turns out that the dual screen models use 0x5E for attaching and detaching the keyboard instead of 0x5F. So, re-add the codes by reverting commit cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk"). For our future reference, add a comment next to 0x5E indicating that it is used for that purpose.

drivers/platform/x86/asus-nb-wmi.c +2 -0
index 3a488cf9ca06..6a62bc5b02fd 100644
@@ -673,6 +673,8 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
 		if (atkbd_reports_vol_keys)
 			*code = ASUS_WMI_KEY_IGNORE;
 		break;
+	case 0x5D: /* Wireless console Toggle */
+	case 0x5E: /* Wireless console Enable / Keyboard Attach, Detach */
 	case 0x5F: /* Wireless console Disable / Special Key */
 		if (quirks->key_wlan_event)
 			*code = quirks->key_wlan_event;
#1 lore raw
Quoted 9 lines · On Sun, 21 Sept 2025 at 14:34, <[email protected]> wrote:

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

Quoted 9 lines

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 225d1ee0f5ba3218d1814d36564fdb5f37b50474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025092126-upstream-favorite-2f89@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Possible dependencies:

Is commit 1c1d0401d1b8 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") eligible for backport to stable? If yes it fixes the apply conflict. Z13 users would appreciate in any case.

Antheas

Quoted 46 lines

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 225d1ee0f5ba3218d1814d36564fdb5f37b50474 Mon Sep 17 00:00:00 2001
From: Antheas Kapenekakis <[email protected]>
Date: Tue, 16 Sep 2025 09:28:18 +0200
Subject: [PATCH] platform/x86: asus-wmi: Re-add extra keys to ignore_key_wlan
quirk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It turns out that the dual screen models use 0x5E for attaching and detaching the keyboard instead of 0x5F. So, re-add the codes by reverting commit cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk"). For our future reference, add a comment next to 0x5E indicating that it is used for that purpose.

drivers/platform/x86/asus-nb-wmi.c +2 -0
index 3a488cf9ca06..6a62bc5b02fd 100644
@@ -673,6 +673,8 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
                if (atkbd_reports_vol_keys)
                        *code = ASUS_WMI_KEY_IGNORE;
                break;
+       case 0x5D: /* Wireless console Toggle */
+       case 0x5E: /* Wireless console Enable / Keyboard Attach, Detach */
        case 0x5F: /* Wireless console Disable / Special Key */
                if (quirks->key_wlan_event)
                        *code = quirks->key_wlan_event;
author maintainer
#2 lore raw
Quoted 17 lines · Antheas Kapenekakis
Quoted 16 lines · On Sun, 21 Sept 2025 at 14:34, <[email protected]> wrote:

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 225d1ee0f5ba3218d1814d36564fdb5f37b50474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025092126-upstream-favorite-2f89@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Quoted 7 lines
Quoted 2 lines

Possible dependencies:

Is commit 1c1d0401d1b8 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") eligible for backport to stable? If yes it fixes the apply conflict. Z13 users would appreciate in any case.

I don't see that git commit in Linus's tree, are you sure it is correct?

thanks,

greg k-h

#3 lore raw
Quoted 22 lines · Greg KH
Quoted 20 lines · Antheas Kapenekakis
Quoted 18 lines · On Sun, 21 Sept 2025 at 14:34, <[email protected]> wrote:

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 225d1ee0f5ba3218d1814d36564fdb5f37b50474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025092126-upstream-favorite-2f89@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Possible dependencies:

Quoted 6 lines
Quoted 4 lines

Is commit 1c1d0401d1b8 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") eligible for backport to stable? If yes it fixes the apply conflict. Z13 users would appreciate in any case.

I don't see that git commit in Linus's tree, are you sure it is correct?

Sorry, I picked a hash from my own tree by mistake, it is commit 132bfcd24925 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") in v6.17-rc5.

Antheas

Quoted 4 lines

thanks,

greg k-h

author maintainer
#4 lore raw
Quoted 28 lines · Antheas Kapenekakis
Quoted 27 lines · Greg KH
Quoted 24 lines · Antheas Kapenekakis
Quoted 9 lines · On Sun, 21 Sept 2025 at 14:34, <[email protected]> wrote:

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

Quoted 9 lines

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 225d1ee0f5ba3218d1814d36564fdb5f37b50474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025092126-upstream-favorite-2f89@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Possible dependencies:

Is commit 1c1d0401d1b8 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") eligible for backport to stable? If yes it fixes the apply conflict. Z13 users would appreciate in any case.

Quoted 5 lines
Quoted 1 line

I don't see that git commit in Linus's tree, are you sure it is correct?

Sorry, I picked a hash from my own tree by mistake, it is commit 132bfcd24925 ("platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13") in v6.17-rc5.

No problem, that worked, thanks!

greg k-h