mm: silence data-race in update_hiwater_rss
Subsystems (2)
PATCH 1/1 mm: silence data-race in update_hiwater_rss
From: Lance Yang <[email protected]>
KCSAN reports a data race on mm_cluster.hiwater_rss, which can be accessed concurrently from various paths like page migration and memory unmapping without synchronization.
Since hiwater_rss is a statistical field for accounting purposes, this data race is benign. Annotate both the read and write accesses with data_race() to make KCSAN happy.
--- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -1
@@ -2757,7 +2757,7 @@ static inline void update_hiwater_rss(struct mm_struct *mm)unsigned long _rss =get_mm_rss (mm);if (data_race (mm->hiwater_rss) < _rss) - (mm)->hiwater_rss = _rss; +data_race (mm->hiwater_rss = _rss); }static inline void update_hiwater_vm (struct mm_struct *mm)
Signature · 1 line
2.49.0
Quoted 6 lines · Lance Yang
From: Lance Yang <[email protected]>
KCSAN reports a data race on mm_cluster.hiwater_rss, which can be accessed concurrently from various paths like page migration and memory unmapping without synchronization.
Quoted 7 lines
Since
hiwater_rssis a statistical field for accounting purposes, this data race is benign. Annotate both the read and write accesses withdata_race()to make KCSAN happy.Reported-by [email protected]Signed-off-by Lance Yang <[email protected]>
Quoted 17 lines
--- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/mm.h +1
-1@@ -2757,7 +2757,7 @@ static inline void update_hiwater_rss(struct mm_struct *mm)unsigned long _rss =get_mm_rss (mm);if (data_race (mm->hiwater_rss) < _rss) - (mm)->hiwater_rss = _rss; +data_race (mm->hiwater_rss = _rss); }static inline void update_hiwater_vm (struct mm_struct *mm)
Quoted 6 lines · Lance Yang
From: Lance Yang <[email protected]>
KCSAN reports a data race on mm_cluster.hiwater_rss, which can be accessed concurrently from various paths like page migration and memory unmapping without synchronization.
Quoted 7 lines
Since
hiwater_rssis a statistical field for accounting purposes, this data race is benign. Annotate both the read and write accesses withdata_race()to make KCSAN happy.Reported-by [email protected]Signed-off-by Lance Yang <[email protected]>
LGTM, so:
Quoted 21 lines
--- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/mm.h +1
-2@@ -2757,7 +2757,7 @@ static inline void update_hiwater_rss(struct mm_struct *mm)unsigned long _rss =get_mm_rss (mm);if (data_race (mm->hiwater_rss) < _rss) - (mm)->hiwater_rss = _rss; +data_race (mm->hiwater_rss = _rss); }static inline void update_hiwater_vm (struct mm_struct *mm) --2.49.0