Skip to contentSkip to conversation

arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

PATCH Superseded Eric Gonçalves 3 participants 4 messages Sep 28, 2025 – Oct 1, 2025

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Eric Gonçalves

author
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by Eric Gonçalves <[email protected]>

---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag

---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1
index 96662bf9e527..a87e3d23e3e2 100644
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+					       <40 4>, /* Unused */
 };
 
 &usb_1 {
Signature · 1 line
2.51.0
#1 lore raw
Quoted 18 lines · Eric Gonçalves

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by Eric Gonçalves <[email protected]>

---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag

---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
index 96662bf9e527..a87e3d23e3e2 100644

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi &pon_resin { · line 163

Quoted 6 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+					       <40 4>, /* Unused */

This is still not aligned to the opening angle bracket. Could you please recheck your setup?

Quoted 6 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
 };
 
 &usb_1 {
Signature · 1 line
2.51.0
Signature · 2 lines
With best wishes
Dmitry
author
#2 lore raw
Quoted 21 lines · Dmitry Baryshkov
Quoted 20 lines · Eric Gonçalves

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by Eric Gonçalves <[email protected]>

---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag

---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
index 96662bf9e527..a87e3d23e3e2 100644
@@ -159,7 +159,8 @@ &pon_resin {
 };
Quoted 7 lines

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi &pon_resin { · line 163

Quoted 4 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+					       <40 4>, /* Unused */

This is still not aligned to the opening angle bracket. Could you please recheck your setup?

Yeah, sorry, I had it set to 4 spaces still - I sent a v3.

Quoted 8 lines
Quoted 7 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
 };
 
 &usb_1 {
Signature · 1 line
2.51.0
#3 lore raw
In reply to Eric Gonçalves
Quoted 18 lines · Eric Gonçalves

The S20 series has additional reserved pins for the fingerprint sensor, GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by Eric Gonçalves <[email protected]>

---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag

---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +0 -0
index 96662bf9e527..a87e3d23e3e2 100644

arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi &pon_resin { · line 163

Quoted 6 lines
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi +2 -1
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+					       <40 4>, /* Unused */

Please set your tab width to 8 :)

Konrad