Skip to contentSkip to conversation

mount08.c: Add min_kver for test case

PATCH In review Wei Gao via ltp 4 participants 6 messages Sep 29, 2025 – Oct 1, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mount08.c: Add min_kver for test case

---
 testcases/kernel/syscalls/mount/mount08.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/syscalls/mount/mount08.c +1 -0
index fb2b28736..1c454cab4 100644
@@ -63,6 +63,7 @@ static struct tst_test test = {
 	.test_all = run,
 	.needs_root = 1,
 	.mntpoint = MNTPOINT,
+	.min_kver = "6.12",
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "d80b065bb172"},
 		{}
Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!
Again, there has to be explanation here why this is needed...

But given that this is a regression test for a security hardening that was added into 6.12 it's okay if the test fails on older kernel, moreover hiding the failure may make the system more vunerable.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 6 lines · Cyril Hrubis

Hi!
Again, there has to be explanation here why this is needed...

But given that this is a regression test for a security hardening that was added into 6.12 it's okay if the test fails on older kernel, moreover hiding the failure may make the system more vunerable.

Hi,
I agree with rejecting this patch. If a kernel is not patched, the test should fail regardless of kernel version.

Signature · 10 lines
Martin Doucha   [email protected]
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi all,

Quoted 11 lines · Cyril Hrubis
Quoted 6 lines

Hi!
Again, there has to be explanation here why this is needed...

But given that this is a regression test for a security hardening that was added into 6.12 it's okay if the test fails on older kernel, moreover hiding the failure may make the system more vunerable.

Hi,
I agree with rejecting this patch. If a kernel is not patched, the test should fail regardless of kernel version.

For a record, d80b065bb172 is a merge commit, the fix contains actually 7 commits. IMHO none of them has been backported to any stable / LTS kernel. I'll ask Christian and Greg if it makes sense to backport it.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Hi all,

...

Quoted 3 lines

For a record, d80b065bb172 is a merge commit, the fix contains actually 7 commits. IMHO none of them has been backported to any stable / LTS kernel. I'll ask Christian and Greg if it makes sense to backport it.

asked [1]. (unfortunately I forgot to delete message-id and From: from the original message).

Kind regards,
Petr

[1] https://lore.kernel.org/all/[email protected]/

Quoted 2 lines

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

Hi all,

...

Quoted 7 lines

...

Quoted 3 lines

For a record, d80b065bb172 is a merge commit, the fix contains actually 7 commits. IMHO none of them has been backported to any stable / LTS kernel. I'll ask Christian and Greg if it makes sense to backport it.

asked [1]. (unfortunately I forgot to delete message-id and From: from the original message).

FYI answer from Aleksa [2] suggests it will not be backported, but let's wait if somebody else give his opinion. Anyway, I'm not advocating for this patch (to add .min_kver = "6.12"), although it wouldn't harm to document it in the test that unlike kernel folks which consider it as a "new feature" we consider it as a "security fix".

Kind regards,
Petr

Quoted 4 lines

Kind regards,
Petr

[1] https://lore.kernel.org/all/[email protected]/

[2] https://lore.kernel.org/linux-fsdevel/[email protected]/

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp