scsi: ufs: sysfs: Make HID attributes visible
Subsystems (2)
PATCH 1/1 scsi: ufs: sysfs: Make HID attributes visible
Call sysfs_update_group() after reading the device descriptor to ensure the HID sysfs attributes are visible when the feature is supported.
Fixes ae7795a8c258 ("scsi: ufs: core: Add HID support")
Signed-off-by Daniel Lee <[email protected]>
--- drivers/ufs/core/ufs-sysfs.c | 2 +- drivers/ufs/core/ufs-sysfs.h | 1 + drivers/ufs/core/ufshcd.c | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-)
drivers/ufs/core/ufs-sysfs.c +1 -1
@@ -1949,7 +1949,7 @@ static umode_t ufs_sysfs_hid_is_visible(struct kobject *kobj,return hba->dev_info.hid_sup ? attr->mode :0 ; } -static const struct attribute_group ufs_sysfs_hid_group = { +const struct attribute_group ufs_sysfs_hid_group = { .name ="hid" , .attrs = ufs_sysfs_hid, .is_visible = ufs_sysfs_hid_is_visible,
drivers/ufs/core/ufs-sysfs.h +1 -0
@@ -14,5 +14,6 @@ void ufs_sysfs_remove_nodes(struct device *dev);extern const struct attribute_group ufs_sysfs_unit_descriptor_group;extern const struct attribute_group ufs_sysfs_lun_attributes_group; +extern const struct attribute_group ufs_sysfs_hid_group;#endif
drivers/ufs/core/ufshcd.c +2 -0
@@ -8472,6 +8472,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba) DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP) &UFS_DEV_HID_SUPPORT ; +sysfs_update_group (&hba->dev->kobj, &ufs_sysfs_hid_group); + model_index = desc_buf[DEVICE_DESC_PARAM_PRDCT_NAME ]; err = ufshcd_read_string_desc(hba, model_index,
Signature · 1 line
2.51.0.618.g983fd99d29-goog
Quoted 3 lines · Daniel Lee
Call
sysfs_update_group()after reading the device descriptor to ensure the HID sysfs attributes are visible when the feature is supported.
Reviewed-by Bart Van Assche <[email protected]>
Martin K. Petersen
AppliedDaniel,
Quoted 3 lines
Call
sysfs_update_group()after reading the device descriptor to ensure the HID sysfs attributes are visible when the feature is supported.
Applied to 6.18/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen
Martin K. Petersen
AppliedQuoted 5 lines · Daniel Lee
Call
sysfs_update_group()after reading the device descriptor to ensure the HID sysfs attributes are visible when the feature is supported.
Applied to 6.18/scsi-queue, thanks!
[1/1] scsi: ufs: sysfs: Make HID attributes visible
https://git.kernel.org/mkp/scsi/c/bb7663dec67b
Signature · 1 line
Martin K. Petersen