Skip to contentSkip to conversation

rust_binder: remove warning about orphan mappings

PATCH In review Alice Ryhl 3 participants 3 messages Oct 2, 2025 – Oct 3, 2025

Subsystems (2)
lore
Share & tools
lore

Alice Ryhl

author maintainer
#0 lore raw

PATCH 1/1 rust_binder: remove warning about orphan mappings

This condition occurs if a thread dies while processing a transaction. We should not print anything in this scenario.

---
 drivers/android/binder/process.rs | 4 ----
 1 file changed, 4 deletions(-)
drivers/android/binder/process.rs +0 -4
index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
@@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
                 .alloc
                 .take_for_each(|offset, size, debug_id, odata| {
                     let ptr = offset + address;
-                    pr_warn!(
-                        "{}: removing orphan mapping {offset}:{size}\n",
-                        self.pid_in_current_ns()
-                    );
                     let mut alloc =
                         Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
                     if let Some(data) = odata {

---
base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
change-id: 20251002-binder-orphan-d1bc4bcd9777

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Alice Ryhl

This condition occurs if a thread dies while processing a transaction. We should not print anything in this scenario.

thanks,

- Joel

Quoted 25 lines
---
 drivers/android/binder/process.rs | 4 ----
 1 file changed, 4 deletions(-)
drivers/android/binder/process.rs +0 -5
index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
@@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
                 .alloc
                 .take_for_each(|offset, size, debug_id, odata| {
                     let ptr = offset + address;
-                    pr_warn!(
-                        "{}: removing orphan mapping {offset}:{size}\n",
-                        self.pid_in_current_ns()
-                    );
                     let mut alloc =
                         Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
                     if let Some(data) = odata {
 
---

base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
change-id: 20251002-binder-orphan-d1bc4bcd9777

Best regards,

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Alice Ryhl
Quoted 14 lines · Alice Ryhl

This condition occurs if a thread dies while processing a transaction. We should not print anything in this scenario.

---
 drivers/android/binder/process.rs | 4 ----
 1 file changed, 4 deletions(-)
drivers/android/binder/process.rs +0 -0
index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644

drivers/android/binder/process.rs fn deferred_release(self: Arc<Self>) { · line 1351

Quoted 10 lines
drivers/android/binder/process.rs +0 -4
@@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
                 .alloc
                 .take_for_each(|offset, size, debug_id, odata| {
                     let ptr = offset + address;
-                    pr_warn!(
-                        "{}: removing orphan mapping {offset}:{size}\n",
-                        self.pid_in_current_ns()
-                    );
                     let mut alloc =
                         Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
                     if let Some(data) = odata {

LGTM!