Skip to contentSkip to conversation

rtc: fix error return in pm80x_rtc_read_alarm()

PATCH In review Alexandr Sapozhnkiov 2 participants 2 messages Oct 2, 2025 – Oct 3, 2025 Real time clock (RTC)

lore
Share & tools
lore

Alexandr Sapozhnkiov

author
#0 lore raw

PATCH 1/1 rtc: fix error return in pm80x_rtc_read_alarm()

From: Alexandr Sapozhnikov <[email protected]>

The regmap_raw_read() function may return an error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by Alexandr Sapozhnikov <[email protected]>
---
 drivers/rtc/rtc-88pm80x.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/rtc/rtc-88pm80x.c +3 -1
index f40cc06b0979..3651dc8436f0 100644
@@ -153,7 +153,9 @@ static int pm80x_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 		(buf[1] << 8) | buf[0];
 	dev_dbg(info->dev, "%x-%x-%x-%x\n", buf[0], buf[1], buf[2], buf[3]);
 
-	regmap_raw_read(info->map, PM800_RTC_EXPIRE1_1, buf, 4);
+	ret = regmap_raw_read(info->map, PM800_RTC_EXPIRE1_1, buf, 4);
+	if (ret)
+		return ret;
 	data = ((unsigned long)buf[3] << 24) | (buf[2] << 16) |
 		(buf[1] << 8) | buf[0];
 	ticks = base + data;
Signature · 1 line
2.43.0