perf build: Don't leave a.out file when building with clang
Ian Rogers
reviewerPATCH 1/1 perf build: Don't leave a.out file when building with clang
Testing clang features doesn't specify a "-o" option so an a.out file is created and left in the make directory (not the output). Fix this by specifying a "-o" of "/dev/null". Reorganize the code a little to help with readability.
--- tools/perf/util/setup.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
tools/perf/util/setup.py +10 -2
@@ -22,8 +22,16 @@ assert srctree, "Environment variable srctree, for the Linux sources, not set" src_feature_tests = f'{srctree}/tools/build/feature' def clang_has_option(option): - cc_output = Popen([cc, cc_options + option, path.join(src_feature_tests, "test-hello.c") ], stderr=PIPE).stderr.readlines() - return [o for o in cc_output if ((b"unknown argument" in o) or (b"is not supported" in o) or (b"unknown warning option" in o))] == [ ] + error_substrings = ( + b"unknown argument", + b"is not supported", + b"unknown warning option" + ) + clang_command = [cc, cc_options + option, + "-o", "/dev/null", + path.join(src_feature_tests, "test-hello.c") ] + cc_output = Popen(clang_command, stderr=PIPE).stderr.readlines() + return not any(any(error in line for error in error_substrings) for line in cc_output) if cc_is_clang: from sysconfig import get_config_vars
Signature · 1 line
2.51.0.618.g983fd99d29-goog
Ian Rogers
reviewerQuoted 7 lines · Ian Rogers
Testing clang features doesn't specify a "-o" option so an a.out file is created and left in the make directory (not the output). Fix this by specifying a "-o" of "
/dev/null". Reorganize the code a little to help with readability.Signed-off-by Ian Rogers <[email protected]>
Maybe a fixes tag of:
building with clang
Thanks,
Ian
Quoted 30 lines
--- tools/perf/util/setup.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)tools/perf/util/setup.py +10
-3@@ -22,8 +22,16 @@ assert srctree, "Environment variable srctree, for the Linux sources, not set" src_feature_tests = f'{srctree}/tools/build/feature' def clang_has_option(option): - cc_output = Popen([cc, cc_options + option, path.join(src_feature_tests, "test-hello.c") ], stderr=PIPE).stderr.readlines() - return [o for o in cc_output if ((b"unknown argument" in o) or (b"is not supported" in o) or (b"unknown warning option" in o))] == [ ] + error_substrings = ( + b"unknown argument", + b"is not supported", + b"unknown warning option" + ) + clang_command = [cc, cc_options + option, + "-o", "/dev/null", + path.join(src_feature_tests, "test-hello.c") ] + cc_output = Popen(clang_command, stderr=PIPE).stderr.readlines() + return not any(any(error in line for error in error_substrings) for line in cc_output) if cc_is_clang: from sysconfig import get_config_vars --2.51.0.618.g983fd99d29-goog
Hi,
Quoted 6 lines · Ian Rogers
Testing clang features doesn't specify a "-o" option so an a.out file is created and left in the make directory (not the output). Fix this by specifying a "-o" of "
/dev/null". Reorganize the code a little to help with readability.Signed-off-by Ian Rogers <[email protected]>
Quoted 31 lines
--- tools/perf/util/setup.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)tools/perf/util/setup.py +10
-2@@ -22,8 +22,16 @@ assert srctree, "Environment variable srctree, for the Linux sources, not set" src_feature_tests = f'{srctree}/tools/build/feature' def clang_has_option(option): - cc_output = Popen([cc, cc_options + option, path.join(src_feature_tests, "test-hello.c") ], stderr=PIPE).stderr.readlines() - return [o for o in cc_output if ((b"unknown argument" in o) or (b"is not supported" in o) or (b"unknown warning option" in o))] == [ ] + error_substrings = ( + b"unknown argument", + b"is not supported", + b"unknown warning option" + ) + clang_command = [cc, cc_options + option, + "-o", "/dev/null", + path.join(src_feature_tests, "test-hello.c") ] + cc_output = Popen(clang_command, stderr=PIPE).stderr.readlines() + return not any(any(error in line for error in error_substrings) for line in cc_output) if cc_is_clang: from sysconfig import get_config_varsSignature · 1 line
2.51.0.618.g983fd99d29-goog
Thanks
Justin