Skip to contentSkip to conversation

ALSA: hda/tas2781: Enable init_profile_id for device initialization

PATCH In review Shenghao Ding 3 participants 3 messages Oct 7, 2025 – Oct 9, 2025

Subsystems (3)
Stable branch Sound Texas Instruments audio (ASoC/HDA) drivers
lore
Share & tools
lore

Shenghao Ding

author maintainer
#0 lore raw

PATCH 1/1 ALSA: hda/tas2781: Enable init_profile_id for device initialization

Optimize the time consumption of profile switching, init_profile saves the common settings of different profiles, such as the dsp coefficients, etc, which can greatly reduce the profile switching time comsumption and remove the repetitive settings.

Fixes e83dcd139e77 ("ASoC: tas2781: Add keyword "init" in profile section")
Signed-off-by Shenghao Ding <[email protected]>
---
 sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c +12 -0
index 4dea442d8c30..a126f04c3ed7 100644
@@ -474,6 +474,12 @@ static void tasdevice_dspfw_init(void *context)
 	if (tas_priv->fmw->nr_configurations > 0)
 		tas_priv->cur_conf = 0;
 
+	/* Init common setting for different audio profiles */
+	if (tas_priv->rcabin.init_profile_id >= 0)
+		tasdevice_select_cfg_blk(tas_priv,
+			tas_priv->rcabin.init_profile_id,
+			TASDEVICE_BIN_BLK_PRE_POWER_UP);
+
 	/* If calibrated data occurs error, dsp will still works with default
 	 * calibrated data inside algo.
 	 */

@@ -770,6 +776,12 @@ static int tas2781_system_resume(struct device *dev)
 	tasdevice_reset(tas_hda->priv);
 	tasdevice_prmg_load(tas_hda->priv, tas_hda->priv->cur_prog);
 
+	/* Init common setting for different audio profiles */
+	if (tas_hda->priv->rcabin.init_profile_id >= 0)
+		tasdevice_select_cfg_blk(tas_hda->priv,
+			tas_hda->priv->rcabin.init_profile_id,
+			TASDEVICE_BIN_BLK_PRE_POWER_UP);
+
 	if (tas_hda->priv->playback_started)
 		tasdevice_tuning_switch(tas_hda->priv, 0);
Signature · 1 line
2.43.0
#1 lore raw
Quoted 8 lines · Shenghao Ding

Optimize the time consumption of profile switching, init_profile saves the common settings of different profiles, such as the dsp coefficients, etc, which can greatly reduce the profile switching time comsumption and remove the repetitive settings.

Fixes e83dcd139e77 ("ASoC: tas2781: Add keyword "init" in profile section")
Signed-off-by Shenghao Ding <[email protected]>

Applied now. Thanks.

Takashi

build bot
#2 lore raw
In reply to Shenghao Ding
FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH v1] ALSA: hda/tas2781: Enable init_profile_id for device initialization

Link https://lore.kernel.org/stable/20251007103708.1663-1-shenghao-ding%40ti.com open here
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki