extcon: Fixed extcon duplicate issue
Subsystems (2)
PATCH 1/1 extcon: Fixed extcon duplicate issue
extcon_dev_ids may re-alloc to another while this device unregister not complete
The right timing shows below:
on extcon_dev_register: ida_alloc -> device_register on extcon_dev_unregister: device_unregister -> ida_free
stack information when an error occurs:
sysfs: cannot create duplicate filename '/class/extcon/extcon1'
CPU: 7 PID: 222 Comm: init Not tainted 6.6.77-android15-8-g9fab1123989e-ab13366090-4k #1 bbfe3ef014a40c2f67534a3e01169790ce021aeb Hardware name: sun60iw2 (DT) Call trace: dump_backtrace+0xe8/0x108 show_stack+0x18/0x28 dump_stack_lvl+0x50/0x6c dump_stack+0x18/0x24 sysfs_warn_dup+0x68/0x88 sysfs_do_create_link_sd+0x94/0xdc sysfs_create_link+0x30/0x48 device_add_class_symlinks+0xb4/0x12c device_add+0x1e0/0x48c device_register+0x20/0x34 extcon_dev_register+0x3b8/0x5c4 devm_extcon_dev_register+0x4c/0x94
--- drivers/extcon/extcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/extcon/extcon.c +2 -2
@@ -1371,10 +1371,10 @@ void extcon_dev_unregister(struct extcon_dev *edev)return ; } -ida_free (&extcon_dev_ids, edev->id); -device_unregister (&edev->dev); +ida_free (&extcon_dev_ids, edev->id); +if (edev->mutually_exclusive && edev->max_supported) {for (index =0 ; edev->mutually_exclusive[index]; index++)
Signature · 1 line
2.29.0
Quoted 1 line
extcon_dev_idsmay re-alloc to another while this device unregister not complete
…
Will another imperative wording approach become more helpful for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n145
Regards,
Markus
Quoted 24 lines
extcon_dev_idsmay re-alloc to another while this device unregister not completeThe right timing shows below:
onextcon_dev_register:ida_alloc->device_registeronextcon_dev_unregister:device_unregister->ida_freestack information when an error occurs:
sysfs: cannot create duplicate filename '/class/extcon/extcon1'CPU: 7 PID: 222 Comm: init Not tainted 6.6.77-android15-8-g9fab1123989e-ab13366090-4k #1 bbfe3ef014a40c2f67534a3e01169790ce021aeb Hardware name: sun60iw2 (DT) Call trace: dump_backtrace+0xe8/0x108 show_stack+0x18/0x28 dump_stack_lvl+0x50/0x6c dump_stack+0x18/0x24 sysfs_warn_dup+0x68/0x88 sysfs_do_create_link_sd+0x94/0xdc sysfs_create_link+0x30/0x48 device_add_class_symlinks+0xb4/0x12c device_add+0x1e0/0x48c device_register+0x20/0x34 extcon_dev_register+0x3b8/0x5c4 devm_extcon_dev_register+0x4c/0x94
Quoted 1 line
Signed-off-by Michael Wu <[email protected]>
Cheers,
MyungJoo