FAILED: patch "[PATCH] cacheinfo: Check cache properties are present in DT" failed to apply to 6.1-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x cde0fbff07eff7e4e0e85fa053fe19a24c86b1e0
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025101328-ferry-wrought-6a64@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From cde0fbff07eff7e4e0e85fa053fe19a24c86b1e0 Mon Sep 17 00:00:00 2001
From: Pierre Gondois <[email protected]>
Date: Fri, 14 Apr 2023 10:14:50 +0200
Subject: [PATCH] cacheinfo: Check cache properties are present in DT
If a Device Tree (DT) is used, the presence of cache properties is assumed. Not finding any is not considered. For arm64 platforms, cache information can be fetched from the clidr_el1 register. Checking whether cache information is available in the DT allows to switch to using clidr_el1.
init_of_cache_level()
\-of_count_cache_leaves()
will assume there a 2 cache leaves (L1 data/instruction caches), which can be different from clidr_el1 information.
cache_setup_of_node() tries to read cache properties in the DT. If there are none, this is considered a success. Knowing no information was available would allow to switch to using clidr_el1.
drivers/base/cacheinfo.c +32 -0
@@ -78,6 +78,9 @@ bool last_level_cache_is_shared(unsigned int cpu_x, unsigned int cpu_y) } #ifdef CONFIG_OF + +static bool of_check_cache_nodes(struct device_node *np); + /* OF properties to query for a given cache type */ struct cache_type_info { const char *size_prop;
@@ -205,6 +208,11 @@ static int cache_setup_of_node(unsigned int cpu)return -ENOENT ; } +if (!of_check_cache_nodes (np)) { +of_node_put (np); +return -ENOENT ; + } + prev = np;while (index <cache_leaves (cpu)) {
@@ -229,6 +237,25 @@ static int cache_setup_of_node(unsigned int cpu)return 0 ; } +static bool of_check_cache_nodes (struct device_node *np) +{ +struct device_node *next; + +if (of_property_present (np,"cache-size" ) || +of_property_present (np,"i-cache-size" ) || +of_property_present (np,"d-cache-size" ) || +of_property_present (np,"cache-unified" )) +return true; + + next =of_find_next_cache_node (np); +if (next) { +of_node_put (next); +return true; + } + +return false; +} +static int of_count_cache_leaves (struct device_node *np) {unsigned int leaves =0 ;
@@ -260,6 +287,11 @@ int init_of_cache_level(unsigned int cpu)struct device_node *prev =NULL ;unsigned int levels =0 , leaves, level; +if (!of_check_cache_nodes (np)) { +of_node_put (np); +return -ENOENT ; + } + leaves =of_count_cache_leaves (np);if (leaves >0 ) levels =1 ;