Remove TODO
PATCH v4 1/1 Remove TODO
From: Andrea Cervesato <[email protected]>
TODO file is not updated and it talks about goals we already reached via new LTP documentation. In general, it contains generic and random topics which none is updating anymore, so it's better to remove it in order to create less confusion for newcomers.
Instead, we create a todo list in the new documentation, providing a more clear intention of what are the current LTP goals.
---
Changes in v4:
- fix commit message
- point to tst_run_shell.c
- moved to developers
- fix git grep command
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- fix typo
- update command to generate test with old API
- add kirk link in TODO
- shell loader reference
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- add doc/users/todo.rst section
- Link to v1: https://lore.kernel.org/r/[email protected]
--- TODO | 39 -------------------------- doc/developers/todo.rst | 73 +++++++++++++++++++++++++++++++++++++++++++++++++ doc/index.rst | 4 +++ 3 files changed, 77 insertions(+), 39 deletions(-)
TODO deleted +0 -39
@@ -1,39 +0,0 @@ -LTP TODO --------- - - -Write more syscall tests -~~~~~~~~~~~~~~~~~~~~~~~~ - -Syscalls and new syscall flags are added to Linux kernel each development cycle -and LTP still falls behind. Unfortunately there is no single place that would -store comprehensive list of syscalls, but there are a few places to look at: - -One of the options would be looking at changes in man-pages git[1] in man2/ -directory to find out newly documented functionality. - -Another good source of information are kernel pages in LWN[2] weekly -editions. - -Then there is linux-api mailing list[3] where changes in kernel userspace API -should be discussed. - -[1] http://git.kernel.org/cgit/docs/man-pages/man-pages.git -[2] http://lwn.net -[3] http://dir.gmane.org/gmane.linux.kernel.api - - -Rewrite old and add new controller testcases -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - -We already started working on this with rewriting cgroup_fj testcases and -newly added pids testcases. Have a look at testcases/kernel/controllers/. - - -Shell tests cleanups -~~~~~~~~~~~~~~~~~~~~ - -There are numerous testcases written in shell that does not follow single style -and use the broken-by-design binaries from tools/apicmds. These should be -cleaned up and fixed to use the test.sh test library. These include most of -tests in testcases/commands/ for example.
doc/developers/todo.rst new file +73 -0
73 lines not on this page · raw message
doc/index.rst +4 -0
@@ -30,6 +30,7 @@ developers/build_system developers/debugging developers/documentation + developers/todo .. toctree:: :maxdepth: 3
@@ -97,6 +98,9 @@ For developers :doc:`developers/documentation` How to use and develop LTP documentation +:doc:`developers/todo` + List of tasks maintainers are working on + For maintainers ---------------
---
base-commit: 79b7f212b3e56f1a4c33af3f61f66502b574cf1e
change-id: 20251006-remove_todo-c29a585e8b01
Best regards,
Signature · 5 lines
Andrea Cervesato <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Andrea,
Quoted 6 lines
Changes in v4:
- fix commit message
- point totst_run_shell.c
- moved to developers
- fix git grep command
- Link to v3: https://lore.kernel.org/r/[email protected]
Thanks!
...
Quoted 6 lines
doc/developers/todo.rst new file +3
-0@@ -0,0 +1,73 @@ +.. SPDX-License-Identifier: GPL-2.0-or-later + +List of ongoing tasks
doc/developers/todo.rst line 13
Quoted 10 lines
doc/developers/todo.rst new file +10
-0+===================== + +This is a comprehensive list of tasks where LTP maintainers are currently +working on. Priorities might change over time, but these are the most important +points which are currently being achieved. + +Fade out old tests runner +------------------------- + +``runltp`` script is old and unmaintaned. We are slowly shifting to
nit: even this could be a link to script (to show newcomers the ugliness of the script and the need to replace it :)).
:master:runltp script ..
Quoted 2 lines
doc/developers/todo.rst new file +2
-0+`kirk <https://github.com/linux-test-project/kirk>`_, that will be our official +tests runner in the next future.
...
doc/developers/todo.rst line 73
Quoted 13 lines
doc/developers/todo.rst new file +13
-0+LTP maintainers are working on converting shell scripts to plain-C tests, in +order to reduce the impact that shell scripts might have on the overall kernel +testing. + +For a complete list of shell tests, please run the following command inside the +LTP root folder: + +.. code-block:: bash + + git --no-pager grep -l -e '^\. .*_lib\.sh' -e '^\. .*test.sh' + +LTP also provides a shell loader implementation for plain-C tests using +:master:`testcases/lib/tst_run_shell.c`.
I would get wrong impression from this. Although shell loader allows have unique tst_{res,brk} counter when mixing C and shell tests, it can be used for tests solely written in shell. In that case the key point is to use LTP C library.
And when mixing C and shell, it's a shell test which uses C "test" (a tool which uses C API). i.e. test driven by shell test.
Anyway, unless Cyril comes with it's own definition, I'm ok with this. We should write a shell loader doc anyway and then it'll be linked here.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp