Skip to contentSkip to conversation

drm/i915/gem: handle drm_vma_node_allow_once() return value

PATCH New Alexandr Sapozhnikov 2 participants 2 messages Oct 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915/gem: handle drm_vma_node_allow_once() return value

Add missing return value handling of drm_vma_node_allow_once() since the failure to insert the file tag for the node should indicate the whole mmap_offset_attach() failed as well.

v2: update changelog and return error directly as Chris Wilson,
Andi Shyti and Ville Syrjala suggested.
link to v1: https://lore.kernel.org/all/[email protected]/

Found by Linux Verification Center (linuxtesting.org) with svace.

---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +5 -2
index 75f5b0e871ef..eb76f8f2bd95 100644
@@ -758,8 +758,11 @@ mmap_offset_attach(struct drm_i915_gem_object *obj,
 	mmo = insert_mmo(obj, mmo);
 	GEM_BUG_ON(lookup_mmo(obj, mmap_type) != mmo);
 out:
-	if (file)
-		drm_vma_node_allow_once(&mmo->vma_node, file);
+	if (file) {
+		err = drm_vma_node_allow_once(&mmo->vma_node, file);
+		if (err)
+			return ERR_PTR(err);
+	}
 	return mmo;
 
 err:
Signature · 1 line
2.43.0
#1 lore raw

✗ LGCI.VerificationFailed: failure for drm/i915/gem: handle drm_vma_node_allow_once() return value

== Series Details ==

== Series Details ==

Series: drm/i915/gem: handle drm_vma_node_allow_once() return value
URL : https://patchwork.freedesktop.org/series/155912/
State : failure

== Summary ==

Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!