Skip to contentSkip to conversation

usbip: Use min to simplify stub_send_ret_submit

PATCH New Thorsten Blum 1 participant 1 message Oct 17, 2025

Subsystems (2)
USB USB over IP driver
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH 1/1 usbip: Use min to simplify stub_send_ret_submit

Use min() to improve stub_send_ret_submit(). Change the local variable 'size' from 'int' to 'unsigned int' to prevent a signedness error and to match the resulting type.

Signed-off-by Thorsten Blum <[email protected]>
---
 drivers/usb/usbip/stub_tx.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/usb/usbip/stub_tx.c +3 -6
index 7eb2e074012a..55919c3762ba 100644
@@ -4,6 +4,7 @@
  */
 
 #include <linux/kthread.h>
+#include <linux/minmax.h>
 #include <linux/socket.h>
 #include <linux/scatterlist.h>
 

@@ -239,17 +240,13 @@ static int stub_send_ret_submit(struct stub_device *sdev)
 		    urb->actual_length > 0) {
 			if (urb->num_sgs) {
 				unsigned int copy = urb->actual_length;
-				int size;
+				unsigned int size;
 
 				for_each_sg(urb->sg, sg, urb->num_sgs, i) {
 					if (copy == 0)
 						break;
 
-					if (copy < sg->length)
-						size = copy;
-					else
-						size = sg->length;
-
+					size = min(copy, sg->length);
 					iov[iovnum].iov_base = sg_virt(sg);
 					iov[iovnum].iov_len = size;
Signature · 1 line
2.50.1