PCI: starfive: Propagate dev_err_probe return value
Subsystems (4)
PATCH 1/1 PCI: starfive: Propagate dev_err_probe return value
Ensure that the return value from dev_err_probe() is consistently assigned back to return in all error paths within starfive_pcie_clk_rst_init() and starfive_pcie_enable_phy() function. This ensures the original error code are propagation for debugging.
--- drivers/pci/controller/plda/pcie-starfive.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/controller/plda/pcie-starfive.c +3 -3
@@ -180,7 +180,7 @@ static int starfive_pcie_clk_rst_init(struct starfive_jh7110_pcie *pcie) ret =reset_control_deassert (pcie->resets);if (ret) {clk_bulk_disable_unprepare (pcie->num_clks, pcie->clks); -dev_err_probe (dev, ret,"failed to deassert resets\n" ); + ret =dev_err_probe (dev, ret,"failed to deassert resets\n" ); }return ret;
@@ -241,13 +241,13 @@ static int starfive_pcie_enable_phy(struct device *dev, ret =phy_set_mode (pcie->phy,PHY_MODE_PCIE );if (ret) { -dev_err_probe (dev, ret,"failed to set pcie mode\n" ); + ret =dev_err_probe (dev, ret,"failed to set pcie mode\n" ); goto err_phy_on; } ret =phy_power_on (pcie->phy);if (ret) { -dev_err_probe (dev, ret,"failed to power on pcie phy\n" ); + ret =dev_err_probe (dev, ret,"failed to power on pcie phy\n" ); goto err_phy_on; }
base-commit: 98ac9cc4b4452ed7e714eddc8c90ac4ae5da1a09
Signature · 1 line
2.50.1
Quoted 4 lines
Ensure that the return value from
dev_err_probe()is consistently assigned back to return in all error paths withinstarfive_pcie_clk_rst_init()andstarfive_pcie_enable_phy()function. This ensures the original error code are propagation for debugging.
I find the change description improvable.
I propose to take another source code transformation approach better into account.
https://elixir.bootlin.com/linux/v6.17.1/source/drivers/base/core.c#L5031-L5075
ret = dev_err_probe(dev, reset_control_deassert(pcie->resets), "failed to deassert resets\n"); if (ret) clk_bulk_disable_unprepare(pcie->num_clks, pcie->clks);
How do you think about to achieve such a source code variant also with the help of the semantic patch language (Coccinelle software)?
Regards,
Markus