gpio: pca953x: clarify log messages about auto increment feature
PATCH 1/1 gpio: pca953x: clarify log messages about auto increment feature
The probe messages currently print "using AI" and "using no AI", which can be confusing to users unfamiliar with the datasheet term.
Clarify these by spelling out "auto increment", which is the meaning of the AI bit described in the register map.
No functional change, only clearer log wording and matching comment update.
--- drivers/gpio/gpio-pca953x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpio/gpio-pca953x.c +3 -3
@@ -306,7 +306,7 @@ static inline u8 pca953x_get_bit_mask(struct pca953x_chip *chip, unsigned int of* Interrupt mask register 0x40 + 5 * bank_size RW * Interrupt status register 0x40 + 6 * bank_size R * -* - Registers with bit 0x80 set, the AI bit +* - Registers with bit 0x80 set, the AI bit (auto increment) * The bit is cleared and the registers fall into one of the * categories above. */
@@ -1203,10 +1203,10 @@ static int pca953x_probe(struct i2c_client *client)pca953x_setup_gpio (chip, chip->driver_data &PCA_GPIO_MASK );if (NBANK (chip) >2 ||PCA_CHIP_TYPE (chip->driver_data) ==PCA957X_TYPE ) { -dev_info (dev,"using AI\n" ); +dev_info (dev,"using auto increment\n" ); regmap_config = &pca953x_ai_i2c_regmap; }else { -dev_info (dev,"using no AI\n" ); +dev_info (dev,"using no auto increment\n" ); regmap_config = &pca953x_i2c_regmap; }
Signature · 1 line
2.34.1
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 10 lines · Michael Roth
The probe messages currently print "using AI" and "using no AI", which can be confusing to users unfamiliar with the datasheet term.
Clarify these by spelling out "auto increment", which is the meaning of the AI bit described in the register map.
No functional change, only clearer log wording and matching comment update.
[...]
Applied, thanks!
[1/1] gpio: pca953x: clarify log messages about auto increment feature
https://git.kernel.org/brgl/linux/c/6f5976c0cc0977b1fd168d6ecbf3fb36cf041524
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>