Skip to contentSkip to conversation

arm64: dts: socfpga: move sdmmc-ecc to the base DTSI file

PATCH New Dinh Nguyen 1 participant 3 messages Oct 21, 2025

Subsystems (2)
Device tree bindings Arm/socfpga architecture
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/3 arm64: dts: socfpga: move sdmmc-ecc to the base DTSI file

The ECC manager entry for sdmmc should be a chip level entry, not a board entry.

Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi   |  9 +++++++++
 .../boot/dts/altera/socfpga_stratix10_socdk.dts     | 13 -------------
 .../dts/altera/socfpga_stratix10_socdk_nand.dts     | 13 -------------
 3 files changed, 9 insertions(+), 26 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +9 -0
index effd242f6bf7..657e986e5dba 100644
@@ -630,6 +630,15 @@ emac0-tx-ecc@ff8c0400 {
 				interrupts = <5 4>;
 			};
 
+			sdmmca-ecc@ff8c8c00 {
+				compatible = "altr,socfpga-s10-sdmmc-ecc",
+					     "altr,socfpga-sdmmc-ecc";
+				reg = <0xff8c8c00 0x100>;
+				altr,ecc-parent = <&mmc>;
+				interrupts = <14 4>,
+					     <15 4>;
+			};
+
 		};
 
 		qspi: spi@ff8d2000 {
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +0 -13
index 4eee777ef1a1..6aa262fc7f99 100644
@@ -50,19 +50,6 @@ ref_033v: regulator-v-ref {
 		regulator-min-microvolt = <330000>;
 		regulator-max-microvolt = <330000>;
 	};
-
-	soc@0 {
-		eccmgr {
-			sdmmca-ecc@ff8c8c00 {
-				compatible = "altr,socfpga-s10-sdmmc-ecc",
-					     "altr,socfpga-sdmmc-ecc";
-				reg = <0xff8c8c00 0x100>;
-				altr,ecc-parent = <&mmc>;
-				interrupts = <14 4>,
-					     <15 4>;
-			};
-		};
-	};
 };
 
 &pinctrl0 {
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts +0 -13
index 7c53cb9621e5..92954c5beb54 100644
@@ -50,19 +50,6 @@ ref_033v: regulator-v-ref {
 		regulator-min-microvolt = <330000>;
 		regulator-max-microvolt = <330000>;
 	};
-
-	soc@0 {
-		eccmgr {
-			sdmmca-ecc@ff8c8c00 {
-				compatible = "altr,socfpga-s10-sdmmc-ecc",
-					     "altr,socfpga-sdmmc-ecc";
-				reg = <0xff8c8c00 0x100>;
-				altr,ecc-parent = <&mmc>;
-				interrupts = <14 4>,
-					     <15 4>;
-			};
-		};
-	};
 };
 
 &gpio1 {
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#1 lore raw

PATCH 2/3 arm64: dts: socfpga: stratix10: fix bindings warning for ecc manager

Fix ranges warning: Warning (simple_bus_reg): /soc@0/eccmgr: missing or empty reg/ranges property

Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +2 -2
index 657e986e5dba..d72d998adb7b 100644
@@ -581,7 +581,7 @@ sdr: sdr@f8011100 {
 			reg = <0xf8011100 0xc0>;
 		};
 
-		eccmgr {
+		eccmgr: eccmgr@ff8c0000 {
 			compatible = "altr,socfpga-s10-ecc-manager",
 				     "altr,socfpga-a10-ecc-manager";
 			altr,sysmgr-syscon = <&sysmgr>;

@@ -590,7 +590,7 @@ eccmgr {
 			interrupts = <0 15 4>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-			ranges;
+			ranges = <0 0xff8c0000 0x10000>;
 
 			sdramedac {
 				compatible = "altr,sdram-edac-s10";
Signature · 1 line
2.42.0.411.g813d9a9188
author maintainer
#2 lore raw

PATCH 3/3 arm64: dts: socfpga: agilex: fix bindings warning for ecc manager

In reply to Dinh Nguyen

Fix ranges warning: Warning (simple_bus_reg): /soc@0/eccmgr: missing or empty reg/ranges property

Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +2 -2
index c1e66db0f4c5..b8e2f2c3c558 100644
@@ -608,7 +608,7 @@ sdr: sdr@f8011100 {
 			reg = <0xf8011100 0xc0>;
 		};
 
-		eccmgr {
+		eccmgr: eccmgr@ff8c0000 {
 			compatible = "altr,socfpga-s10-ecc-manager",
 				     "altr,socfpga-a10-ecc-manager";
 			altr,sysmgr-syscon = <&sysmgr>;

@@ -617,7 +617,7 @@ eccmgr {
 			interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-			ranges;
+			ranges = <0 0xff8c0000 0x10000>;
 
 			sdramedac {
 				compatible = "altr,sdram-edac-s10";
Signature · 1 line
2.42.0.411.g813d9a9188