ASoC: max98090/91: adding DAPM routing for digital output for max98091
PATCH 4/4 ASoC: max98090/91: adding DAPM routing for digital output for max98091
Each route connects two widgets, so in this patch, the widget "AIFOUT2L" audio interface output left secondary mic and "AIFOUT2R" audio interface output right secondary mic is connected to "SHDN" and also to "SDIEN". Route with "SHDN" as source is required because "SHDN" controls the shutdown and must be ON for codec to operate. Therefore, "AIFOUT2L" and "AIFOUT2R" must be active when "SHDN" is ON. Route with "SDIEN" is required as serial interface logic must be enabled, that means serial port must be enabled, which ensures I2S/TDM clocks and serial data lines are running. This is also the case with audio interface outputs "AIFOUTL" and "AIFOUTR" in primary mic.
--- sound/soc/codecs/max98090.c | 5 +++++ 1 file changed, 5 insertions(+)
sound/soc/codecs/max98090.c +5 -0
@@ -1436,6 +1436,11 @@ static const struct snd_soc_dapm_route max98091_dapm_routes[] = { {"DMIC4", NULL, "DMIC4_ENA"}, {"DMIC3", NULL, "DMIC34_HPF"}, {"DMIC4", NULL, "DMIC34_HPF"}, + + {"AIFOUT2L", NULL, "SHDN"}, + {"AIFOUT2R", NULL, "SHDN"}, + {"AIFOUT2L", NULL, "SDOEN"}, + {"AIFOUT2R", NULL, "SDOEN"}, };static int max98090_add_widgets (struct snd_soc_component *component)
Signature · 1 line
2.30.5
Mark Brown
maintainerQuoted 3 lines · Sharique Mohammad
Each route connects two widgets, so in this patch, the widget "AIFOUT2L" audio interface output left secondary mic and "AIFOUT2R" audio interface output right secondary mic is connected to "SHDN" and also to "SDIEN".
To repeat my prior comment:
This is numbered as though it were part of a series but it's just a loose patch, patch numbers only make sense within a series and create confusion when included outside them.
Please don't ignore review comments, people are generally making them for a reason and are likely to have the same concerns if issues remain unaddressed. Having to repeat the same comments can get repetitive and make people question the value of time spent reviewing. If you disagree with the review comments that's fine but you need to reply and discuss your concerns so that the reviewer can understand your decisions.