Skip to contentSkip to conversation

file_attr02: Add XFS kernel config requirement

PATCH In review Anders Roxell 4 participants 8 messages Oct 24, 2025 – Oct 30, 2025 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 file_attr02: Add XFS kernel config requirement

The file_attr02 test requires XFS filesystem support to properly test the FS_IOC_FSSETXATTR ioctl with project quotas. Add the XFS kernel configuration requirement to ensure the test can run on systems with XFS support either built-in or as a module.

---
 testcases/kernel/syscalls/file_attr/file_attr02.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/file_attr/file_attr02.c +7 -1
index f6625985a514..0ad57177078b 100644
@@ -18,6 +18,11 @@
 #define BLOCKS 128
 #define PROJID 16
 
+static const char *kconfigs[] = {
+	"CONFIG_XFS_FS=y | CONFIG_XFS_FS=m",
+	NULL
+};
+
 static int fd = -1;
 static int dfd = -1;
 static struct fsxattr xattr;
@@ -105,5 +110,6 @@ static struct tst_test test = {
 	.bufs = (struct tst_buffers []) {
 		{&attr, .size = sizeof(struct file_attr)},
 		{}
-	}
+	},
+	.needs_kconfigs = kconfigs,
 };
Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw
Quoted 4 lines

The file_attr02 test requires XFS filesystem support to properly test the FS_IOC_FSSETXATTR ioctl with project quotas. Add the XFS kernel configuration requirement to ensure the test can run on systems with XFS support either built-in or as a module.

So you have problem on the kernel with CONFIG_XFS_FS=y?
I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did not detect it. Could you please post whole output?

Because if code in struct tst_test.filesystems does not work, many tests would be affected with this setup. I'm probably missing something, but I'd prefer to fix the detection in the library than force config (we don't have any CONFIG_.*_FS in testcases/).

Quoted 23 lines
---
 testcases/kernel/syscalls/file_attr/file_attr02.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/file_attr/file_attr02.c +5 -0
index f6625985a514..0ad57177078b 100644
@@ -18,6 +18,11 @@
 #define BLOCKS 128
 #define PROJID 16
 
+static const char *kconfigs[] = {
+	"CONFIG_XFS_FS=y | CONFIG_XFS_FS=m",
+	NULL
+};
+
 static int fd = -1;
 static int dfd = -1;
 static struct fsxattr xattr;

testcases/kernel/syscalls/file_attr/file_attr02.c static struct tst_test test = { · line 114

Quoted 6 lines
testcases/kernel/syscalls/file_attr/file_attr02.c +2 -1
@@ -105,5 +110,6 @@ static struct tst_test test = {
 	.bufs = (struct tst_buffers []) {
 		{&attr, .size = sizeof(struct file_attr)},
 		{}
-	}
+	},
+	.needs_kconfigs = kconfigs,

very nit: we usually use anonymous definition here, instead creating static variable kconfigs[].

Kind regards,
Petr

Quoted 1 line
testcases/kernel/syscalls/file_attr/file_attr02.c +0 -0
 };
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 6 lines · Petr Vorel
Quoted 4 lines

The file_attr02 test requires XFS filesystem support to properly test the FS_IOC_FSSETXATTR ioctl with project quotas. Add the XFS kernel configuration requirement to ensure the test can run on systems with XFS support either built-in or as a module.

So you have problem on the kernel with CONFIG_XFS_FS=y?

No, on systems with CONFIG_XFS_FS=n. We do have the utilities installed and FUSE_FS enabled, but the test says XFS is not supported.

tst_supported_fs_types.c:129: TINFO: Filesystem xfs is not supported

The log file is here:
https://storage.tuxsuite.com/public/linaro/lkft/tests/340jmxk7fPGUn5zJbqsn4Chrs88/logs.txt

Both file_attr02 and file_attr03 fail.

Quoted 8 lines

I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did not detect it. Could you please post whole output?

Because if code in struct tst_test.filesystems does not work, many tests would be affected with this setup. I'm probably missing something, but I'd prefer to fix the detection in the library than force config (we don't have any CONFIG_.*_FS in testcases/).

That's a fair point. I'm not really very familiar with how LTP works.

On the other hand, even if we fixed the LTP framework to not run tests on unsupported filesystems, we might want to still fix it in case someone just ran it with kirk

./tools/kirk/kirk/kirk -c ./testcases/kernel/syscalls/file_attr/file_attr02

or even just directly ./file_attr02

regards,
dan carpenter

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi!

Quoted 7 lines
Quoted 7 lines

I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did not detect it. Could you please post whole output?

Because if code in struct tst_test.filesystems does not work, many tests would be affected with this setup. I'm probably missing something, but I'd prefer to fix the detection in the library than force config (we don't have any CONFIG_.*_FS in testcases/).

I think that we have a but in the test library, it looks like we do not check for the kernel support if we have only one filesystem defined in the tst_test.filesystems.

The problem is that we are trying to avoid formatting and mounting the filesystem for each test iteration (if -i 10 is passed) but that means that we skip the filesystem kernel support. We only check for mkfs in the setup and prepare the device.

This should fix it:

lib/tst_test.c +4 -0
index b8894f782..d49f34623 100644
@@ -1530,6 +1530,10 @@ static void do_setup(int argc, char *argv[])
                tdev.fs_type = default_fs_type();
 
                if (!tst_test->all_filesystems && count_fs_descs() <= 1) {
+
+                       if (!tst_fs_is_supported(tdev.fs_type))
+                               tst_brk(TCONF, "The %s filesystem is not supported", tdev.fs_type);
+
                        if (tst_test->filesystems && tst_test->filesystems->mkfs_ver)
                                tst_check_cmd(tst_test->filesystems->mkfs_ver, 1);
 
Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw
Quoted 14 lines · Cyril Hrubis

Hi!

Quoted 7 lines
Quoted 7 lines

I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did not detect it. Could you please post whole output?

Because if code in struct tst_test.filesystems does not work, many tests would be affected with this setup. I'm probably missing something, but I'd prefer to fix the detection in the library than force config (we don't have any CONFIG_.*_FS in testcases/).

I think that we have a but in the test library, it looks like we do not check for the kernel support if we have only one filesystem defined in the tst_test.filesystems.

Quoted 6 lines

The problem is that we are trying to avoid formatting and mounting the filesystem for each test iteration (if -i 10 is passed) but that means that we skip the filesystem kernel support. We only check for mkfs in the setup and prepare the device.

This should fix it:

Indeed, this fixed the issue I tried it, for both file_attr02 and file_attr03.

Will you create a patch or do you want me to create one?

Cheers,
Anders

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

Hi!

Quoted 3 lines

Indeed, this fixed the issue I tried it, for both file_attr02 and file_attr03.

Will you create a patch or do you want me to create one?

Just send the patch with your Tested-by: thanks.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#6 lore raw
Quoted 7 lines · Cyril Hrubis

Hi!

Quoted 3 lines

Indeed, this fixed the issue I tried it, for both file_attr02 and file_attr03.

Will you create a patch or do you want me to create one?

Just send the patch with your Tested-by: thanks.

Since you're the author we would need your Signed-off-by as well.

regards,
dan carpenter

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp