Skip to contentSkip to conversation

sched/fair: Remove dead code which might prevent from building

PATCH In review Andy Shevchenko 2 participants 2 messages Oct 27, 2025 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/fair: Remove dead code which might prevent from building

Clang, in particular, is not happy about dead code:

kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]

 5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
      |                   ^~~~~~~~~~~~~~~~

1 error generated.

kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)

      |                   ^~~~~~~~~~~~~~~~

1 error generated.

Remove a leftover from the previous cleanup.

Fixes fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
Fixes eb962f251fbb ("sched/fair: Task based throttle time accounting")
---
 kernel/sched/fair.c | 6 ------
 1 file changed, 6 deletions(-)
kernel/sched/fair.c +0 -6
index 273e2871b59e..0370f11e5c25 100644
@@ -5230,7 +5230,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
 }
 
 static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
 
 static void
 requeue_delayed_entity(struct sched_entity *se);
@@ -6733,11 +6732,6 @@ static void dequeue_throttled_task(struct task_struct *p, int flags) {}
 static bool enqueue_throttled_task(struct task_struct *p) { return false; }
 static void record_throttle_clock(struct cfs_rq *cfs_rq) {}
 
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
-{
-	return 0;
-}
-
 static inline bool cfs_rq_pelt_clock_throttled(struct cfs_rq *cfs_rq)
 {
 	return false;
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Andy Shevchenko

Clang, in particular, is not happy about dead code:

kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]

 5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
      |                   ^~~~~~~~~~~~~~~~

1 error generated.

kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)

Quoted 8 lines
      |                   ^~~~~~~~~~~~~~~~

1 error generated.

Remove a leftover from the previous cleanup.

Fixes fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
Fixes eb962f251fbb ("sched/fair: Task based throttle time accounting")

Thanks.