dt-bindings: arm: rockchip: Improve descriptions of Radxa boards
Subsystems (2)
cover dt-bindings: arm: rockchip: Improve descriptions of Radxa boards
This patch series provides the following improvements:
- Fix board names.
- Reorder descriptions into a (mostly) alphanumeric order.
It also adds descriptions for the following board:
- Radxa ROCK 5 ITX+
FUKAUMI Naoki (5):
dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square
dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W
dt-bindings: arm: rockchip: Fix description for Radxa CM3I
dt-bindings: arm: rockchip: Reorder the Radxa board entries
dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+
.../devicetree/bindings/arm/rockchip.yaml | 118 +++++++++--------- 1 file changed, 59 insertions(+), 59 deletions(-)
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 1/5 dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square
The name 'Rock 2' is incorrect; 'Rock2' is correct. Fix this.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
@@ -973,7 +973,7 @@ properties: - const: radxa,rockpis - const: rockchip,rk3308 - - description: Radxa Rock 2 Square + - description: Radxa Rock2 Square items: - const: radxa,rock2-square - const: rockchip,rk3288
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 1/5] dt-bindings: arm: rockchip: Fix description for Radxa Rock2 Square
Quoted 3 lines · FUKAUMI Naoki
The name 'Rock 2' is incorrect; 'Rock2' is correct. Fix this.
Fixes d78084cdb5a95 ("dt-bindings: arm: rockchip: Correct the descriptions for Radxa boards")
That's not a bug, really. Please squash all the patches. These are unimportant trivialities.
Best regards,
Krzysztof
PATCH 2/5 dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W
In reply to FUKAUMI Naoki"3E" precedes "3W" in alphanumeric order. Fix this.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
@@ -1028,7 +1028,7 @@ properties: - const: radxa,rock-5t - const: rockchip,rk3588 - - description: Radxa ZERO 3W/3E + - description: Radxa ZERO 3E/3W items: - enum: - radxa,zero-3e
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/5] dt-bindings: arm: rockchip: Fix description for Radxa ZERO 3E/3W
Quoted 3 lines · FUKAUMI Naoki
"3E" precedes "3W" in alphanumeric order. Fix this.
Fixes ad986e45ada99 ("dt-bindings: arm: rockchip: Add Radxa ZERO 3W/3E")
Nothing to fix. Please invent some sort of bugs according to non-existing rules.
Best regards,
Krzysztof
PATCH 3/5 dt-bindings: arm: rockchip: Fix description for Radxa CM3I
In reply to FUKAUMI Naoki"CM3I" is the preferred name.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
@@ -895,7 +895,7 @@ properties: - const: radxa,cm3 - const: rockchip,rk3566 - - description: Radxa CM3 Industrial + - description: Radxa CM3I items: - enum: - radxa,e25
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/5] dt-bindings: arm: rockchip: Fix description for Radxa CM3I
Quoted 1 line · FUKAUMI Naoki
"CM3I" is the preferred name.
According to whom? I would prefer previous, so for sure:
Quoted 2 lines
Fixes ae9fbe0b1f965 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")
is not true.
Best regards,
Krzysztof
Re: [PATCH 3/5] dt-bindings: arm: rockchip: Fix description for Radxa CM3I
Hi Krzysztof,
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki
"CM3I" is the preferred name.
According to whom? I would prefer previous, so for sure:
Sorry, it should be:
"CM3I" is the correct name.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 8 lines
Quoted 1 line
Fixes ae9fbe0b1f965 ("dt-bindings: arm: rockchip: add Radxa CM3I E25")is not true.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 4/5 dt-bindings: arm: rockchip: Reorder the Radxa board entries
In reply to FUKAUMI NaokiReorder the Radxa board entries alphanumerically, with the following exceptions:
- Place "Rock2 Square" immediately after "Rock".
- Place "ROCK Pi N10" immediately after "ROCK Pi N8".
- Treat "Compute Module 3" as "CM3" for sorting purposes.
--- .../devicetree/bindings/arm/rockchip.yaml | 112 +++++++++--------- 1 file changed, 56 insertions(+), 56 deletions(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +56 -56
@@ -918,6 +918,11 @@ properties: - const: radxa,rock - const: rockchip,rk3188 + - description: Radxa Rock2 Square + items: + - const: radxa,rock2-square + - const: rockchip,rk3288 + - description: Radxa ROCK 2A/2F items: - enum:
@@ -925,16 +930,20 @@ properties: - radxa,rock-2f - const: rockchip,rk3528 - - description: Radxa ROCK Pi 4A/A+/B/B+/C + - description: Radxa ROCK 3A items: - - enum: - - radxa,rockpi4a - - radxa,rockpi4a-plus - - radxa,rockpi4b - - radxa,rockpi4b-plus - - radxa,rockpi4c - - const: radxa,rockpi4 - - const: rockchip,rk3399 + - const: radxa,rock3a + - const: rockchip,rk3568 + + - description: Radxa ROCK 3B + items: + - const: radxa,rock-3b + - const: rockchip,rk3568 + + - description: Radxa ROCK 3C + items: + - const: radxa,rock-3c + - const: rockchip,rk3566 - description: Radxa ROCK 4C+ items:
@@ -951,48 +960,6 @@ properties: - const: radxa,rock-4se - const: rockchip,rk3399 - - description: Radxa ROCK Pi E - items: - - const: radxa,rockpi-e - - const: rockchip,rk3328 - - - description: Radxa ROCK Pi N8 - items: - - const: radxa,rockpi-n8 - - const: vamrs,rk3288-vmarc-som - - const: rockchip,rk3288 - - - description: Radxa ROCK Pi N10 - items: - - const: radxa,rockpi-n10 - - const: vamrs,rk3399pro-vmarc-som - - const: rockchip,rk3399pro - - - description: Radxa ROCK Pi S - items: - - const: radxa,rockpis - - const: rockchip,rk3308 - - - description: Radxa Rock2 Square - items: - - const: radxa,rock2-square - - const: rockchip,rk3288 - - - description: Radxa ROCK 3A - items: - - const: radxa,rock3a - - const: rockchip,rk3568 - - - description: Radxa ROCK 3B - items: - - const: radxa,rock-3b - - const: rockchip,rk3568 - - - description: Radxa ROCK 3C - items: - - const: radxa,rock-3c - - const: rockchip,rk3566 - - description: Radxa ROCK 5 ITX items: - const: radxa,rock-5-itx
@@ -1018,16 +985,49 @@ properties: - const: radxa,rock-5c - const: rockchip,rk3588s - - description: Radxa ROCK S0 - items: - - const: radxa,rock-s0 - - const: rockchip,rk3308 - - description: Radxa ROCK 5T items: - const: radxa,rock-5t - const: rockchip,rk3588 + - description: Radxa ROCK Pi 4A/A+/B/B+/C + items: + - enum: + - radxa,rockpi4a + - radxa,rockpi4a-plus + - radxa,rockpi4b + - radxa,rockpi4b-plus + - radxa,rockpi4c + - const: radxa,rockpi4 + - const: rockchip,rk3399 + + - description: Radxa ROCK Pi E + items: + - const: radxa,rockpi-e + - const: rockchip,rk3328 + + - description: Radxa ROCK Pi N8 + items: + - const: radxa,rockpi-n8 + - const: vamrs,rk3288-vmarc-som + - const: rockchip,rk3288 + + - description: Radxa ROCK Pi N10 + items: + - const: radxa,rockpi-n10 + - const: vamrs,rk3399pro-vmarc-som + - const: rockchip,rk3399pro + + - description: Radxa ROCK Pi S + items: + - const: radxa,rockpis + - const: rockchip,rk3308 + + - description: Radxa ROCK S0 + items: + - const: radxa,rock-s0 + - const: rockchip,rk3308 + - description: Radxa ZERO 3E/3W items: - enum:
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Quoted 2 lines · FUKAUMI Naoki
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
Best regards,
Krzysztof
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
Quoted 2 lines · FUKAUMI Naoki
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
I understand there is no rule, only your preference. Thanks.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Quoted 4 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 1 line · Krzysztof Kozlowski
On 27/10/2025 13:26, FUKAUMI Naoki wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
I understand there is no rule, only your preference. Thanks.
Really there is no? Are you sure?
Best regards,
Krzysztof
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Hi Krzysztof,
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
Quoted 2 lines · FUKAUMI Naoki
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
I understand there is no rule, only your preference. Thanks.
Really there is no? Are you sure?
Could you please tell me what sort of sorting is being used for this file?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Quoted 15 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
Quoted 2 lines · FUKAUMI Naoki
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
I understand there is no rule, only your preference. Thanks.
Really there is no? Are you sure?
Could you please tell me what sort of sorting is being used for this file?
I don't know. I am asking you, because if you re-sort something you clearly must have know the sorting rule. Otherwise without knowing what is current sorting rule, how can you be sure that you sort it correctly instead of just making a mess more messy?
Best regards,
Krzysztof
Re: [PATCH 4/5] dt-bindings: arm: rockchip: Reorder the Radxa board entries
Hi Krzysztof,
Quoted 19 lines · Krzysztof Kozlowski
Quoted 18 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 15 lines · Krzysztof Kozlowski
Quoted 12 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
Quoted 2 lines · FUKAUMI Naoki
Reorder the Radxa board entries alphanumerically, with the following exceptions:
Why? You must explain that in the commit. What sorting is being used by this file? Why do you think your re-order matches that sorting rule?
I understand there is no rule, only your preference. Thanks.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Really there is no? Are you sure?
Could you please tell me what sort of sorting is being used for this file?
I don't know. I am asking you, because if you re-sort something you clearly must have know the sorting rule. Otherwise without knowing what is current sorting rule, how can you be sure that you sort it correctly instead of just making a mess more messy?
If you don't know, how can you be sure my sorting is just making a mess more messy?
I'm going to add a new board (Radxa CM5) to this file. First, could you tell me where I should add it? Second, could you please tell me why that's the correct place?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 4 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 5/5 dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+
In reply to FUKAUMI NaokiThe Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS level. Therefore, we'll simply append the "ITX+" to the existing entry for the Radxa ROCK 5 ITX.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -1
@@ -960,7 +960,7 @@ properties: - const: radxa,rock-4se - const: rockchip,rk3399 - - description: Radxa ROCK 5 ITX + - description: Radxa ROCK 5 ITX/ITX+ items: - const: radxa,rock-5-itx - const: rockchip,rk3588
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 5/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+
Quoted 1 line · FUKAUMI Naoki
The Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS
No clue what you want to say here. Same board? Different board but compatible (then patch is wrong)?
Quoted 2 lines
level. Therefore, we'll simply append the "ITX+" to the existing entry for the Radxa ROCK 5 ITX.
Best regards,
Krzysztof
Re: [PATCH 5/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5 ITX+
Hi Krzysztof,
Thank you very much for your review.
Quoted 5 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki
The Radxa ROCK 5 ITX+ is equivalent to the Radxa ROCK 5 ITX at the DTS
No clue what you want to say here. Same board? Different board but compatible (then patch is wrong)?
The ROCK 5 ITX+ is the ROCK 5 ITX rev.1.2. However, I noticed missing documentation regarding the ROCK 5 ITX+. Since I don't have evidence, I'm dropping this patch. (It's not an issue as it works without this patch.)
I found issues with this entire patch series, so I'm dropping the whole patch series.
Thanks.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 6 lines
Quoted 2 lines
level. Therefore, we'll simply append the "ITX+" to the existing entry for the Radxa ROCK 5 ITX.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip